2010-03-25 16:30:10

by Forrest Zhao

Subject: [PATCH] Set voice_call.watch in correct way

It was set wrongly to device_watch.
---
audio/telephony-ofono.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/telephony-ofono.c b/audio/telephony-ofono.c
index c19e6ee..45c3905 100644
--- a/audio/telephony-ofono.c
+++ b/audio/telephony-ofono.c
@@ -850,7 +850,7 @@ static gboolean handle_vcmanager_property_changed(DBusConnection *conn,
vc_new = g_new0(struct voice_call, 1);
vc_new->obj_path = g_strdup(vc_obj_path);
calls = g_slist_append(calls, vc_new);
- device_watch = g_dbus_add_signal_watch(connection,
+ vc_new->watch = g_dbus_add_signal_watch(connection,
NULL, vc_obj_path,
OFONO_VC_INTERFACE,
"PropertyChanged",
--
1.6.1.3

2010-03-25 10:12:23

by Johan Hedberg

Subject: Re: [PATCH] Set voice_call.watch in correct way

Hi Forrest,

On Thu, Mar 25, 2010, Forrest Zhao wrote:
> It was set wrongly to device_watch.
> ---
> audio/telephony-ofono.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/telephony-ofono.c b/audio/telephony-ofono.c
> index c19e6ee..45c3905 100644
> --- a/audio/telephony-ofono.c
> +++ b/audio/telephony-ofono.c
> @@ -850,7 +850,7 @@ static gboolean handle_vcmanager_property_changed(DBusConnection *conn,
> vc_new = g_new0(struct voice_call, 1);
> vc_new->obj_path = g_strdup(vc_obj_path);
> calls = g_slist_append(calls, vc_new);
> - device_watch = g_dbus_add_signal_watch(connection,
> + vc_new->watch = g_dbus_add_signal_watch(connection,
> NULL, vc_obj_path,
> OFONO_VC_INTERFACE,
> "PropertyChanged",

Pushed upstream. Thanks.

Johan