2010-05-13 13:39:00

by Elvis Pfutzenreuter

[permalink] [raw]
Subject: [PATCH 1/1] Makes extract_svclass_uuid function public

This patch makes the extract_svclass_uuid function public,
so it may be used by applications that link to libbluetooth.
---
lib/sdp.c | 2 +-
lib/sdp_lib.h | 1 +
2 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/lib/sdp.c b/lib/sdp.c
index aa22c63..4d65573 100644
--- a/lib/sdp.c
+++ b/lib/sdp.c
@@ -591,7 +591,7 @@ sdp_data_t *sdp_seq_alloc(void **dtds, void **values, int len)
return sdp_data_alloc(SDP_SEQ8, seq);
}

-static void extract_svclass_uuid(sdp_data_t *data, uuid_t *uuid)
+void extract_svclass_uuid(sdp_data_t *data, uuid_t *uuid)
{
sdp_data_t *d;

diff --git a/lib/sdp_lib.h b/lib/sdp_lib.h
index e506ac1..04bad1f 100644
--- a/lib/sdp_lib.h
+++ b/lib/sdp_lib.h
@@ -167,6 +167,7 @@ sdp_data_t *sdp_seq_alloc(void **dtds, void **values, int len);
sdp_data_t *sdp_seq_alloc_with_length(void **dtds, void **values, int *length, int len);
sdp_data_t *sdp_seq_append(sdp_data_t *seq, sdp_data_t *data);

+void extract_svclass_uuid(sdp_data_t *data, uuid_t *uuid);
int sdp_attr_add(sdp_record_t *rec, uint16_t attr, sdp_data_t *data);
void sdp_attr_remove(sdp_record_t *rec, uint16_t attr);
void sdp_attr_replace(sdp_record_t *rec, uint16_t attr, sdp_data_t *data);
--
1.7.0.4



2010-05-13 15:00:32

by Elvis Pfutzenreuter

[permalink] [raw]
Subject: Re: [PATCH 1/1] Makes extract_svclass_uuid function public

I am working in SDP record parsing for HDP plug-in and needed this one (option is of course implement a static function that does the same).

I will prefix that and resubmit.

On 13/05/2010, at 11:52, Johan Hedberg wrote:

> Hi,
>
> On Thu, May 13, 2010, Elvis Pf?tzenreuter wrote:
>> This patch makes the extract_svclass_uuid function public,
>> so it may be used by applications that link to libbluetooth.
>
> If it's public it needs to be prefixed with sdp_. What's the usecase
> where you need this?
>
> Johan


2010-05-13 14:52:02

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH 1/1] Makes extract_svclass_uuid function public

Hi,

On Thu, May 13, 2010, Elvis Pf?tzenreuter wrote:
> This patch makes the extract_svclass_uuid function public,
> so it may be used by applications that link to libbluetooth.

If it's public it needs to be prefixed with sdp_. What's the usecase
where you need this?

Johan