The fix avoids failure of the second consequent call of 'make clean'.
Signed-off-by: Waldemar Rymarkiewicz <[email protected]>
---
Makefile.am | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 5684e99..2fa03e1 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
$(AM_V_at)$(MKDIR_P) lib/bluetooth
$(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
-clean-local: lib/bluetooth
- @$(RM) -r $<
+clean-local:
+ $(RM) -r lib/bluetooth
\ No newline at end of file
--
1.7.0.4
Hi Waldek,
On Tue, Sep 07, 2010, [email protected] wrote:
> @Johan: Will you consider to push it to upstream ?
Yes, it's now upstream. I was waiting for a comment from Marcel since he
quite often has something to say about autotools file changes, but since
the patch seems quite trivial I went ahead and pushed it.
Johan
Uwe,
There is no intention behind that. Have updated the patch.
@Johan: Will you consider to push it to upstream ?
/Waldek
>-----Original Message-----
>From: Uwe Kleine-K?nig [mailto:[email protected]]
>Sent: Friday, September 03, 2010 9:20 PM
>To: Rymarkiewicz Waldemar
>Cc: [email protected]
>Subject: Re: [PATCH] Fix clean-local target
>
>Hello Waldemar,
>
>On Fri, Sep 03, 2010 at 01:33:33PM +0200, Waldemar Rymarkiewicz wrote:
>> The fix avoids failure of the second consequent call of 'make clean'.
>>
>> Signed-off-by: Waldemar Rymarkiewicz
><[email protected]>
>> ---
>> Makefile.am | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am index 5684e99..2fa03e1 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
>> $(AM_V_at)$(MKDIR_P) lib/bluetooth
>> $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
>>
>> -clean-local: lib/bluetooth
>> - @$(RM) -r $<
>> +clean-local:
>> + $(RM) -r lib/bluetooth
>> \ No newline at end of file
>Is the missing newline at eof on purpose?
>
>Best regards
>Uwe
>
>--
>Pengutronix e.K. | Uwe Kleine-K?nig
> |
>Industrial Linux Solutions |
>http://www.pengutronix.de/ |
>
Hello Waldemar,
On Fri, Sep 03, 2010 at 01:33:33PM +0200, Waldemar Rymarkiewicz wrote:
> The fix avoids failure of the second consequent call of 'make clean'.
>
> Signed-off-by: Waldemar Rymarkiewicz <[email protected]>
> ---
> Makefile.am | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 5684e99..2fa03e1 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
> $(AM_V_at)$(MKDIR_P) lib/bluetooth
> $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
>
> -clean-local: lib/bluetooth
> - @$(RM) -r $<
> +clean-local:
> + $(RM) -r lib/bluetooth
> \ No newline at end of file
Is the missing newline at eof on purpose?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Removed.
Thanks,
/Waldek
>-----Original Message-----
>From: Luiz Augusto von Dentz [mailto:[email protected]]
>Sent: Friday, September 03, 2010 2:13 PM
>To: Rymarkiewicz Waldemar
>Cc: [email protected]
>Subject: Re: [PATCH] Fix clean-local target
>
>Hi,
>
>On Fri, Sep 3, 2010 at 2:33 PM, Waldemar Rymarkiewicz
><[email protected]> wrote:
>> The fix avoids failure of the second consequent call of 'make clean'.
>>
>> Signed-off-by: Waldemar Rymarkiewicz
><[email protected]>
>> ---
>> ?Makefile.am | ? ?4 ++--
>> ?1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/Makefile.am b/Makefile.am index 5684e99..2fa03e1 100644
>> --- a/Makefile.am
>> +++ b/Makefile.am
>> @@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
>> ? ? ? ?$(AM_V_at)$(MKDIR_P) lib/bluetooth
>> ? ? ? ?$(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
>>
>> -clean-local: lib/bluetooth
>> - ? ? ? @$(RM) -r $<
>> +clean-local:
>> + ? ? ? $(RM) -r lib/bluetooth
>> \ No newline at end of file
>> --
>> 1.7.0.4
>
>Could you please remove the Signed-off-by, we don't use it on
>userspace.
>
>--
>Luiz Augusto von Dentz
>Computer Engineer
>
Hi,
On Fri, Sep 3, 2010 at 2:33 PM, Waldemar Rymarkiewicz
<[email protected]> wrote:
> The fix avoids failure of the second consequent call of 'make clean'.
>
> Signed-off-by: Waldemar Rymarkiewicz <[email protected]>
> ---
> ?Makefile.am | ? ?4 ++--
> ?1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index 5684e99..2fa03e1 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -385,5 +385,5 @@ lib/bluetooth/%.h: lib/%.h
> ? ? ? ?$(AM_V_at)$(MKDIR_P) lib/bluetooth
> ? ? ? ?$(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
>
> -clean-local: lib/bluetooth
> - ? ? ? @$(RM) -r $<
> +clean-local:
> + ? ? ? $(RM) -r lib/bluetooth
> \ No newline at end of file
> --
> 1.7.0.4
Could you please remove the Signed-off-by, we don't use it on userspace.
--
Luiz Augusto von Dentz
Computer Engineer