2010-09-06 14:47:12

by Bastien Nocera

[permalink] [raw]
Subject: [PATCH] Make the path to oui.txt a compile-time option

Heya,

We've been carrying a similar (but hard-coded) patch in Fedora for a
long while, and it would be nice if we could do this properly upstream
instead.

Patch attached with explanations.

Cheers


Attachments:
0001-Make-the-path-to-oui.txt-a-compile-time-option.patch (1.88 kB)

2010-09-06 16:10:57

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] Make the path to oui.txt a compile-time option

Hi Bastien,

On Mon, Sep 06, 2010, Bastien Nocera wrote:
> From b96d9394aa850be86ca368aeaeec3bc24c00bce1 Mon Sep 17 00:00:00 2001
> From: Bastien Nocera <[email protected]>
> Date: Mon, 6 Sep 2010 15:43:48 +0100
> Subject: [PATCH] Make the path to oui.txt a compile-time option
>
> This avoids bluetoothd trying to load oui.txt from multiple locations
> and cause SELinux AVC denials by accessing files it's not supposed
> to touch.
> ---
> acinclude.m4 | 8 ++++++++
> configure.ac | 1 +
> src/oui.c | 14 +++-----------
> 3 files changed, 12 insertions(+), 11 deletions(-)

Seems like a good idea. The patch is now upstream.

Johan

2010-09-06 15:12:56

by Pacho Ramos

[permalink] [raw]
Subject: Re: [PATCH] Make the path to oui.txt a compile-time option

El lun, 06-09-2010 a las 15:47 +0100, Bastien Nocera escribió:
> Heya,
>
> We've been carrying a similar (but hard-coded) patch in Fedora for a
> long while, and it would be nice if we could do this properly upstream
> instead.
>
> Patch attached with explanations.
>
> Cheers

What is the proper package to ship oui.txt file? Thanks a lot for the
information :-)


Attachments:
signature.asc (198.00 B)
This is a digitally signed message part

2010-09-06 15:38:21

by Pacho Ramos

[permalink] [raw]
Subject: Re: [PATCH] Make the path to oui.txt a compile-time option

El lun, 06-09-2010 a las 16:22 +0100, Bastien Nocera escribió:
> > OK, thanks, I asked it because under Gentoo no package is currently
> > providing it and a user suggested to supply it with bluez... but I
> > haven't made any decision about this yet
>
> That's probably a good enough way to ship it. Various distributions seem
> to have a different idea on where it should be.
>

Great, I will probably follow your recommendation, thanks a lot :-)


Attachments:
signature.asc (198.00 B)
This is a digitally signed message part

2010-09-06 15:16:52

by Pacho Ramos

[permalink] [raw]
Subject: Re: [PATCH] Make the path to oui.txt a compile-time option

El lun, 06-09-2010 a las 16:15 +0100, Bastien Nocera escribió:
> On Mon, 2010-09-06 at 17:12 +0200, Pacho Ramos wrote:
> > El lun, 06-09-2010 a las 15:47 +0100, Bastien Nocera escribió:
> > > Heya,
> > >
> > > We've been carrying a similar (but hard-coded) patch in Fedora for a
> > > long while, and it would be nice if we could do this properly upstream
> > > instead.
> > >
> > > Patch attached with explanations.
> > >
> > > Cheers
> >
> > What is the proper package to ship oui.txt file? Thanks a lot for the
> > information :-)
>
> No idea. In Fedora we ship it in hwdata. No idea where it lives for
> Debian-based distributions, or others.
>

OK, thanks, I asked it because under Gentoo no package is currently
providing it and a user suggested to supply it with bluez... but I
haven't made any decision about this yet


Attachments:
signature.asc (198.00 B)
This is a digitally signed message part

2010-09-06 15:22:36

by Bastien Nocera

[permalink] [raw]
Subject: Re: [PATCH] Make the path to oui.txt a compile-time option

On Mon, 2010-09-06 at 17:16 +0200, Pacho Ramos wrote:
> El lun, 06-09-2010 a las 16:15 +0100, Bastien Nocera escribi?:
> > On Mon, 2010-09-06 at 17:12 +0200, Pacho Ramos wrote:
> > > El lun, 06-09-2010 a las 15:47 +0100, Bastien Nocera escribi?:
> > > > Heya,
> > > >
> > > > We've been carrying a similar (but hard-coded) patch in Fedora for a
> > > > long while, and it would be nice if we could do this properly upstream
> > > > instead.
> > > >
> > > > Patch attached with explanations.
> > > >
> > > > Cheers
> > >
> > > What is the proper package to ship oui.txt file? Thanks a lot for the
> > > information :-)
> >
> > No idea. In Fedora we ship it in hwdata. No idea where it lives for
> > Debian-based distributions, or others.
> >
>
> OK, thanks, I asked it because under Gentoo no package is currently
> providing it and a user suggested to supply it with bluez... but I
> haven't made any decision about this yet

That's probably a good enough way to ship it. Various distributions seem
to have a different idea on where it should be.


2010-09-06 15:15:14

by Bastien Nocera

[permalink] [raw]
Subject: Re: [PATCH] Make the path to oui.txt a compile-time option

On Mon, 2010-09-06 at 17:12 +0200, Pacho Ramos wrote:
> El lun, 06-09-2010 a las 15:47 +0100, Bastien Nocera escribi?:
> > Heya,
> >
> > We've been carrying a similar (but hard-coded) patch in Fedora for a
> > long while, and it would be nice if we could do this properly upstream
> > instead.
> >
> > Patch attached with explanations.
> >
> > Cheers
>
> What is the proper package to ship oui.txt file? Thanks a lot for the
> information :-)

No idea. In Fedora we ship it in hwdata. No idea where it lives for
Debian-based distributions, or others.