2010-10-30 14:26:21

by Kulikov Vasiliy

Subject: [PATCH] bluetooth: bnep: fix information leak to userland

Structure bnep_conninfo is copied to userland with the field "device"
that has the last elements unitialized. It leads to leaking of
contents of kernel stack memory.

Signed-off-by: Vasiliy Kulikov <[email protected]>
---
Compile tested.

net/bluetooth/bnep/core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c
index f10b41f..5868597 100644
--- a/net/bluetooth/bnep/core.c
+++ b/net/bluetooth/bnep/core.c
@@ -648,6 +648,7 @@ int bnep_del_connection(struct bnep_conndel_req *req)

static void __bnep_copy_ci(struct bnep_conninfo *ci, struct bnep_session *s)
{
+ memset(ci, 0, sizeof(*ci));
memcpy(ci->dst, s->eh.h_source, ETH_ALEN);
strcpy(ci->device, s->dev->name);
ci->flags = s->flags;
--
1.7.0.4

2010-11-03 18:36:00

by Gustavo Padovan

Subject: Re: [PATCH] bluetooth: bnep: fix information leak to userland

* Marcel Holtmann <[email protected]> [2010-11-02 16:35:31 +0100]:

> Hi Vasiiy,
>
> > Structure bnep_conninfo is copied to userland with the field "device"
> > that has the last elements unitialized. It leads to leaking of
> > contents of kernel stack memory.
> >
> > Signed-off-by: Vasiliy Kulikov <[email protected]>
>
> Acked-by: Marcel Holtmann <[email protected]>

Applied, thanks.

--
Gustavo F. Padovan
ProFUSION embedded systems - http://profusion.mobi

2010-11-02 15:35:31

by Marcel Holtmann

Subject: Re: [PATCH] bluetooth: bnep: fix information leak to userland

Hi Vasiiy,

> Structure bnep_conninfo is copied to userland with the field "device"
> that has the last elements unitialized. It leads to leaking of
> contents of kernel stack memory.
>
> Signed-off-by: Vasiliy Kulikov <[email protected]>

Acked-by: Marcel Holtmann <[email protected]>

Regards

Marcel