2011-01-31 19:09:31

by Andre Dieb Martins

Subject: [PATCH 1/2] Implement dump for event LE Read Remote Used Features Complete.

From: André Dieb Martins <[email protected]>

---
parser/hci.c | 23 +++++++++++++++++++++++
1 files changed, 23 insertions(+), 0 deletions(-)

diff --git a/parser/hci.c b/parser/hci.c
index 6f9e2a3..8b45376 100644
--- a/parser/hci.c
+++ b/parser/hci.c
@@ -3546,6 +3546,26 @@ static inline void evt_le_conn_update_complete_dump(int level,
btohs(uevt->supervision_timeout) * 10.0);
}

+static inline void evt_le_read_remote_used_features_complete_dump(int level, struct frame *frm)
+{
+ int i;
+ evt_le_read_remote_used_features_complete *revt = frm->ptr;
+
+ p_indent(level, frm);
+ printf("status 0x%2.2x handle %d\n", revt->status, btohs(revt->handle));
+
+ if (revt->status > 0) {
+ p_indent(level, frm);
+ printf("Error: %s\n", status2str(revt->status));
+ } else {
+ p_indent(level, frm);
+ printf("Features:");
+ for (i = 0; i < 8; i++)
+ printf(" 0x%2.2x", revt->features[i]);
+ printf("\n");
+ }
+}
+
static inline void le_meta_ev_dump(int level, struct frame *frm)
{
evt_le_meta_event *mevt = frm->ptr;
@@ -3569,6 +3589,9 @@ static inline void le_meta_ev_dump(int level, struct frame *frm)
case EVT_LE_CONN_UPDATE_COMPLETE:
evt_le_conn_update_complete_dump(level + 1, frm);
break;
+ case EVT_LE_READ_REMOTE_USED_FEATURES_COMPLETE:
+ evt_le_read_remote_used_features_complete_dump(level + 1, frm);
+ break;
default:
raw_dump(level, frm);
break;
--
1.7.1

2011-01-31 19:09:32

by Andre Dieb Martins

Subject: [PATCH 2/2] Add missing const to utility functions.

From: André Dieb Martins <[email protected]>

---
parser/hci.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/parser/hci.c b/parser/hci.c
index 8b45376..183fa66 100644
--- a/parser/hci.c
+++ b/parser/hci.c
@@ -704,7 +704,7 @@ static char *authentication2str(uint8_t authentication)
}
}

-static char *eventmask2str(uint8_t mask[8])
+static char *eventmask2str(const uint8_t mask[8])
{
int i;

@@ -733,7 +733,7 @@ static char *eventmask2str(uint8_t mask[8])
}
}

-static char *lefeatures2str(uint8_t features[8])
+static char *lefeatures2str(const uint8_t features[8])
{
if (features[0] & 0x01)
return "Link Layer supports LE Encryption";
--
1.7.1

2011-02-01 09:12:08

by Johan Hedberg

Subject: Re: [PATCH 1/2] Implement dump for event LE Read Remote Used Features Complete.

Hi Andr?

On Mon, Jan 31, 2011, Andre Dieb Martins wrote:
> ---
> parser/hci.c | 23 +++++++++++++++++++++++
> 1 files changed, 23 insertions(+), 0 deletions(-)

Both patches have been pushed upstream. Thanks.

Johan