2011-02-04 21:51:45

by Jaikumar Ganesh

Subject: [PATCH] Fix control channel shutdown in case of errors.

From: Jaikumar Ganesh <[email protected]>

When there are connection errors, like host is down, when
establishing the control channel connection, the control io
channel was not being shutdown. This will cause future
connections to fail.
---
input/device.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/input/device.c b/input/device.c
index 5cb57ea..21f8329 100644
--- a/input/device.c
+++ b/input/device.c
@@ -856,6 +856,7 @@ static void control_connect_cb(GIOChannel *chan, GError *conn_err,
error("%s", conn_err->message);
reply = btd_error_failed(iconn->pending_connect,
conn_err->message);
+ g_io_channel_shutdown(chan, TRUE, NULL);
goto failed;
}

--
1.7.3.1

2011-02-07 23:41:27

by Johan Hedberg

Subject: Re: [PATCH] Fix control channel shutdown in case of errors.

Hi Jaikumar,

On Fri, Feb 04, 2011, [email protected] wrote:
> When there are connection errors, like host is down, when
> establishing the control channel connection, the control io
> channel was not being shutdown. This will cause future
> connections to fail.
> ---
> input/device.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)

Thanks, there were several other issues present (which we already
discussed) so a little bit different (and more comprehensive) patch has
now been pushed upstream.

Johan