2011-02-28 15:19:43

by Lukasz Pawlik

[permalink] [raw]
Subject: [PATCH] Fix pulling phonebook entries without last name

This patch fix problem with pulling phonebook entries using PBAP without
last name filled. Previously last name was used to sort phonebook data
now only tracker id is used.
---
plugins/phonebook-tracker.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/plugins/phonebook-tracker.c b/plugins/phonebook-tracker.c
index 9963aab..bc196b8 100644
--- a/plugins/phonebook-tracker.c
+++ b/plugins/phonebook-tracker.c
@@ -135,11 +135,10 @@
"\"NOTACALL\" \"false\" \"false\" " \
"?_contact " \
"WHERE {" \
-" ?_contact a nco:PersonContact ;" \
-" nco:nameFamily ?_key ." \
+" ?_contact a nco:PersonContact ." \
" OPTIONAL {?_contact nco:hasAffiliation ?_role .}" \
"}" \
-"ORDER BY ?_key tracker:id(?_contact)"
+"ORDER BY tracker:id(?_contact)"

#define CONTACTS_QUERY_ALL_LIST \
"SELECT ?c nco:nameFamily(?c) " \
--
1.7.0.4



2011-03-01 19:13:40

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] Fix pulling phonebook entries without last name

Hi Lukasz,

On Mon, Feb 28, 2011, Lukasz Pawlik wrote:
> This patch fix problem with pulling phonebook entries using PBAP without
> last name filled. Previously last name was used to sort phonebook data
> now only tracker id is used.
> ---
> plugins/phonebook-tracker.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)

Pushed upstream. Thanks.

Johan