2011-04-05 18:37:45

by Sheldon Demario

Subject: [PATCH] Fix Characteristic read by UUID on gatttool

The Characteristic read by UUID GATT procedure is not incremental, i.e. it
returns the entire list in a single Read By Type request. Therefore it
should not be called recursively.
---
attrib/gatttool.c | 6 ------
attrib/interactive.c | 6 ------
2 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/attrib/gatttool.c b/attrib/gatttool.c
index 0dfbc04..be91967 100644
--- a/attrib/gatttool.c
+++ b/attrib/gatttool.c
@@ -273,12 +273,6 @@ static void char_read_by_uuid_cb(guint8 status, const guint8 *pdu,

att_data_list_free(list);

- gatt_read_char_by_uuid(char_data->attrib, char_data->start,
- char_data->end, opt_uuid,
- char_read_by_uuid_cb,
- char_data);
-
- return;
done:
g_free(char_data);
g_main_loop_quit(event_loop);
diff --git a/attrib/interactive.c b/attrib/interactive.c
index 3fafb1e..9a55641 100644
--- a/attrib/interactive.c
+++ b/attrib/interactive.c
@@ -315,14 +315,8 @@ static void char_read_by_uuid_cb(guint8 status, const guint8 *pdu,

att_data_list_free(list);

- gatt_read_char_by_uuid(attrib, char_data->start, char_data->end,
- &char_data->uuid, char_read_by_uuid_cb,
- char_data);
-
rl_forced_update_display();

- return;
-
done:
g_free(char_data);
}
--
1.7.1

2011-04-09 17:27:30

by Johan Hedberg

Subject: Re: [PATCH] Fix Characteristic read by UUID on gatttool

Hi Sheldon,

On Tue, Apr 05, 2011, Sheldon Demario wrote:
> The Characteristic read by UUID GATT procedure is not incremental,
> i.e. it returns the entire list in a single Read By Type request.
> Therefore it should not be called recursively.
> ---
> attrib/gatttool.c | 6 ------
> attrib/interactive.c | 6 ------
> 2 files changed, 0 insertions(+), 12 deletions(-)

Pushed upstream. Thanks.

Johan