2011-05-08 18:00:15

by Bartosz Szatkowski

Subject: [PATCH] Fix endian conversion for appparams in pbap client

---
client/pbap.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/client/pbap.c b/client/pbap.c
index 837419c..dee85c8 100644
--- a/client/pbap.c
+++ b/client/pbap.c
@@ -312,6 +312,7 @@ static void read_return_apparam(struct session_data *session,
if (hdr->len == PHONEBOOKSIZE_LEN) {
guint16 val;
memcpy(&val, hdr->val, sizeof(val));
+ val = get_be16(&val);
*phone_book_size = val;
}
break;
--
1.7.5.rc3

2011-05-14 23:30:57

by Johan Hedberg

Subject: Re: [PATCH] Fix endian conversion for appparams in pbap client

Hi,

On Sun, May 08, 2011, Bartosz Szatkowski wrote:
> ---
> client/pbap.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/client/pbap.c b/client/pbap.c
> index 837419c..dee85c8 100644
> --- a/client/pbap.c
> +++ b/client/pbap.c
> @@ -312,6 +312,7 @@ static void read_return_apparam(struct session_data *session,
> if (hdr->len == PHONEBOOKSIZE_LEN) {
> guint16 val;
> memcpy(&val, hdr->val, sizeof(val));
> + val = get_be16(&val);
> *phone_book_size = val;
> }
> break;

Two issues with this:

1. Fix your editor settings. You're using spaces instead of tabs for
indentation.

2. Why not do *phone_book_size = get_be16(&val); directly?

Johan