2011-05-18 10:55:03

by Radoslaw Jablonski

Subject: [PATCH] Fix newmissedcalls handling for large responses

Previously pull_newmissedcalls was called for every part when
processing large response (more that one part of results) and
number of 'newmissedcalls' was wrong in that scenario.
Now newmissedcalls will be counted only once (during generating
first part of mch results).
---
plugins/phonebook-tracker.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/plugins/phonebook-tracker.c b/plugins/phonebook-tracker.c
index 9431d8a..7328bb3 100644
--- a/plugins/phonebook-tracker.c
+++ b/plugins/phonebook-tracker.c
@@ -2027,7 +2027,11 @@ int phonebook_pull_read(void *request)
if(!data)
return -ENOENT;

- if (g_strcmp0(data->req_name, "/telecom/mch.vcf") == 0) {
+ if (g_strcmp0(data->req_name,"/telecom/mch.vcf") == 0 &&
+ data->tracker_index == 0) {
+ /* newmissedcalls amount should be counted only once - it
+ * will be done during generating first part of results of
+ * missed calls history */
query = NEW_MISSED_CALLS_LIST;
col_amount = PULL_QUERY_COL_AMOUNT;
pull_cb = pull_newmissedcalls;
--
1.7.0.4

2011-05-18 19:19:24

by Johan Hedberg

Subject: Re: [PATCH] Fix newmissedcalls handling for large responses

Hi Radek,

On Wed, May 18, 2011, Radoslaw Jablonski wrote:
> Previously pull_newmissedcalls was called for every part when
> processing large response (more that one part of results) and
> number of 'newmissedcalls' was wrong in that scenario.
> Now newmissedcalls will be counted only once (during generating
> first part of mch results).
> ---
> plugins/phonebook-tracker.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)

This conflicts with Slawek's patch. Are both still valid?

Johan