2011-05-19 07:29:22

by Radoslaw Jablonski

Subject: [PATCH v2] Fix newmissedcalls handling for large responses

Previously pull_newmissedcalls was called for every part when
processing large response (more that one part of results) and
number of 'newmissedcalls' was wrong in that scenario.
Now newmissedcalls will be counted only once (during generating
first part of mch results).
---
plugins/phonebook-tracker.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/plugins/phonebook-tracker.c b/plugins/phonebook-tracker.c
index eec1e5d..0d49342 100644
--- a/plugins/phonebook-tracker.c
+++ b/plugins/phonebook-tracker.c
@@ -1544,7 +1544,11 @@ int phonebook_pull_read(void *request)
if(!data)
return -ENOENT;

- if (g_strcmp0(data->req_name, "/telecom/mch.vcf") == 0) {
+ if (g_strcmp0(data->req_name,"/telecom/mch.vcf") == 0 &&
+ data->tracker_index == 0) {
+ /* new missed calls amount should be counted only once - it
+ * will be done during generating first part of results of
+ * missed calls history */
query = NEW_MISSED_CALLS_LIST;
col_amount = NEW_MISSED_CALLS_COL_AMOUNT;
pull_cb = pull_newmissedcalls;
--
1.7.0.4

2011-05-19 23:20:04

by Johan Hedberg

Subject: Re: [PATCH v2] Fix newmissedcalls handling for large responses

Hi Radek,

On Thu, May 19, 2011, Radoslaw Jablonski wrote:
> Previously pull_newmissedcalls was called for every part when
> processing large response (more that one part of results) and
> number of 'newmissedcalls' was wrong in that scenario.
> Now newmissedcalls will be counted only once (during generating
> first part of mch results).
> ---
> plugins/phonebook-tracker.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)

Applied. Thanks.

Johan