2011-09-21 12:49:52

by Dmitriy Paliy

Subject: [PATCH] Fix freeing watches list in maemo6 telephony

This fixes regression introduced in 83064481481d23523e5cdd04.
List watches has to be freed instead of list pending.
---
audio/telephony-maemo6.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/telephony-maemo6.c b/audio/telephony-maemo6.c
index a5845c4..42d693a 100644
--- a/audio/telephony-maemo6.c
+++ b/audio/telephony-maemo6.c
@@ -2017,7 +2017,7 @@ void telephony_exit(void)
g_slist_free_full(pending, pending_req_finalize);
pending = NULL;

- g_slist_free_full(pending, remove_watch);
+ g_slist_free_full(watches, remove_watch);
watches = NULL;

dbus_connection_unref(connection);
--
1.7.4.1

2011-09-27 09:21:19

by Johan Hedberg

Subject: Re: [PATCH] Fix freeing watches list in maemo6 telephony

Hi Dmitriy,

On Wed, Sep 21, 2011, Dmitriy Paliy wrote:
> This fixes regression introduced in 83064481481d23523e5cdd04.
> List watches has to be freed instead of list pending.
> ---
> audio/telephony-maemo6.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)

Applied. Thanks.

Johan

2011-09-21 13:09:34

by Luiz Augusto von Dentz

Subject: Re: [PATCH] Fix freeing watches list in maemo6 telephony

Hi Dmitriy,

On Wed, Sep 21, 2011 at 3:49 PM, Dmitriy Paliy <[email protected]> wrote:
> This fixes regression introduced in 83064481481d23523e5cdd04.
> List watches has to be freed instead of list pending.
> ---
> ?audio/telephony-maemo6.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/audio/telephony-maemo6.c b/audio/telephony-maemo6.c
> index a5845c4..42d693a 100644
> --- a/audio/telephony-maemo6.c
> +++ b/audio/telephony-maemo6.c
> @@ -2017,7 +2017,7 @@ void telephony_exit(void)
> ? ? ? ?g_slist_free_full(pending, pending_req_finalize);
> ? ? ? ?pending = NULL;
>
> - ? ? ? g_slist_free_full(pending, remove_watch);
> + ? ? ? g_slist_free_full(watches, remove_watch);
> ? ? ? ?watches = NULL;
>
> ? ? ? ?dbus_connection_unref(connection);
> --
> 1.7.4.1

Nice catch, ack.

--
Luiz Augusto von Dentz