2011-10-17 12:07:37

by Chan-yeol Park

Subject: [PATCH] Fix input pending connect handling

From: Chan-yeol Park <[email protected]>

iconn->pending_connect needs to be freed after sending the error reply
---
input/device.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/input/device.c b/input/device.c
index 9ff7f20..16eb155 100644
--- a/input/device.c
+++ b/input/device.c
@@ -825,6 +825,9 @@ failed:
reply = btd_error_failed(iconn->pending_connect, err_msg);
g_dbus_send_message(idev->conn, reply);

+ dbus_message_unref(iconn->pending_connect);
+ iconn->pending_connect = NULL;
+
/* So we guarantee the interrupt channel is closed before the
* control channel (if we only do unref GLib will close it only
* after returning control to the mainloop */
--
1.7.4.1

2011-10-17 13:36:19

by Johan Hedberg

Subject: Re: [PATCH] Fix input pending connect handling

Hi Chan-yeol,

On Mon, Oct 17, 2011, [email protected] wrote:
> iconn->pending_connect needs to be freed after sending the error reply
> ---
> input/device.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)

Applied. Thanks, and congrats for getting your first patch upstream! :)

Johan