2011-10-18 10:10:53

by Frederic Danis

Subject: [PATCH v4] fix implicit declaration of 'g_slist_free_full'

audio/avrcp.c: In function 'avrcp_unregister':
audio/avrcp.c:1253: error: implicit declaration of function 'g_slist_free_full'

thermometer/thermometer.c: In function 'destroy_char':
thermometer/thermometer.c:79: error: implicit declaration of function 'g_slist_free_full'
---
audio/avrcp.c | 2 +-
thermometer/thermometer.c | 5 +++++
2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/audio/avrcp.c b/audio/avrcp.c
index 75a8384..e908bf4 100644
--- a/audio/avrcp.c
+++ b/audio/avrcp.c
@@ -52,7 +52,7 @@
#include "avctp.h"
#include "avrcp.h"
#include "sdpd.h"
-#include "glib-helper.h"
+#include "glib-compat.h"
#include "dbus-common.h"

/* Company IDs for vendor dependent commands */
diff --git a/thermometer/thermometer.c b/thermometer/thermometer.c
index 7621926..0d85102 100644
--- a/thermometer/thermometer.c
+++ b/thermometer/thermometer.c
@@ -20,6 +20,10 @@
*
*/

+#ifdef HAVE_CONFIG_H
+#include <config.h>
+#endif
+
#include <gdbus.h>
#include <errno.h>
#include <bluetooth/uuid.h>
@@ -34,6 +38,7 @@
#include "att.h"
#include "gatt.h"
#include "thermometer.h"
+#include "glib-compat.h"

#define THERMOMETER_INTERFACE "org.bluez.Thermometer"

--
1.7.1

2011-10-18 10:30:59

by Johan Hedberg

Subject: Re: [PATCH v4] fix implicit declaration of 'g_slist_free_full'

Hi Fr?d?ric,

On Tue, Oct 18, 2011, Fr?d?ric Danis wrote:
> audio/avrcp.c: In function 'avrcp_unregister':
> audio/avrcp.c:1253: error: implicit declaration of function 'g_slist_free_full'
>
> thermometer/thermometer.c: In function 'destroy_char':
> thermometer/thermometer.c:79: error: implicit declaration of function 'g_slist_free_full'
> ---
> audio/avrcp.c | 2 +-
> thermometer/thermometer.c | 5 +++++
> 2 files changed, 6 insertions(+), 1 deletions(-)

Applied. Thanks.

Btw, to be consistent with the commit history, in the future please
start the commit message with a capital letter, i.e. "Fix.." instead of
"fix..".

Johan