2011-11-09 05:59:39

by Syam Sidhardhan

Subject: [PATCH obexd 1/2] Fix empty parameter list in function declaration

---
plugins/messages-tracker.c | 2 +-
src/log.c | 2 +-
src/manager.c | 2 +-
src/transport.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/plugins/messages-tracker.c b/plugins/messages-tracker.c
index 218a016..8f9b30a 100644
--- a/plugins/messages-tracker.c
+++ b/plugins/messages-tracker.c
@@ -120,7 +120,7 @@ static void destroy_folder_tree(void *root)
g_free(folder);
}

-static void create_folder_tree()
+static void create_folder_tree(void)
{
struct message_folder *parent, *child;

diff --git a/src/log.c b/src/log.c
index baa57c5..db7b5f3 100644
--- a/src/log.c
+++ b/src/log.c
@@ -92,7 +92,7 @@ static gboolean is_enabled(struct obex_debug_desc *desc)
return 0;
}

-void __obex_log_enable_debug()
+void __obex_log_enable_debug(void)
{
struct obex_debug_desc *desc;

diff --git a/src/manager.c b/src/manager.c
index db5d67d..3953e9d 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -450,7 +450,7 @@ void manager_unregister_transfer(struct obex_session *os)
g_free(path);
}

-static void agent_cancel()
+static void agent_cancel(void)
{
DBusMessage *msg;

diff --git a/src/transport.c b/src/transport.c
index 6d51f53..f178e44 100644
--- a/src/transport.c
+++ b/src/transport.c
@@ -53,7 +53,7 @@ static struct obex_transport_driver *obex_transport_driver_find(
return NULL;
}

-GSList *obex_transport_driver_list()
+GSList *obex_transport_driver_list(void)
{
return drivers;
}
--
1.7.4.1

2011-11-14 10:53:24

by Johan Hedberg

Subject: Re: [PATCH obexd 1/2] Fix empty parameter list in function declaration

Hi Syam,

On Wed, Nov 09, 2011, Syam Sidhardhan wrote:
> ---
> plugins/messages-tracker.c | 2 +-
> src/log.c | 2 +-
> src/manager.c | 2 +-
> src/transport.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)

Both patches have been applied. Thanks.

Johan

2011-11-09 05:59:40

by Syam Sidhardhan

Subject: [PATCH obexd 2/2] Fix dbus memory leak

---
plugins/usb.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/plugins/usb.c b/plugins/usb.c
index a0ec21b..12fb30c 100644
--- a/plugins/usb.c
+++ b/plugins/usb.c
@@ -242,11 +242,13 @@ static void *usb_start(struct obex_server *server, int *err)
if (dbus_connection_send_with_reply(connection,
msg, &call, -1) == FALSE) {
error("usb: unable to send mode_request");
+ dbus_message_unref(msg);
goto fail;
}

dbus_pending_call_set_notify(call, mode_request_reply, server, NULL);
dbus_pending_call_unref(call);
+ dbus_message_unref(msg);

id = g_dbus_add_signal_watch(connection, NULL, NULL,
"com.meego.usb_moded",
--
1.7.4.1