2012-03-14 22:07:40

by Vinicius Costa Gomes

Subject: [PATCH BlueZ] attrib-server: Fix sending "not supported" for indications/notifications

Now that our Attribute Client is able to handle notifications and
indications we don't need to respond that they are not supported.
---
src/attrib-server.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/src/attrib-server.c b/src/attrib-server.c
index 6268fe4..5775861 100644
--- a/src/attrib-server.c
+++ b/src/attrib-server.c
@@ -981,6 +981,10 @@ static void channel_handler(const uint8_t *ipdu, uint16_t len,
break;
case ATT_OP_HANDLE_CNF:
return;
+ case ATT_OP_HANDLE_IND:
+ case ATT_OP_HANDLE_NOTIFY:
+ /* The attribute client is already handling these */
+ return;
case ATT_OP_READ_MULTI_REQ:
case ATT_OP_PREP_WRITE_REQ:
case ATT_OP_EXEC_WRITE_REQ:
--
1.7.9.3

2012-03-16 15:23:30

by Johan Hedberg

Subject: Re: [PATCH BlueZ] attrib-server: Fix sending "not supported" for indications/notifications

Hi Vinicius,

On Wed, Mar 14, 2012, Vinicius Costa Gomes wrote:
> Now that our Attribute Client is able to handle notifications and
> indications we don't need to respond that they are not supported.
> ---
> src/attrib-server.c | 4 ++++
> 1 file changed, 4 insertions(+)

Applied. Thanks.

Johan