2012-03-20 17:49:33

by Vinicius Costa Gomes

Subject: [PATCH BlueZ] Fix not marking a reverse SDP discovery as "reverse"

Some devices "hide" some of their records while connected to other
devices. Setting a service discovery as reverse makes BlueZ to not
remove the records that are "hidden".

This patch fixes a mistake that reverse parameter was changed to false
when it should be true.
---
src/device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/device.c b/src/device.c
index 0a1de7c..2bc0620 100644
--- a/src/device.c
+++ b/src/device.c
@@ -2204,7 +2204,7 @@ static gboolean start_discovery(gpointer user_data)
struct btd_device *device = user_data;

if (device_is_bredr(device))
- device_browse_sdp(device, NULL, NULL, NULL, FALSE);
+ device_browse_sdp(device, NULL, NULL, NULL, TRUE);
else
device_browse_primary(device, NULL, NULL, FALSE);

--
1.7.9.4

2012-03-20 18:05:53

by Johan Hedberg

Subject: Re: [PATCH BlueZ] Fix not marking a reverse SDP discovery as "reverse"

Hi Vinicius,

On Tue, Mar 20, 2012, Vinicius Costa Gomes wrote:
> Some devices "hide" some of their records while connected to other
> devices. Setting a service discovery as reverse makes BlueZ to not
> remove the records that are "hidden".
>
> This patch fixes a mistake that reverse parameter was changed to false
> when it should be true.
> ---
> src/device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied. Thanks.

Johan