2012-08-15 21:13:59

by Andre Guedes

Subject: [PATCH BlueZ 1/2] mgmt: Fix Set LE command complete

Once we get a Set LE command complete event, we should update
current_settings from the controller_info. Otherwise, features
which depend on that, such as device discovery, will not work
properly.
---
src/mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mgmt.c b/src/mgmt.c
index b3ae776..fbd2a6b 100644
--- a/src/mgmt.c
+++ b/src/mgmt.c
@@ -1388,7 +1388,7 @@ static void mgmt_cmd_complete(int sk, uint16_t index, void *buf, size_t len)
DBG("set_ssp complete");
break;
case MGMT_OP_SET_LE:
- DBG("set_le complete");
+ mgmt_new_settings(sk, index, ev->data, len);
break;
case MGMT_OP_ADD_UUID:
mgmt_add_uuid_complete(sk, index, ev->data, len);
--
1.7.11.4

2012-08-16 07:36:40

by Johan Hedberg

Subject: Re: [PATCH BlueZ 1/2] mgmt: Fix Set LE command complete

Hi Andre,

On Wed, Aug 15, 2012, Andre Guedes wrote:
> Once we get a Set LE command complete event, we should update
> current_settings from the controller_info. Otherwise, features
> which depend on that, such as device discovery, will not work
> properly.
> ---
> src/mgmt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Both patches have been applied. Thanks.

Johan

2012-08-15 21:14:00

by Andre Guedes

Subject: [PATCH BlueZ 2/2] mgmt: Fix Set SSP command complete

Once we get a Set SSP command complete event, we should update
current_settings from the controller_info. Otherwise, features
which depend on that will not work properly.
---
src/mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mgmt.c b/src/mgmt.c
index fbd2a6b..94b2a04 100644
--- a/src/mgmt.c
+++ b/src/mgmt.c
@@ -1385,7 +1385,7 @@ static void mgmt_cmd_complete(int sk, uint16_t index, void *buf, size_t len)
mgmt_new_settings(sk, index, ev->data, len);
break;
case MGMT_OP_SET_SSP:
- DBG("set_ssp complete");
+ mgmt_new_settings(sk, index, ev->data, len);
break;
case MGMT_OP_SET_LE:
mgmt_new_settings(sk, index, ev->data, len);
--
1.7.11.4