2012-10-25 01:46:29

by Dwaine Garden VE3GIF

[permalink] [raw]
Subject: [PATCH] Bluetooth: Add support for Atheros [04ca:3004]


Add another vendor specific ID for Atheros AR3012 device.
This chip is wrapped by Lite-On Technology Corp.

output of usb-devices:

Bus 001 Device 008: ID 04ca:3004 Lite-On Technology Corp.
Device Descriptor:
? bLength??????????????? 18
? bDescriptorType???????? 1
? bcdUSB?????????????? 1.10
? bDeviceClass????????? 224 Wireless
? bDeviceSubClass???????? 1 Radio Frequency
? bDeviceProtocol???????? 1 Bluetooth
? bMaxPacketSize0??????? 64
? idVendor?????????? 0x04ca Lite-On Technology Corp.
? idProduct????????? 0x3004
? bcdDevice??????????? 0.02
? iManufacturer?????????? 1 Atheros Communications
? iProduct??????????????? 2 Bluetooth USB Host Controller
? iSerial???????????????? 3 Alaska Day 2006
? bNumConfigurations????? 1
? Configuration Descriptor:
??? bLength???????????????? 9
??? bDescriptorType???????? 2
??? wTotalLength????????? 177
??? bNumInterfaces????????? 2
??? bConfigurationValue???? 1
??? iConfiguration????????? 4 BT HCI
??? bmAttributes???????? 0xe0
????? Self Powered
????? Remote Wakeup
??? MaxPower????????????? 100mA
??? Interface Descriptor:
????? bLength???????????????? 9
????? bDescriptorType???????? 4
????? bInterfaceNumber??????? 0
????? bAlternateSetting?????? 0
????? bNumEndpoints?????????? 3
????? bInterfaceClass?????? 224 Wireless
????? bInterfaceSubClass????? 1 Radio Frequency
????? bInterfaceProtocol????? 1 Bluetooth
????? iInterface????????????? 0
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x81? EP 1 IN
??????? bmAttributes??????????? 3
????????? Transfer Type??????????? Interrupt
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0010? 1x 16 bytes
??????? bInterval?????????????? 1
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x82? EP 2 IN
??????? bmAttributes??????????? 2
????????? Transfer Type??????????? Bulk
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0040? 1x 64 bytes
??????? bInterval?????????????? 1
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x02? EP 2 OUT
??????? bmAttributes??????????? 2
????????? Transfer Type??????????? Bulk
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0040? 1x 64 bytes
??????? bInterval?????????????? 1
??? Interface Descriptor:
????? bLength???????????????? 9
????? bDescriptorType???????? 4
????? bInterfaceNumber??????? 1
????? bAlternateSetting?????? 0
????? bNumEndpoints?????????? 2
????? bInterfaceClass?????? 224 Wireless
????? bInterfaceSubClass????? 1 Radio Frequency
????? bInterfaceProtocol????? 1 Bluetooth
????? iInterface????????????? 0
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x83? EP 3 IN
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0000? 1x 0 bytes
??????? bInterval?????????????? 1
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x03? EP 3 OUT
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0000? 1x 0 bytes
??????? bInterval?????????????? 1
??? Interface Descriptor:
????? bLength???????????????? 9
????? bDescriptorType???????? 4
????? bInterfaceNumber??????? 1
????? bAlternateSetting?????? 1
????? bNumEndpoints?????????? 2
????? bInterfaceClass?????? 224 Wireless
????? bInterfaceSubClass????? 1 Radio Frequency
????? bInterfaceProtocol????? 1 Bluetooth
????? iInterface????????????? 0
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x83? EP 3 IN
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0009? 1x 9 bytes
??????? bInterval?????????????? 1
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x03? EP 3 OUT
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0009? 1x 9 bytes
??????? bInterval?????????????? 1
??? Interface Descriptor:
????? bLength???????????????? 9
????? bDescriptorType???????? 4
????? bInterfaceNumber??????? 1
????? bAlternateSetting?????? 2
????? bNumEndpoints?????????? 2
????? bInterfaceClass?????? 224 Wireless
????? bInterfaceSubClass????? 1 Radio Frequency
????? bInterfaceProtocol????? 1 Bluetooth
????? iInterface????????????? 0
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x83? EP 3 IN
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0011? 1x 17 bytes
??????? bInterval?????????????? 1
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x03? EP 3 OUT
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0011? 1x 17 bytes
??????? bInterval?????????????? 1
??? Interface Descriptor:
????? bLength???????????????? 9
????? bDescriptorType???????? 4
????? bInterfaceNumber??????? 1
????? bAlternateSetting?????? 3
????? bNumEndpoints?????????? 2
????? bInterfaceClass?????? 224 Wireless
????? bInterfaceSubClass????? 1 Radio Frequency
????? bInterfaceProtocol????? 1 Bluetooth
????? iInterface????????????? 0
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x83? EP 3 IN
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0019? 1x 25 bytes
??????? bInterval?????????????? 1
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x03? EP 3 OUT
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0019? 1x 25 bytes
??????? bInterval?????????????? 1
??? Interface Descriptor:
????? bLength???????????????? 9
????? bDescriptorType???????? 4
????? bInterfaceNumber??????? 1
????? bAlternateSetting?????? 4
????? bNumEndpoints?????????? 2
????? bInterfaceClass?????? 224 Wireless
????? bInterfaceSubClass????? 1 Radio Frequency
????? bInterfaceProtocol????? 1 Bluetooth
????? iInterface????????????? 0
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x83? EP 3 IN
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0021? 1x 33 bytes
??????? bInterval?????????????? 1
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x03? EP 3 OUT
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0021? 1x 33 bytes
??????? bInterval?????????????? 1
??? Interface Descriptor:
????? bLength???????????????? 9
????? bDescriptorType???????? 4
????? bInterfaceNumber??????? 1
????? bAlternateSetting?????? 5
????? bNumEndpoints?????????? 2
????? bInterfaceClass?????? 224 Wireless
????? bInterfaceSubClass????? 1 Radio Frequency
????? bInterfaceProtocol????? 1 Bluetooth
????? iInterface????????????? 0
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x83? EP 3 IN
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0031? 1x 49 bytes
??????? bInterval?????????????? 1
????? Endpoint Descriptor:
??????? bLength???????????????? 7
??????? bDescriptorType???????? 5
??????? bEndpointAddress???? 0x03? EP 3 OUT
??????? bmAttributes??????????? 1
????????? Transfer Type??????????? Isochronous
????????? Synch Type?????????????? None
????????? Usage Type?????????????? Data
??????? wMaxPacketSize???? 0x0031? 1x 49 bytes
??????? bInterval?????????????? 1
Device Status:???? 0x0003
? Self Powered
? Remote Wakeup Enabled


Signed-off-by: Dwaine Garden <[email protected]> ?

---

diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
index fc2de55..1486f15 100644
--- a/drivers/bluetooth/ath3k.c
+++ b/drivers/bluetooth/ath3k.c
@@ -75,6 +75,7 @@ static struct usb_device_id ath3k_table[] = {
??????? { USB_DEVICE(0x0CF3, 0x3004) },
??????? { USB_DEVICE(0x0CF3, 0x311D) },
??????? { USB_DEVICE(0x13d3, 0x3375) },
+????? { USB_DEVICE(0x04CA, 0x3004) },
??????? { USB_DEVICE(0x04CA, 0x3005) },
??????? { USB_DEVICE(0x13d3, 0x3362) },
??????? { USB_DEVICE(0x0CF3, 0xE004) },
@@ -102,6 +103,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {
??????? { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
??????? { USB_DEVICE(0x0cf3, 0x311D), .driver_info = BTUSB_ATH3012 },
??????? { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
+????? { USB_DEVICE(0x04ca, 0x3004), .driver_info = BTUSB_ATH3012 },
??????? { USB_DEVICE(0x04ca, 0x3005), .driver_info = BTUSB_ATH3012 },
??????? { USB_DEVICE(0x13d3, 0x3362), .driver_info = BTUSB_ATH3012 },
??????? { USB_DEVICE(0x0cf3, 0xe004), .driver_info = BTUSB_ATH3012 },
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index debda27..0529cee 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -132,6 +132,7 @@ static struct usb_device_id blacklist_table[] = {
??????? { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
??????? { USB_DEVICE(0x0cf3, 0x311d), .driver_info = BTUSB_ATH3012 },
??????? { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
+????? { USB_DEVICE(0x04ca, 0x3004), .driver_info = BTUSB_ATH3012 },
??????? { USB_DEVICE(0x04ca, 0x3005), .driver_info = BTUSB_ATH3012 },
??????? { USB_DEVICE(0x13d3, 0x3362), .driver_info = BTUSB_ATH3012 },
??????? { USB_DEVICE(0x0cf3, 0xe004), .driver_info = BTUSB_ATH3012 },


2012-10-25 01:56:33

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Add support for Atheros [04ca:3004]

Hi Dwaine,

> Add another vendor specific ID for Atheros AR3012 device.
> This chip is wrapped by Lite-On Technology Corp.
>
> output of usb-devices:
>
> Bus 001 Device 008: ID 04ca:3004 Lite-On Technology Corp.
> Device Descriptor:
> bLength 18
> bDescriptorType 1
> bcdUSB 1.10
> bDeviceClass 224 Wireless
> bDeviceSubClass 1 Radio Frequency
> bDeviceProtocol 1 Bluetooth

I want /sys/kernel/debug/usb/devices for this device and nothing else.

> diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> index fc2de55..1486f15 100644
> --- a/drivers/bluetooth/ath3k.c
> +++ b/drivers/bluetooth/ath3k.c
> @@ -75,6 +75,7 @@ static struct usb_device_id ath3k_table[] = {
> { USB_DEVICE(0x0CF3, 0x3004) },
> { USB_DEVICE(0x0CF3, 0x311D) },
> { USB_DEVICE(0x13d3, 0x3375) },
> + { USB_DEVICE(0x04CA, 0x3004) },
> { USB_DEVICE(0x04CA, 0x3005) },

This is still broken.

Regards

Marcel



2012-10-24 16:22:35

by Dwaine Garden VE3GIF

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Add support for Atheros [04ca:3004]

Ok.... Sorry about that.....=A0 I will also do the git e-mail.=A0=A0 Yahoo,=
webmail just=A0mangles the e-mail when I send it.=0A=0A=0A=0A=0A----- Orig=
inal Message -----=0AFrom: Marcel Holtmann <[email protected]>=0ATo: Dwai=
ne Garden VE3GIF <[email protected]>=0ACc: "[email protected]=
el.org" <[email protected]>=0ASent: Wednesday, October 24, 20=
12 11:10:46 AM=0ASubject: Re: [PATCH] Bluetooth: Add support for Atheros [0=
4ca:3004]=0A=0AHi Dwaine,=0A=0A> Add another vendor specific ID for Atheros=
AR3012 device.=0A> This chip is wrapped by Lite-On Technology Corp.=0A> =
=0A> output of usb-devices:T:=A0 Bus=3D01 Lev=3D02 Prnt=3D02 Port=3D03 Cnt=
=3D01 Dev#=3D=A0 3 Spd=3D12=A0 MxCh=3D 0=0A> D:=A0 Ver=3D 1.10 Cls=3De0(wlc=
on) Sub=3D01 Prot=3D01 MxPS=3D64 #Cfgs=3D=A0 1=0A> P:=A0 Vendor=3D04ca Prod=
ID=3D3004 Rev=3D 0.02=0A> S:=A0 Manufacturer=3DAtheros Communications=0A> S=
:=A0 Product=3DBluetooth USB Host Controller=0A> S:=A0 SerialNumber=3DAlask=
a Day 2006=0A=0AI really want to see the endpoints here as well. So do not =
cut of the=0Adetails of this device.=0A=0ARegards=0A=0AMarcel

2012-10-24 15:10:46

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Add support for Atheros [04ca:3004]

Hi Dwaine,

> Add another vendor specific ID for Atheros AR3012 device.
> This chip is wrapped by Lite-On Technology Corp.
>
> output of usb-devices:T: Bus=01 Lev=02 Prnt=02 Port=03 Cnt=01 Dev#= 3 Spd=12 MxCh= 0
> D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=04ca ProdID=3004 Rev= 0.02
> S: Manufacturer=Atheros Communications
> S: Product=Bluetooth USB Host Controller
> S: SerialNumber=Alaska Day 2006

I really want to see the endpoints here as well. So do not cut of the
details of this device.

Regards

Marcel



2012-10-24 11:56:25

by Gustavo Padovan

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Add support for Atheros [04ca:3004]

Hi Dwaine,

* Dwaine Garden VE3GIF <[email protected]> [2012-10-23 21:57:13 -0700]:

> Add another vendor specific ID for Atheros AR3012 device.
> This chip is wrapped by Lite-On Technology Corp.
>
> output of usb-devices:T:? Bus=01 Lev=02 Prnt=02 Port=03 Cnt=01 Dev#=? 3 Spd=12?? MxCh= 0

Break a line before pasting the output in the patch.

> D:? Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=? 1
> P:? Vendor=04ca ProdID=3004 Rev= 0.02
> S:? Manufacturer=Atheros Communications
> S:? Product=Bluetooth USB Host Controller
> S:? SerialNumber=Alaska Day 2006
>
> Signed-off-by: Dwaine Garden <[email protected]> ---
>
> diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> index fc2de55..1486f15 100644
> --- a/drivers/bluetooth/ath3k.c
> +++ b/drivers/bluetooth/ath3k.c
> @@ -75,6 +75,7 @@ static struct usb_device_id ath3k_table[] = {
> { USB_DEVICE(0x0CF3, 0x3004) },
> { USB_DEVICE(0x0CF3, 0x311D) },
> { USB_DEVICE(0x13d3, 0x3375) },
> + { USB_DEVICE(0x04CA, 0x3004) },
> { USB_DEVICE(0x04CA, 0x3005) },
> { USB_DEVICE(0x13d3, 0x3362) },
> { USB_DEVICE(0x0CF3, 0xE004) },
> @@ -102,6 +103,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {
> { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x0cf3, 0x311D), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
> + { USB_DEVICE(0x04ca, 0x3004), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x04ca, 0x3005), .driver_info =
> BTUSB_ATH3012 },
> {
> USB_DEVICE(0x13d3, 0x3362), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x0cf3, 0xe004), .driver_info = BTUSB_ATH3012 },
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index debda27..0529cee 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -132,6 +132,7 @@ static struct usb_device_id blacklist_table[] = {
> { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x0cf3, 0x311d), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
> + { USB_DEVICE(0x04ca, 0x3004), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x04ca, 0x3005), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x13d3, 0x3362), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x0cf3, 0xe004), .driver_info = BTUSB_ATH3012 },

You patch is still broken, please use git-send-email to send it to the mailing
list and also make sure it apply cleanly on the latest bluetooth-next tree
before sending. Thanks.

Gustavo

2012-10-23 16:05:06

by Dwaine Garden VE3GIF

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Add support for Atheros [04ca:3004]

Thanks. =A0I will get the right output and fix the tabbing probleem; resend=
ing the patch again.=0A=0ADwaine=0A=0A=0A=0A----- Original Message -----=0A=
From: Marcel Holtmann <[email protected]>=0ATo: Dwaine Garden VE3GIF <dwa=
[email protected]>=0ACc: "[email protected]" <linux-blueto=
[email protected]>=0ASent: Tuesday, October 23, 2012 10:42:13 AM=0ASubjec=
t: Re: [PATCH] Bluetooth: Add support for Atheros [04ca:3004]=0A=0AHi Dwain=
e,=0A=0A> Add another vendor specific ID for Atheros AR3012 device.=0A> Thi=
s chip is wrapped by Lite-On Technology Corp.=0A> =0A> output of usb-device=
s:=0A> Bus 001 Device 008: ID 04ca:3004 Lite-On Technology Corp. =0A> Devic=
e Descriptor:=0A>=A0 bLength=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 18=0A> =0A> bD=
escriptorType=A0 =A0 =A0 =A0 1=0A>=A0 bcdUSB=A0 =A0 =A0 =A0 =A0 =A0 =A0 =
1.10=0A>=A0 bDeviceClass=A0 =A0 =A0 =A0 =A0 224 Wireless=0A>=A0 bDeviceSu=
bClass=A0 =A0 =A0 =A0 1 Radio Frequency=0A>=A0 bDeviceProtocol=A0 =A0 =A0=
=A0 1 Bluetooth=0A>=A0 bMaxPacketSize0=A0 =A0 =A0 =A0 64=0A>=A0 idVendo=
r=A0 =A0 =A0 =A0 =A0 0x04ca Lite-On Technology Corp.=0A>=A0 idProduct=A0 =
=A0 =A0 =A0 =A0 0x3004 =0A>=A0 bcdDevice=A0 =A0 =A0 =A0 =A0 =A0 0.02=0A>=
=A0 iManufacturer=A0 =A0 =A0 =A0 =A0 1 Atheros Communications=0A> =0A> iP=
roduct=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 2 Bluetooth USB Host Controller=0A>=
=A0 iSerial=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 3 Alaska Day 2006=0A>=A0 bNum=
Configurations=A0 =A0 =A0 1=0A=0AI prefer /sys/kernel/debug/usb/devices out=
put here.=0A=0A> =0A> =0A> Signed-off-by: Dwaine Garden <DwaineGarden@roger=
s.com>=A0 ---=0A> =0A> diff --git a/drivers/bluetooth/ath3k.c b/drivers/blu=
etooth/ath3k.c=0A> index fc2de55..1486f15 100644=0A> --- a/drivers/bluetoot=
h/ath3k.c=0A> +++ b/drivers/bluetooth/ath3k.c=0A> @@ -75,6 +75,7 @@ static =
struct usb_device_id ath3k_table[] =3D {=0A> { USB_DEVICE(0x0CF3, 0x3004) }=
,=0A> { USB_DEVICE(0x0CF3, 0x311D) },=0A> { USB_DEVICE(0x13d3, 0x3375) },=
=0A> +=A0 =A0 { USB_DEVICE(0x04CA, 0x3004) },=0A=0AAnd you need to use an e=
mail client that does not mess up the tabs vs=0Awhite spaces.=0A=0ARegards=
=0A=0AMarcel

2012-10-23 14:42:13

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Add support for Atheros [04ca:3004]

Hi Dwaine,

> Add another vendor specific ID for Atheros AR3012 device.
> This chip is wrapped by Lite-On Technology Corp.
>
> output of usb-devices:
> Bus 001 Device 008: ID 04ca:3004 Lite-On Technology Corp.
> Device Descriptor:
> bLength 18
>
> bDescriptorType 1
> bcdUSB 1.10
> bDeviceClass 224 Wireless
> bDeviceSubClass 1 Radio Frequency
> bDeviceProtocol 1 Bluetooth
> bMaxPacketSize0 64
> idVendor 0x04ca Lite-On Technology Corp.
> idProduct 0x3004
> bcdDevice 0.02
> iManufacturer 1 Atheros Communications
>
> iProduct 2 Bluetooth USB Host Controller
> iSerial 3 Alaska Day 2006
> bNumConfigurations 1

I prefer /sys/kernel/debug/usb/devices output here.

>
>
> Signed-off-by: Dwaine Garden <[email protected]> ---
>
> diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> index fc2de55..1486f15 100644
> --- a/drivers/bluetooth/ath3k.c
> +++ b/drivers/bluetooth/ath3k.c
> @@ -75,6 +75,7 @@ static struct usb_device_id ath3k_table[] = {
> { USB_DEVICE(0x0CF3, 0x3004) },
> { USB_DEVICE(0x0CF3, 0x311D) },
> { USB_DEVICE(0x13d3, 0x3375) },
> + { USB_DEVICE(0x04CA, 0x3004) },

And you need to use an email client that does not mess up the tabs vs
white spaces.

Regards

Marcel



2012-10-22 05:26:27

by Julian Calaby

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Add support for Atheros [04ca:3004]

Hi Dwaine,

Firstly, you should really send this to the linux-bluetooth list and
Gustavo not to linux-wireless and John.

While linux-wireless is the catch-all place for everything relating to
wireless technology in Linux, bluetooth has it's own mailing list, and
bluetooth patches should be sent there first.

On Mon, Oct 22, 2012 at 4:02 PM, Dwaine Garden VE3GIF
<[email protected]> wrote:
>
>
> Add another vendor specific ID for Atheros AR3012 device.
> This chip is wrapped by Lite-On Technology Corp.
>
> output of usb-devices:
> Bus 001 Device 008: ID 04ca:3004 Lite-On Technology Corp.
> Device Descriptor:
> bLength 18
>
> bDescriptorType 1
> bcdUSB 1.10
> bDeviceClass 224 Wireless
> bDeviceSubClass 1 Radio Frequency
> bDeviceProtocol 1 Bluetooth
> bMaxPacketSize0 64
> idVendor 0x04ca Lite-On Technology Corp.
> idProduct 0x3004
> bcdDevice 0.02
> iManufacturer 1 Atheros Communications
>
> iProduct 2 Bluetooth USB Host Controller
> iSerial 3 Alaska Day 2006
> bNumConfigurations 1
>
>
> Signed-off-by: Dwaine Garden <[email protected]> ---

Secondly, while your patch looks correct to me (I'm no expert on the
hardware or drivers involved) it seems to be severely whitespace
damaged. You should read the Email Clients document under the
Documentation directory in your kernel tree (or read it online here:
http://stuff.mit.edu/afs/sipb/contrib/linux/Documentation/email-clients.txt
) and ensure that your email client is set up correctly to send
patches without damaging them.

> diff --git a/drivers/bluetooth/ath3k.c b/drivers/bluetooth/ath3k.c
> index fc2de55..1486f15 100644
> --- a/drivers/bluetooth/ath3k.c
> +++ b/drivers/bluetooth/ath3k.c
> @@ -75,6 +75,7 @@ static struct usb_device_id ath3k_table[] = {
> { USB_DEVICE(0x0CF3, 0x3004) },
> { USB_DEVICE(0x0CF3, 0x311D) },
> { USB_DEVICE(0x13d3, 0x3375) },
> + { USB_DEVICE(0x04CA, 0x3004) },
> { USB_DEVICE(0x04CA, 0x3005) },
> { USB_DEVICE(0x13d3, 0x3362) },
> { USB_DEVICE(0x0CF3, 0xE004) },
> @@ -102,6 +103,7 @@ static struct usb_device_id ath3k_blist_tbl[] = {
> { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x0cf3, 0x311D), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
> + { USB_DEVICE(0x04ca, 0x3004), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x04ca, 0x3005), .driver_info = BTUSB_ATH3012 },
> {
> USB_DEVICE(0x13d3, 0x3362), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x0cf3, 0xe004), .driver_info = BTUSB_ATH3012 },
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index debda27..0529cee 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -132,6 +132,7 @@ static struct usb_device_id blacklist_table[] = {
> { USB_DEVICE(0x0cf3, 0x3004), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x0cf3, 0x311d), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x13d3, 0x3375), .driver_info = BTUSB_ATH3012 },
> + { USB_DEVICE(0x04ca, 0x3004), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x04ca, 0x3005), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x13d3, 0x3362), .driver_info = BTUSB_ATH3012 },
> { USB_DEVICE(0x0cf3, 0xe004), .driver_info = BTUSB_ATH3012 },

Thanks,

--
Julian Calaby

Email: [email protected]
Profile: http://www.google.com/profiles/julian.calaby/
.Plan: http://sites.google.com/site/juliancalaby/