2012-12-10 20:24:12

by Vinicius Costa Gomes

Subject: [PATCH BlueZ v2] build: Fix 'hcitool' and 'bdaddr' compilation

Now with the addition of src/oui.c that depends on udev, these tools
should also be linked against libudev, in case libudev includes the
function udev_hwdb_new().

Build error:
CCLD tools/hcitool
CCLD tools/sdptool
CCLD tools/ciptool
CCLD tools/bccmd
src/oui.o: In function `batocomp':
/home/vinicius/work/bluez/src/oui.c:42: undefined reference to `udev_new'
/home/vinicius/work/bluez/src/oui.c:46: undefined reference to `udev_hwdb_new'
/home/vinicius/work/bluez/src/oui.c:50: undefined reference to `udev_hwdb_get_properties_list_entry'
/home/vinicius/work/bluez/src/oui.c:53: undefined reference to `udev_list_entry_get_name'
/home/vinicius/work/bluez/src/oui.c:52: undefined reference to `udev_list_entry_get_next'
/home/vinicius/work/bluez/src/oui.c:61: undefined reference to `udev_hwdb_unref'
/home/vinicius/work/bluez/src/oui.c:64: undefined reference to `udev_unref'
/home/vinicius/work/bluez/src/oui.c:56: undefined reference to `udev_list_entry_get_value'
collect2: error: ld returned 1 exit status
make[1]: *** [tools/hcitool] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [all] Error 2
---
Makefile.tools | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.tools b/Makefile.tools
index 36b43dc..d6532b8 100644
--- a/Makefile.tools
+++ b/Makefile.tools
@@ -32,7 +32,7 @@ tools_hciconfig_SOURCES = tools/hciconfig.c tools/csr.h tools/csr.c
tools_hciconfig_LDADD = lib/libbluetooth-private.la

tools_hcitool_SOURCES = tools/hcitool.c src/oui.h src/oui.c
-tools_hcitool_LDADD = lib/libbluetooth-private.la @GLIB_LIBS@
+tools_hcitool_LDADD = lib/libbluetooth-private.la @GLIB_LIBS@ @UDEV_LIBS@

tools_sdptool_SOURCES = tools/sdptool.c src/sdp-xml.h src/sdp-xml.c
tools_sdptool_LDADD = lib/libbluetooth-private.la @GLIB_LIBS@
@@ -107,7 +107,7 @@ tools_bccmd_LDADD += @USB_LIBS@
endif

tools_bdaddr_SOURCES = tools/bdaddr.c src/oui.h src/oui.c
-tools_bdaddr_LDADD = lib/libbluetooth-private.la
+tools_bdaddr_LDADD = lib/libbluetooth-private.la @UDEV_LIBS@

dist_man_MANS += tools/rfcomm.1 tools/l2ping.1 tools/rctest.1 \
tools/hciattach.1 tools/hciconfig.1 \
--
1.8.0.1

2012-12-10 20:39:55

by Johan Hedberg

Subject: Re: [PATCH BlueZ v2] build: Fix 'hcitool' and 'bdaddr' compilation

Hi Vinicius,

On Mon, Dec 10, 2012, Vinicius Costa Gomes wrote:
> Now with the addition of src/oui.c that depends on udev, these tools
> should also be linked against libudev, in case libudev includes the
> function udev_hwdb_new().
>
> Build error:
> CCLD tools/hcitool
> CCLD tools/sdptool
> CCLD tools/ciptool
> CCLD tools/bccmd
> src/oui.o: In function `batocomp':
> /home/vinicius/work/bluez/src/oui.c:42: undefined reference to `udev_new'
> /home/vinicius/work/bluez/src/oui.c:46: undefined reference to `udev_hwdb_new'
> /home/vinicius/work/bluez/src/oui.c:50: undefined reference to `udev_hwdb_get_properties_list_entry'
> /home/vinicius/work/bluez/src/oui.c:53: undefined reference to `udev_list_entry_get_name'
> /home/vinicius/work/bluez/src/oui.c:52: undefined reference to `udev_list_entry_get_next'
> /home/vinicius/work/bluez/src/oui.c:61: undefined reference to `udev_hwdb_unref'
> /home/vinicius/work/bluez/src/oui.c:64: undefined reference to `udev_unref'
> /home/vinicius/work/bluez/src/oui.c:56: undefined reference to `udev_list_entry_get_value'
> collect2: error: ld returned 1 exit status
> make[1]: *** [tools/hcitool] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [all] Error 2
> ---
> Makefile.tools | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied. Thanks.

Johan