2013-07-29 16:12:05

by Hector Palacios

[permalink] [raw]
Subject: [PATCH] bluetooth: remove wrong dependency for BT_ATH3K

The Atheros firmware download driver is not dependent on HCI
USB driver. This driver is needed to complement any Atheros
driver like BT_HCIUART_ATH3K.

Signed-off-by: Hector Palacios <[email protected]>
CC: Suraj Sumangala <[email protected]>
CC: Vikram Kandukuri <[email protected]>
---
drivers/bluetooth/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 11a6104..a1d482b 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -222,7 +222,6 @@ config BT_MRVL_SDIO

config BT_ATH3K
tristate "Atheros firmware download driver"
- depends on BT_HCIBTUSB
select FW_LOADER
help
Bluetooth firmware download driver.


2013-07-30 20:56:01

by Luis R. Rodriguez

[permalink] [raw]
Subject: Re: [PATCH] bluetooth: remove wrong dependency for BT_ATH3K

On Tue, Jul 30, 2013 at 09:58:38AM +0200, Hector Palacios wrote:
> This brings an interesting question: shouldn't the firmware download
> part be isolated from the USB driver? After all, I want to
> communicate with a UART bluetooth chip.

There are a few BT firmware upload modules (last I checked at least 2),
I believe it should be possible to stuff all that code a shared
module or even as FreeBSD does it -- treat fw uploading in userspace,
however just keep in mind for quirks [0]. So patches welcomed.

[0] http://wireless.kernel.org/en/users/Drivers/ath3k#AR3011_over_USB

Luis

2013-07-30 07:58:38

by Hector Palacios

[permalink] [raw]
Subject: Re: [PATCH] bluetooth: remove wrong dependency for BT_ATH3K

Hi Marcel,

On 07/29/2013 06:43 PM, Marcel Holtmann wrote:
> Hi Hector,
>
>> The Atheros firmware download driver is not dependent on HCI
>> USB driver. This driver is needed to complement any Atheros
>> driver like BT_HCIUART_ATH3K.
>>
>> Signed-off-by: Hector Palacios <[email protected]>
>> CC: Suraj Sumangala <[email protected]>
>> CC: Vikram Kandukuri <[email protected]>
>> ---
>> drivers/bluetooth/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
>> index 11a6104..a1d482b 100644
>> --- a/drivers/bluetooth/Kconfig
>> +++ b/drivers/bluetooth/Kconfig
>> @@ -222,7 +222,6 @@ config BT_MRVL_SDIO
>>
>> config BT_ATH3K
>> tristate "Atheros firmware download driver"
>> - depends on BT_HCIBTUSB
>> select FW_LOADER
>> help
>> Bluetooth firmware download driver.
>>
>
> I am confused now. How can an USB driver work with an UART driver? If you do not want to depend on BT_HCIBTUSB then that is fine, but at least you need to depend on USB.

The thing is I have an Atheros AR6233 chipset which has wireless and Bluetooth.
Bluetooth part in this chip operates as a UART. The driver for this is hci_ath.c but I
also need to download the firmware to the chip, and for this I need to compile
ath3k.c. However I don't need BT_HCIBTUSB.
But you are right, looking at the source code of ath3k.c it is calling usb commands,
so it needs to depend on USB at least.

This brings an interesting question: shouldn't the firmware download part be isolated
from the USB driver? After all, I want to communicate with a UART bluetooth chip.

Best regards,
--
Hector Palacios

2013-07-29 16:43:53

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] bluetooth: remove wrong dependency for BT_ATH3K

Hi Hector,

> The Atheros firmware download driver is not dependent on HCI
> USB driver. This driver is needed to complement any Atheros
> driver like BT_HCIUART_ATH3K.
>
> Signed-off-by: Hector Palacios <[email protected]>
> CC: Suraj Sumangala <[email protected]>
> CC: Vikram Kandukuri <[email protected]>
> ---
> drivers/bluetooth/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 11a6104..a1d482b 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -222,7 +222,6 @@ config BT_MRVL_SDIO
>
> config BT_ATH3K
> tristate "Atheros firmware download driver"
> - depends on BT_HCIBTUSB
> select FW_LOADER
> help
> Bluetooth firmware download driver.
>

I am confused now. How can an USB driver work with an UART driver? If you do not want to depend on BT_HCIBTUSB then that is fine, but at least you need to depend on USB.

Regards

Marcel