2013-10-31 10:56:26

by Jerzy Kasenberg

Subject: [PATCH] android/client: Fix crash in get_profile_interface

This fixes crash due to uncheck input from user.
---
android/client/if-bt.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/android/client/if-bt.c b/android/client/if-bt.c
index a3d6286..9e01d65 100644
--- a/android/client/if-bt.c
+++ b/android/client/if-bt.c
@@ -804,11 +804,16 @@ static void get_profile_interface_c(int argc, const char **argv,

static void get_profile_interface_p(int argc, const char **argv)
{
- const char *id = argv[2];
+ const char *id;
const void **pif = NULL;
const void *dummy = NULL;

RETURN_IF_NULL(if_bluetooth);
+ if (argc <= 2) {
+ haltest_error("No interface specified\n");
+ return;
+ }
+ id = argv[2];

if (strcmp(BT_PROFILE_HANDSFREE_ID, id) == 0)
pif = (const void **) &if_hf;
--
1.7.9.5

2013-10-31 11:52:47

by Johan Hedberg

Subject: Re: [PATCH] android/client: Fix crash in get_profile_interface

Hi Jerzy,

On Thu, Oct 31, 2013, Jerzy Kasenberg wrote:
> This fixes crash due to uncheck input from user.
> ---
> android/client/if-bt.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)

Applied (after minor coding style fix to add an empty line after }).
Thanks.

Johan