2013-11-04 09:55:40

by Jerzy Kasenberg

[permalink] [raw]
Subject: [PATCH] android/client: Fix uninitialized variable

Pin accept variable was intended to be set to 1
only when pin was typed by user. If no pin was given
accept should be set to 0. This patch fixes this.
---
android/client/if-bt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/client/if-bt.c b/android/client/if-bt.c
index 43e8788..fb1b3f3 100644
--- a/android/client/if-bt.c
+++ b/android/client/if-bt.c
@@ -605,7 +605,7 @@ static void pin_reply_p(int argc, const char **argv)
bt_bdaddr_t addr;
bt_pin_code_t pin;
int pin_len = 0;
- int accept;
+ int accept = 0;

RETURN_IF_NULL(if_bluetooth);
VERIFY_ADDR_ARG(2, &addr);
--
1.7.9.5



2013-11-04 10:14:40

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] android/client: Fix uninitialized variable

Hi Jerzy,

On Mon, Nov 04, 2013, Jerzy Kasenberg wrote:
> Pin accept variable was intended to be set to 1
> only when pin was typed by user. If no pin was given
> accept should be set to 0. This patch fixes this.
> ---
> android/client/if-bt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied. Thanks.

Johan