2014-01-09 16:11:02

by Andrei Emeltchenko

Subject: [PATCH 1/3] hcidump: Fix missing break

From: Andrei Emeltchenko <[email protected]>

---
tools/parser/avrcp.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/tools/parser/avrcp.c b/tools/parser/avrcp.c
index b523533..7c320ea 100644
--- a/tools/parser/avrcp.c
+++ b/tools/parser/avrcp.c
@@ -1180,12 +1180,16 @@ response:
switch (status) {
case 0x00:
printf("(POWER_ON)\n");
+ break;
case 0x01:
printf("(POWER_OFF)\n");
+ break;
case 0x02:
printf("(UNPLUGGED)\n");
+ break;
default:
printf("(UNKOWN)\n");
+ break;
}
break;
case AVRCP_EVENT_PLAYER_APPLICATION_SETTING_CHANGED:
--
1.8.3.2

2014-01-09 16:23:35

by Johan Hedberg

Subject: Re: [PATCH 1/3] hcidump: Fix missing break

Hi Andrei,

On Thu, Jan 09, 2014, Andrei Emeltchenko wrote:
> ---
> tools/parser/avrcp.c | 4 ++++
> 1 file changed, 4 insertions(+)

All three patches have been applied. Thanks.

Johan

2014-01-09 16:11:04

by Andrei Emeltchenko

Subject: [PATCH 3/3] sdp: Fix incorrect sizeof argument

From: Andrei Emeltchenko <[email protected]>

length is a pointer to int table not int* table.
---
lib/sdp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/sdp.c b/lib/sdp.c
index cbdf15e..886e7cf 100644
--- a/lib/sdp.c
+++ b/lib/sdp.c
@@ -4773,7 +4773,7 @@ int sdp_set_supp_feat(sdp_record_t *rec, const sdp_list_t *sf)
free(dtds);
goto fail;
}
- lengths = malloc(plen * sizeof(int *));
+ lengths = malloc(plen * sizeof(int));
if (!lengths) {
free(dtds);
free(vals);
--
1.8.3.2

2014-01-09 16:11:03

by Andrei Emeltchenko

Subject: [PATCH 2/3] l2test: Fix using incorrect size of option

From: Andrei Emeltchenko <[email protected]>

Use size of option instead of size of pointer
---
tools/l2test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/l2test.c b/tools/l2test.c
index 9a7c809..aaa1608 100644
--- a/tools/l2test.c
+++ b/tools/l2test.c
@@ -287,7 +287,7 @@ static int setopts(int sk, struct l2cap_options *opts)
{
if (bdaddr_type == BDADDR_BREDR || cid)
return setsockopt(sk, SOL_L2CAP, L2CAP_OPTIONS, opts,
- sizeof(opts));
+ sizeof(*opts));

return setsockopt(sk, SOL_BLUETOOTH, BT_RCVMTU, &opts->imtu,
sizeof(opts->imtu));
--
1.8.3.2