2014-02-05 10:50:59

by Andrei Emeltchenko

Subject: [PATCH] android/handsfree: Fix memory leak

From: Andrei Emeltchenko <[email protected]>

Free classes if sdp_get_access_protos fails.
---
android/handsfree.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/android/handsfree.c b/android/handsfree.c
index edf3d27..9482b2e 100644
--- a/android/handsfree.c
+++ b/android/handsfree.c
@@ -229,6 +229,7 @@ static void sdp_search_cb(sdp_list_t *recs, int err, gpointer data)

if (sdp_get_access_protos(recs->data, &protos) < 0) {
error("handsfree: unable to get access protocols from record");
+ sdp_list_free(classes, free);
goto fail;
}

--
1.8.3.2

2014-02-05 13:45:04

by Szymon Janc

Subject: Re: [PATCH] android/handsfree: Fix memory leak

Hi Andrei,

On Wednesday 05 of February 2014 12:50:59 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> Free classes if sdp_get_access_protos fails.
> ---
> android/handsfree.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/android/handsfree.c b/android/handsfree.c
> index edf3d27..9482b2e 100644
> --- a/android/handsfree.c
> +++ b/android/handsfree.c
> @@ -229,6 +229,7 @@ static void sdp_search_cb(sdp_list_t *recs, int err, gpointer data)
>
> if (sdp_get_access_protos(recs->data, &protos) < 0) {
> error("handsfree: unable to get access protocols from record");
> + sdp_list_free(classes, free);
> goto fail;
> }
>

Applied, thanks.

--
Best regards,
Szymon Janc