2014-02-07 22:27:58

by Andre Guedes

Subject: [PATCH] health: Fix HealthDevice dbus registration

For some reason, HealthDevice property table wasn't been registered.
---
profiles/health/hdp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/profiles/health/hdp.c b/profiles/health/hdp.c
index 622d95b..48dad52 100644
--- a/profiles/health/hdp.c
+++ b/profiles/health/hdp.c
@@ -2145,7 +2145,8 @@ static struct hdp_device *create_health_device(struct btd_device *device)
if (!g_dbus_register_interface(btd_get_dbus_connection(),
path, HEALTH_DEVICE,
health_device_methods,
- health_device_signals, NULL,
+ health_device_signals,
+ health_device_properties,
dev, health_device_destroy)) {
error("D-Bus failed to register %s interface", HEALTH_DEVICE);
goto fail;
--
1.8.5.3

2014-02-17 12:02:35

by Luiz Augusto von Dentz

Subject: Re: [PATCH] btsnoop: Remove unused local function and macro

Hi Andre,

On Sat, Feb 8, 2014 at 12:27 AM, Andre Guedes
<[email protected]> wrote:
> ---
> tools/btsnoop.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/tools/btsnoop.c b/tools/btsnoop.c
> index a65d8c5..260dfdb 100644
> --- a/tools/btsnoop.c
> +++ b/tools/btsnoop.c
> @@ -40,19 +40,6 @@
>
> #include "monitor/btsnoop.h"
>
> -static inline uint64_t ntoh64(uint64_t n)
> -{
> - uint64_t h;
> - uint64_t tmp = ntohl(n & 0x00000000ffffffff);
> -
> - h = ntohl(n >> 32);
> - h |= tmp << 32;
> -
> - return h;
> -}
> -
> -#define hton64(x) ntoh64(x)
> -
> struct btsnoop_hdr {
> uint8_t id[8]; /* Identification Pattern */
> uint32_t version; /* Version Number = 1 */
> --
> 1.8.5.3

Applied, thanks.


--
Luiz Augusto von Dentz

2014-02-17 12:01:38

by Luiz Augusto von Dentz

Subject: Re: [PATCH] health: Fix HealthDevice dbus registration

Hi Andre,

On Sat, Feb 8, 2014 at 12:27 AM, Andre Guedes
<[email protected]> wrote:
> For some reason, HealthDevice property table wasn't been registered.
> ---
> profiles/health/hdp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/profiles/health/hdp.c b/profiles/health/hdp.c
> index 622d95b..48dad52 100644
> --- a/profiles/health/hdp.c
> +++ b/profiles/health/hdp.c
> @@ -2145,7 +2145,8 @@ static struct hdp_device *create_health_device(struct btd_device *device)
> if (!g_dbus_register_interface(btd_get_dbus_connection(),
> path, HEALTH_DEVICE,
> health_device_methods,
> - health_device_signals, NULL,
> + health_device_signals,
> + health_device_properties,
> dev, health_device_destroy)) {
> error("D-Bus failed to register %s interface", HEALTH_DEVICE);
> goto fail;
> --
> 1.8.5.3

Applied, thanks.


--
Luiz Augusto von Dentz

2014-02-07 22:28:00

by Andre Guedes

Subject: [PATCH] gitignore: Add cscope files

---
.gitignore | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/.gitignore b/.gitignore
index b86deae..fe6636e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -121,3 +121,7 @@ android/android-tester
android/ipc-tester
android/bluetoothd-snoop
android/test-ipc
+
+cscope.in.out
+cscope.out
+cscope.po.out
--
1.8.5.3

2014-02-07 22:27:59

by Andre Guedes

Subject: [PATCH] btsnoop: Remove unused local function and macro

---
tools/btsnoop.c | 13 -------------
1 file changed, 13 deletions(-)

diff --git a/tools/btsnoop.c b/tools/btsnoop.c
index a65d8c5..260dfdb 100644
--- a/tools/btsnoop.c
+++ b/tools/btsnoop.c
@@ -40,19 +40,6 @@

#include "monitor/btsnoop.h"

-static inline uint64_t ntoh64(uint64_t n)
-{
- uint64_t h;
- uint64_t tmp = ntohl(n & 0x00000000ffffffff);
-
- h = ntohl(n >> 32);
- h |= tmp << 32;
-
- return h;
-}
-
-#define hton64(x) ntoh64(x)
-
struct btsnoop_hdr {
uint8_t id[8]; /* Identification Pattern */
uint32_t version; /* Version Number = 1 */
--
1.8.5.3

2014-06-05 19:21:43

by Johan Hedberg

Subject: Re: [PATCH] gitignore: Add cscope files

Hi Andre,

On Fri, Feb 07, 2014, Andre Guedes wrote:
> ---
> .gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index b86deae..fe6636e 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -121,3 +121,7 @@ android/android-tester
> android/ipc-tester
> android/bluetoothd-snoop
> android/test-ipc
> +
> +cscope.in.out
> +cscope.out
> +cscope.po.out

Applied. Thanks.

Johan