2014-02-09 08:53:07

by Pacho Ramos

[permalink] [raw]
Subject: Some patches applied on Fedora that maybe should be considered for being applied upstream

Hello

I was looking at bluez package and found some patches that maybe could
be upstreamed. Also, I would like to know the reasons for not accepting
them to ensure they are safe to be applied downstream by us too :)

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch -> Does this cause any issues with systemd --user setups?


http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-obex-Use-GLib-helper-function-to-manipulate-paths.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0002-autopair-Don-t-handle-the-iCade.patch
http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0004-agent-Assert-possible-infinite-loop.patch
-> Any reason for not applying it upstream too?

http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-work-around-Logitech-diNovo-Edge-keyboard-firmware-i.patch
-> Taking care this looks to be a really old issue, maybe using the
workaround would be the only option for now :/

Thanks a lot for your thoughts :)



2014-02-16 19:06:03

by Pacho Ramos

[permalink] [raw]
Subject: Re: Some patches applied on Fedora that maybe should be considered for being applied upstream

El mar, 11-02-2014 a las 14:27 +0100, Bastien Nocera escribió:
> On Mon, 2014-02-10 at 21:01 +0100, Pacho Ramos wrote:
> > El lun, 10-02-2014 a las 14:40 +0100, Bastien Nocera escribió:
> > > On Sun, 2014-02-09 at 09:53 +0100, Pacho Ramos wrote:
> > > > Hello
> > > >
> > > > I was looking at bluez package and found some patches that maybe could
> > > > be upstreamed. Also, I would like to know the reasons for not accepting
> > > > them to ensure they are safe to be applied downstream by us too :)
> > > >
> > > > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch -> Does this cause any issues with systemd --user setups?
> > >
> > > Giovanni already posted this patch earlier. There's no distribution
> > > using systemd sessions, so this doesn't work yet.
> > >
> > > > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-obex-Use-GLib-helper-function-to-manipulate-paths.patch
> > > > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0002-autopair-Don-t-handle-the-iCade.patch
> > > > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0004-agent-Assert-possible-infinite-loop.patch
> > > > -> Any reason for not applying it upstream too?
> > >
> > > I've posted those patches to the list as well.
> >
> > And, do you know why they weren't accepted? (it's for trying to get them
> > merged and not needing to carry them forever)
>
> Read the threads for the various patches?
>
> Mailing-lists, awful at tracking patches since forever...
>

But, for example for the patch allowing to run without systemd --user:
http://marc.info/?t=138159296100001&r=1&w=2

What is the point in providing a "--disable-systemd" configure flag that
needs this patches to be applied to be really working? Looks like
"--enable-systemd" will be needed if we don't apply that patches
downstream...


Also:
http://www.spinics.net/lists/linux-bluetooth/msg40136.html
http://www.spinics.net/lists/linux-bluetooth/msg41264.html

Look to have no reply at all

And for 0004-agent-Assert-possible-infinite-loop.patch I can't find the
relevant thread :(



2014-02-16 18:58:30

by Pacho Ramos

[permalink] [raw]
Subject: Re: Some patches applied on Fedora that maybe should be considered for being applied upstream

El lun, 10-02-2014 a las 21:01 +0100, Pacho Ramos escribió:
> [...]
> > > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-work-around-Logitech-diNovo-Edge-keyboard-firmware-i.patch
> > > -> Taking care this looks to be a really old issue, maybe using the
> > > workaround would be the only option for now :/
> >
> > I have no hardware to test this on, I snatched it from Ubuntu's bluez 4
> > package.
> >
> > Cheers
>
> OK, thanks :)
>

Looks to be still needed:
https://bugs.gentoo.org/show_bug.cgi?id=501120


2014-02-11 13:27:57

by Bastien Nocera

[permalink] [raw]
Subject: Re: Some patches applied on Fedora that maybe should be considered for being applied upstream

On Mon, 2014-02-10 at 21:01 +0100, Pacho Ramos wrote:
> El lun, 10-02-2014 a las 14:40 +0100, Bastien Nocera escribió:
> > On Sun, 2014-02-09 at 09:53 +0100, Pacho Ramos wrote:
> > > Hello
> > >
> > > I was looking at bluez package and found some patches that maybe could
> > > be upstreamed. Also, I would like to know the reasons for not accepting
> > > them to ensure they are safe to be applied downstream by us too :)
> > >
> > > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch -> Does this cause any issues with systemd --user setups?
> >
> > Giovanni already posted this patch earlier. There's no distribution
> > using systemd sessions, so this doesn't work yet.
> >
> > > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-obex-Use-GLib-helper-function-to-manipulate-paths.patch
> > > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0002-autopair-Don-t-handle-the-iCade.patch
> > > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0004-agent-Assert-possible-infinite-loop.patch
> > > -> Any reason for not applying it upstream too?
> >
> > I've posted those patches to the list as well.
>
> And, do you know why they weren't accepted? (it's for trying to get them
> merged and not needing to carry them forever)

Read the threads for the various patches?

Mailing-lists, awful at tracking patches since forever...


2014-02-10 20:01:49

by Pacho Ramos

[permalink] [raw]
Subject: Re: Some patches applied on Fedora that maybe should be considered for being applied upstream

El lun, 10-02-2014 a las 14:40 +0100, Bastien Nocera escribió:
> On Sun, 2014-02-09 at 09:53 +0100, Pacho Ramos wrote:
> > Hello
> >
> > I was looking at bluez package and found some patches that maybe could
> > be upstreamed. Also, I would like to know the reasons for not accepting
> > them to ensure they are safe to be applied downstream by us too :)
> >
> > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch -> Does this cause any issues with systemd --user setups?
>
> Giovanni already posted this patch earlier. There's no distribution
> using systemd sessions, so this doesn't work yet.
>
> > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-obex-Use-GLib-helper-function-to-manipulate-paths.patch
> > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0002-autopair-Don-t-handle-the-iCade.patch
> > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0004-agent-Assert-possible-infinite-loop.patch
> > -> Any reason for not applying it upstream too?
>
> I've posted those patches to the list as well.

And, do you know why they weren't accepted? (it's for trying to get them
merged and not needing to carry them forever)


>
> > http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-work-around-Logitech-diNovo-Edge-keyboard-firmware-i.patch
> > -> Taking care this looks to be a really old issue, maybe using the
> > workaround would be the only option for now :/
>
> I have no hardware to test this on, I snatched it from Ubuntu's bluez 4
> package.
>
> Cheers

OK, thanks :)


2014-02-10 13:40:09

by Bastien Nocera

[permalink] [raw]
Subject: Re: Some patches applied on Fedora that maybe should be considered for being applied upstream

On Sun, 2014-02-09 at 09:53 +0100, Pacho Ramos wrote:
> Hello
>
> I was looking at bluez package and found some patches that maybe could
> be upstreamed. Also, I would like to know the reasons for not accepting
> them to ensure they are safe to be applied downstream by us too :)
>
> http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-Allow-using-obexd-without-systemd-in-the-user-sessio.patch -> Does this cause any issues with systemd --user setups?

Giovanni already posted this patch earlier. There's no distribution
using systemd sessions, so this doesn't work yet.

> http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-obex-Use-GLib-helper-function-to-manipulate-paths.patch
> http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0002-autopair-Don-t-handle-the-iCade.patch
> http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0004-agent-Assert-possible-infinite-loop.patch
> -> Any reason for not applying it upstream too?

I've posted those patches to the list as well.

> http://pkgs.fedoraproject.org/cgit/bluez.git/tree/0001-work-around-Logitech-diNovo-Edge-keyboard-firmware-i.patch
> -> Taking care this looks to be a really old issue, maybe using the
> workaround would be the only option for now :/

I have no hardware to test this on, I snatched it from Ubuntu's bluez 4
package.

Cheers