2014-02-25 10:09:27

by Andrei Emeltchenko

Subject: [PATCH 1/4] unit/avrcp: Add /TP/PTT/BV-02-I test

From: Andrei Emeltchenko <[email protected]>

Test verifies that the Target reacts to the PASS THROUGH command in
category 2 from the Controller. The command chosen is VOLUME_UP.
---
unit/test-avrcp.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/unit/test-avrcp.c b/unit/test-avrcp.c
index 9bd27da..7308443 100644
--- a/unit/test-avrcp.c
+++ b/unit/test-avrcp.c
@@ -251,11 +251,21 @@ static void execute_context(struct context *context)

static bool handle_play(struct avrcp *session)
{
+ DBG("");
+
+ return true;
+}
+
+static bool handle_volume_up(struct avrcp *session)
+{
+ DBG("");
+
return true;
}

static const struct avrcp_passthrough_handler passthrough_handlers[] = {
{ AVC_PLAY, handle_play },
+ { AVC_VOLUME_UP, handle_volume_up },
{ },
};

@@ -310,5 +320,11 @@ int main(int argc, char *argv[])
raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
0x44, 0x00));

+ define_test("/TP/PTT/BV-02-I", test_server,
+ raw_pdu(0x00, 0x11, 0x0e, 0x00, 0x48, 0x7c,
+ AVC_VOLUME_UP, 0x00),
+ raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
+ AVC_VOLUME_UP, 0x00));
+
return g_test_run();
}
--
1.8.3.2

2014-02-26 08:26:08

by Luiz Augusto von Dentz

Subject: Re: [PATCH 4/4] unit/avrcp: Add /TP/PTT/BV-05-I test

Hi Andrei,

On Tue, Feb 25, 2014 at 12:09 PM, Andrei Emeltchenko
<[email protected]> wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> Test verifies that the Target reacts to the PASS THROUGH command in
> category 1 from the Controller. The command chosen is PLAY (0x44).
> The PLAY button is being pressed and released.
> ---
> unit/test-avrcp.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/unit/test-avrcp.c b/unit/test-avrcp.c
> index 66f0973..53e9237 100644
> --- a/unit/test-avrcp.c
> +++ b/unit/test-avrcp.c
> @@ -354,5 +354,15 @@ int main(int argc, char *argv[])
> raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
> AVC_SELECT, 0x00));
>
> + define_test("/TP/PTT/BV-05-I", test_server,
> + raw_pdu(0x00, 0x11, 0x0e, 0x00, 0x48, 0x7c,
> + AVC_PLAY, 0x00),
> + raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
> + AVC_PLAY, 0x00),
> + raw_pdu(0x00, 0x11, 0x0e, 0x00, 0x48, 0x7c,
> + AVC_PLAY | 0x80, 0x00),
> + raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
> + AVC_PLAY | 0x80, 0x00));
> +
> return g_test_run();
> }
> --
> 1.8.3.2

Applied, thanks.


--
Luiz Augusto von Dentz

2014-02-25 11:21:03

by Luiz Augusto von Dentz

Subject: Re: [PATCH 1/4] unit/avrcp: Add /TP/PTT/BV-02-I test

Hi Andrei,

On Tue, Feb 25, 2014 at 12:09 PM, Andrei Emeltchenko
<[email protected]> wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> Test verifies that the Target reacts to the PASS THROUGH command in
> category 2 from the Controller. The command chosen is VOLUME_UP.
> ---
> unit/test-avrcp.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/unit/test-avrcp.c b/unit/test-avrcp.c
> index 9bd27da..7308443 100644
> --- a/unit/test-avrcp.c
> +++ b/unit/test-avrcp.c
> @@ -251,11 +251,21 @@ static void execute_context(struct context *context)
>
> static bool handle_play(struct avrcp *session)
> {
> + DBG("");
> +
> + return true;
> +}
> +
> +static bool handle_volume_up(struct avrcp *session)
> +{
> + DBG("");
> +
> return true;
> }
>
> static const struct avrcp_passthrough_handler passthrough_handlers[] = {
> { AVC_PLAY, handle_play },
> + { AVC_VOLUME_UP, handle_volume_up },
> { },
> };
>
> @@ -310,5 +320,11 @@ int main(int argc, char *argv[])
> raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
> 0x44, 0x00));
>
> + define_test("/TP/PTT/BV-02-I", test_server,
> + raw_pdu(0x00, 0x11, 0x0e, 0x00, 0x48, 0x7c,
> + AVC_VOLUME_UP, 0x00),
> + raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
> + AVC_VOLUME_UP, 0x00));
> +
> return g_test_run();
> }
> --
> 1.8.3.2

Patches 1-3 applied, not sure where is 4/4 so Im waiting to see it
does show up otherwise you have to resend it.


--
Luiz Augusto von Dentz

2014-02-25 10:09:29

by Andrei Emeltchenko

Subject: [PATCH 3/4] unit/avrcp: Add /TP/PTT/BV-04-I test

From: Andrei Emeltchenko <[email protected]>

Test verifies that the Target reacts to the PASS THROUGH command in
category 4 from the Controller. The command chosen is SELECT.
---
unit/test-avrcp.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/unit/test-avrcp.c b/unit/test-avrcp.c
index d46f98c..66f0973 100644
--- a/unit/test-avrcp.c
+++ b/unit/test-avrcp.c
@@ -270,10 +270,18 @@ static bool handle_channel_up(struct avrcp *session)
return true;
}

+static bool handle_select(struct avrcp *session)
+{
+ DBG("");
+
+ return true;
+}
+
static const struct avrcp_passthrough_handler passthrough_handlers[] = {
{ AVC_PLAY, handle_play },
{ AVC_VOLUME_UP, handle_volume_up },
{ AVC_CHANNEL_UP, handle_channel_up },
+ { AVC_SELECT, handle_select },
{ },
};

@@ -340,5 +348,11 @@ int main(int argc, char *argv[])
raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
AVC_CHANNEL_UP, 0x00));

+ define_test("/TP/PTT/BV-04-I", test_server,
+ raw_pdu(0x00, 0x11, 0x0e, 0x00, 0x48, 0x7c,
+ AVC_SELECT, 0x00),
+ raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
+ AVC_SELECT, 0x00));
+
return g_test_run();
}
--
1.8.3.2

2014-02-25 10:09:30

by Andrei Emeltchenko

Subject: [PATCH 4/4] unit/avrcp: Add /TP/PTT/BV-05-I test

From: Andrei Emeltchenko <[email protected]>

Test verifies that the Target reacts to the PASS THROUGH command in
category 1 from the Controller. The command chosen is PLAY (0x44).
The PLAY button is being pressed and released.
---
unit/test-avrcp.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/unit/test-avrcp.c b/unit/test-avrcp.c
index 66f0973..53e9237 100644
--- a/unit/test-avrcp.c
+++ b/unit/test-avrcp.c
@@ -354,5 +354,15 @@ int main(int argc, char *argv[])
raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
AVC_SELECT, 0x00));

+ define_test("/TP/PTT/BV-05-I", test_server,
+ raw_pdu(0x00, 0x11, 0x0e, 0x00, 0x48, 0x7c,
+ AVC_PLAY, 0x00),
+ raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
+ AVC_PLAY, 0x00),
+ raw_pdu(0x00, 0x11, 0x0e, 0x00, 0x48, 0x7c,
+ AVC_PLAY | 0x80, 0x00),
+ raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
+ AVC_PLAY | 0x80, 0x00));
+
return g_test_run();
}
--
1.8.3.2

2014-02-25 10:09:28

by Andrei Emeltchenko

Subject: [PATCH 2/4] unit/avrcp: Add /TP/PTT/BV-03-I test

From: Andrei Emeltchenko <[email protected]>

Test verifies that the Target reacts to the PASS THROUGH command in
category 3 from the Controller. The command chosen is CHANNEL_UP.
---
unit/test-avrcp.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)

diff --git a/unit/test-avrcp.c b/unit/test-avrcp.c
index 7308443..d46f98c 100644
--- a/unit/test-avrcp.c
+++ b/unit/test-avrcp.c
@@ -263,9 +263,17 @@ static bool handle_volume_up(struct avrcp *session)
return true;
}

+static bool handle_channel_up(struct avrcp *session)
+{
+ DBG("");
+
+ return true;
+}
+
static const struct avrcp_passthrough_handler passthrough_handlers[] = {
{ AVC_PLAY, handle_play },
{ AVC_VOLUME_UP, handle_volume_up },
+ { AVC_CHANNEL_UP, handle_channel_up },
{ },
};

@@ -326,5 +334,11 @@ int main(int argc, char *argv[])
raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
AVC_VOLUME_UP, 0x00));

+ define_test("/TP/PTT/BV-03-I", test_server,
+ raw_pdu(0x00, 0x11, 0x0e, 0x00, 0x48, 0x7c,
+ AVC_CHANNEL_UP, 0x00),
+ raw_pdu(0x02, 0x11, 0x0e, 0x09, 0x48, 0x7c,
+ AVC_CHANNEL_UP, 0x00));
+
return g_test_run();
}
--
1.8.3.2