2014-02-25 10:19:17

by Andrei Emeltchenko

Subject: [PATCH] tools: Fix using uninitialized value

From: Andrei Emeltchenko <[email protected]>

Fixes warning:
tools/ibeacon.c:150:14: warning: The left expression of the compound
assignment is an uninitialized value. The computed value will also be
garbage
cmd.data[2] |= 0x02; /* LE General Discoverable Mode
*/
~~~~~~~~~~~ ^
1 warning generated.
---
tools/ibeacon.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/ibeacon.c b/tools/ibeacon.c
index 458f9e7..cd0ef65 100644
--- a/tools/ibeacon.c
+++ b/tools/ibeacon.c
@@ -145,6 +145,8 @@ static void adv_tx_power_callback(const void *data, uint8_t size,
return;
}

+ memset(&cmd, 0, sizeof(cmd));
+
cmd.data[0] = 0x02; /* Field length */
cmd.data[1] = 0x01; /* Flags */
cmd.data[2] |= 0x02; /* LE General Discoverable Mode */
--
1.8.3.2

2014-03-03 14:55:16

by Johan Hedberg

Subject: Re: [PATCH] tools: Fix using uninitialized value

Hi Andrei,

On Mon, Mar 03, 2014, Andrei Emeltchenko wrote:
> Fixes warning:
> tools/ibeacon.c:150:14: warning: The left expression of the compound
> assignment is an uninitialized value. The computed value will also be
> garbage
> cmd.data[2] |= 0x02; /* LE General Discoverable Mode
> */
> ~~~~~~~~~~~ ^
> 1 warning generated.
> ---
> tools/ibeacon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/ibeacon.c b/tools/ibeacon.c
> index 458f9e7..2071c6b 100644
> --- a/tools/ibeacon.c
> +++ b/tools/ibeacon.c
> @@ -147,7 +147,7 @@ static void adv_tx_power_callback(const void *data, uint8_t size,
>
> cmd.data[0] = 0x02; /* Field length */
> cmd.data[1] = 0x01; /* Flags */
> - cmd.data[2] |= 0x02; /* LE General Discoverable Mode */
> + cmd.data[2] = 0x02; /* LE General Discoverable Mode */
> cmd.data[2] |= 0x04; /* BR/EDR Not Supported */
>
> cmd.data[3] = 0x1a; /* Field length */

Applied. Thanks.

Johan