2014-03-20 13:25:08

by Lukasz Rymanowski

Subject: [PATCH 1/2] tools/mgmt-tester: Minor fix in Stop discovery Success 1 test

Set directly setup_send params for start discovery. It will be easier to
follow the test.
---
tools/mgmt-tester.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
index 82952c7..24febf6 100644
--- a/tools/mgmt-tester.c
+++ b/tools/mgmt-tester.c
@@ -1722,6 +1722,8 @@ static const char stop_discovery_inq_param[] = { 0x33, 0x8b, 0x9e, 0x08, 0x00 };
static const struct generic_data stop_discovery_success_test_1 = {
.setup_settings = settings_powered_le,
.setup_send_opcode = MGMT_OP_START_DISCOVERY,
+ .setup_send_param = start_discovery_bredrle_param,
+ .setup_send_len = sizeof(start_discovery_bredrle_param),
.send_opcode = MGMT_OP_STOP_DISCOVERY,
.send_param = stop_discovery_bredrle_param,
.send_len = sizeof(stop_discovery_bredrle_param),
--
1.8.4

2014-03-20 14:17:10

by Johan Hedberg

Subject: Re: [PATCH 1/2] tools/mgmt-tester: Minor fix in Stop discovery Success 1 test

Hi Lukasz,

On Thu, Mar 20, 2014, Lukasz Rymanowski wrote:
> Set directly setup_send params for start discovery. It will be easier to
> follow the test.
> ---
> tools/mgmt-tester.c | 2 ++
> 1 file changed, 2 insertions(+)

Both patches have been applied. Thanks.

Johan

2014-03-20 13:25:09

by Lukasz Rymanowski

Subject: [PATCH 2/2] tools/mgmt-tester: Remove dead code

---
tools/mgmt-tester.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/tools/mgmt-tester.c b/tools/mgmt-tester.c
index 24febf6..b60d7d8 100644
--- a/tools/mgmt-tester.c
+++ b/tools/mgmt-tester.c
@@ -2842,12 +2842,6 @@ static void setup_start_discovery(const void *test_data)
const struct generic_data *test = data->test_data;
const void *send_param = test->setup_send_param;
uint16_t send_len = test->setup_send_len;
- unsigned char disc_param[] = { 0x07 };
-
- if (!send_param) {
- send_param = disc_param;
- send_len = 1;
- }

mgmt_send(data->mgmt, test->setup_send_opcode, data->mgmt_index,
send_len, send_param, setup_discovery_callback,
--
1.8.4