2014-03-30 06:04:31

by Lukasz Rymanowski

Subject: [PATCH] android/gatt: Fix regression introduced by b278efa5

Seems that GattService onScanResult is only looking into remote uuids in
adverisement data. No device object is created in the Android framework,
Therefore we need to send regular device found for BLE devices as well.
Otherwise the Android GATT application will not be aware of remote device
properties like name etc.
---
android/bluetooth.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/android/bluetooth.c b/android/bluetooth.c
index 690aaf6..734adeb 100644
--- a/android/bluetooth.c
+++ b/android/bluetooth.c
@@ -1331,9 +1331,6 @@ static bool is_new_device(const struct device *dev)
if (dev->found)
return false;

- if (adapter.cur_discovery_type != SCAN_TYPE_DUAL)
- return false;
-
if (dev->bond_state == HAL_BOND_STATE_BONDED)
return false;

--
1.8.4

2014-03-30 22:07:09

by Szymon Janc

Subject: Re: [PATCH] android/gatt: Fix regression introduced by b278efa5

Hi Łukasz,

On Sunday 30 March 2014 08:04:31 Lukasz Rymanowski wrote:
> Seems that GattService onScanResult is only looking into remote uuids in
> adverisement data. No device object is created in the Android framework,
> Therefore we need to send regular device found for BLE devices as well.
> Otherwise the Android GATT application will not be aware of remote device
> properties like name etc.
> ---
> android/bluetooth.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/android/bluetooth.c b/android/bluetooth.c
> index 690aaf6..734adeb 100644
> --- a/android/bluetooth.c
> +++ b/android/bluetooth.c
> @@ -1331,9 +1331,6 @@ static bool is_new_device(const struct device *dev)
> if (dev->found)
> return false;
>
> - if (adapter.cur_discovery_type != SCAN_TYPE_DUAL)
> - return false;
> -
> if (dev->bond_state == HAL_BOND_STATE_BONDED)
> return false;

Applied, thanks.

--
Szymon K. Janc
[email protected]