2014-06-19 10:28:21

by Andrei Emeltchenko

Subject: [PATCH] android/gatt: Remove dead code

From: Andrei Emeltchenko <[email protected]>

The code apparently left after wrong rebase as it duplicates code
several lines above.
---
android/gatt.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/android/gatt.c b/android/gatt.c
index 24884e9..5007817 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -5310,11 +5310,6 @@ static uint8_t find_info_handle(const uint8_t *cmd, uint16_t cmd_len,

}

- if (!adl) {
- queue_destroy(q, NULL);
- return ATT_ECODE_INSUFF_RESOURCES;
- }
-
len = enc_find_info_resp(ATT_FIND_INFO_RESP_FMT_16BIT, adl, rsp,
rsp_size);
if (!len)
--
1.8.3.2

2014-06-25 15:18:02

by Szymon Janc

Subject: Re: [PATCH] android/gatt: Remove dead code

Hi Andrei,

On Thursday 19 of June 2014 13:28:21 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> The code apparently left after wrong rebase as it duplicates code
> several lines above.
> ---
> android/gatt.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 24884e9..5007817 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -5310,11 +5310,6 @@ static uint8_t find_info_handle(const uint8_t *cmd, uint16_t cmd_len,
>
> }
>
> - if (!adl) {
> - queue_destroy(q, NULL);
> - return ATT_ECODE_INSUFF_RESOURCES;
> - }
> -
> len = enc_find_info_resp(ATT_FIND_INFO_RESP_FMT_16BIT, adl, rsp,
> rsp_size);
> if (!len)
>

Patch applied, thanks.

--
Best regards,
Szymon Janc