2014-06-19 10:36:19

by Andrei Emeltchenko

Subject: [PATCH] android/gatt: Fix wrong size argument

From: Andrei Emeltchenko <[email protected]>

Instead of sizeof of (uint8_t *) pass real length, though for that
function it doesn't matter at this point.
---
android/gatt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/android/gatt.c b/android/gatt.c
index 5007817..7ce57ca 100644
--- a/android/gatt.c
+++ b/android/gatt.c
@@ -5688,7 +5688,7 @@ static void att_handler(const uint8_t *ipdu, uint16_t len, gpointer user_data)
* registered for this indication, event will be send in
* handle_notification
*/
- resp_length = enc_confirmation(opdu, sizeof(opdu));
+ resp_length = enc_confirmation(opdu, length);
status = 0;
break;
case ATT_OP_HANDLE_NOTIFY:
--
1.8.3.2

2014-06-25 15:18:13

by Szymon Janc

Subject: Re: [PATCH] android/gatt: Fix wrong size argument

Hi Andrei,

On Thursday 19 of June 2014 13:36:19 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> Instead of sizeof of (uint8_t *) pass real length, though for that
> function it doesn't matter at this point.
> ---
> android/gatt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/android/gatt.c b/android/gatt.c
> index 5007817..7ce57ca 100644
> --- a/android/gatt.c
> +++ b/android/gatt.c
> @@ -5688,7 +5688,7 @@ static void att_handler(const uint8_t *ipdu, uint16_t len, gpointer user_data)
> * registered for this indication, event will be send in
> * handle_notification
> */
> - resp_length = enc_confirmation(opdu, sizeof(opdu));
> + resp_length = enc_confirmation(opdu, length);
> status = 0;
> break;
> case ATT_OP_HANDLE_NOTIFY:
>

Applied. Thanks.

--
Best regards,
Szymon Janc