2014-08-25 11:08:52

by Jakub Tyszkowski

Subject: [PATCH] emulator/btdev: Fix not disabling le advertising on connection

Le Advertising should be disabled after the le connection is
established (Core Spec. 4.1 - Part E, Sec. 7.8.9). Not doing so
results in errors while switching advertisement multiple times during
different connection states.
---
emulator/btdev.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/emulator/btdev.c b/emulator/btdev.c
index b09f8cb..86fd3d9 100644
--- a/emulator/btdev.c
+++ b/emulator/btdev.c
@@ -1023,6 +1023,7 @@ static void le_conn_complete(struct btdev *btdev,

btdev->conn = remote;
remote->conn = btdev;
+ remote->le_adv_enable = 0;

cc->status = status;
cc->peer_addr_type = btdev->le_scan_own_addr_type;
--
1.9.1

2014-08-28 09:03:52

by Jakub Tyszkowski

Subject: Re: [PATCH] emulator/btdev: Fix not disabling le advertising on connection

On 08/25/2014 01:08 PM, Jakub Tyszkowski wrote:
> Le Advertising should be disabled after the le connection is
> established (Core Spec. 4.1 - Part E, Sec. 7.8.9). Not doing so
> results in errors while switching advertisement multiple times during
> different connection states.
> ---
> emulator/btdev.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/emulator/btdev.c b/emulator/btdev.c
> index b09f8cb..86fd3d9 100644
> --- a/emulator/btdev.c
> +++ b/emulator/btdev.c
> @@ -1023,6 +1023,7 @@ static void le_conn_complete(struct btdev *btdev,
>
> btdev->conn = remote;
> remote->conn = btdev;
> + remote->le_adv_enable = 0;
>
> cc->status = status;
> cc->peer_addr_type = btdev->le_scan_own_addr_type;
>
ping

2014-09-01 12:18:45

by Johan Hedberg

Subject: Re: [PATCH] emulator/btdev: Fix not disabling le advertising on connection

Hi Jakub,

On Mon, Aug 25, 2014, Jakub Tyszkowski wrote:
> Le Advertising should be disabled after the le connection is
> established (Core Spec. 4.1 - Part E, Sec. 7.8.9). Not doing so
> results in errors while switching advertisement multiple times during
> different connection states.
> ---
> emulator/btdev.c | 1 +
> 1 file changed, 1 insertion(+)

Applied. Thanks.

Johan