2014-11-11 00:10:56

by Marie Janssen

Subject: [PATCH BlueZ] shared/att: bugfix for BT_ATT_ALL_REQUESTS

opcode can now be zero, since that is BT_ATT_ALL_REQUESTS

---
src/shared/att.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/att.c b/src/shared/att.c
index aa80cef..48c36ac 100644
--- a/src/shared/att.c
+++ b/src/shared/att.c
@@ -1115,7 +1115,7 @@ unsigned int bt_att_register(struct bt_att *att, uint8_t opcode,
{
struct att_notify *notify;

- if (!att || !opcode || !callback || !att->io)
+ if (!att || !callback || !att->io)
return 0;

notify = new0(struct att_notify, 1);
--
2.1.0.rc2.206.gedb03e5

2014-11-11 12:41:01

by Luiz Augusto von Dentz

Subject: Re: [PATCH BlueZ] shared/att: bugfix for BT_ATT_ALL_REQUESTS

Hi Michael,

On Tue, Nov 11, 2014 at 2:10 AM, Michael Janssen <[email protected]> wrote:
> opcode can now be zero, since that is BT_ATT_ALL_REQUESTS
>
> ---
> src/shared/att.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/shared/att.c b/src/shared/att.c
> index aa80cef..48c36ac 100644
> --- a/src/shared/att.c
> +++ b/src/shared/att.c
> @@ -1115,7 +1115,7 @@ unsigned int bt_att_register(struct bt_att *att, uint8_t opcode,
> {
> struct att_notify *notify;
>
> - if (!att || !opcode || !callback || !att->io)
> + if (!att || !callback || !att->io)
> return 0;
>
> notify = new0(struct att_notify, 1);
> --
> 2.1.0.rc2.206.gedb03e5

Applied, thanks.


--
Luiz Augusto von Dentz