2014-11-12 09:01:35

by Gowtham Anandha Babu

Subject: [PATCH 1/3] src/profile: Add pbapsupportedfeatures to PSE

Add PbapSupportedFeatures(0x0317) to PSE Record.

PTS Test case passed:
TP/SSM/BV-11-C [PSE Shares PbapSupportedFeatures bits].
---
src/profile.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/src/profile.c b/src/profile.c
index bccb145..252063b 100644
--- a/src/profile.c
+++ b/src/profile.c
@@ -393,6 +393,9 @@
<attribute id=\"0x0314\"> \
<uint8 value=\"0x01\"/> \
</attribute> \
+ <attribute id=\"0x0317\"> \
+ <uint32 value=\"0x00000003\"/> \
+ </attribute> \
</record>"

#define MAS_RECORD \
--
1.9.1

2014-11-12 15:15:37

by Luiz Augusto von Dentz

Subject: Re: [PATCH 1/3] src/profile: Add pbapsupportedfeatures to PSE

Hi Gowtham,

On Wed, Nov 12, 2014 at 11:01 AM, Gowtham Anandha Babu
<[email protected]> wrote:
> Add PbapSupportedFeatures(0x0317) to PSE Record.
>
> PTS Test case passed:
> TP/SSM/BV-11-C [PSE Shares PbapSupportedFeatures bits].
> ---
> src/profile.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/profile.c b/src/profile.c
> index bccb145..252063b 100644
> --- a/src/profile.c
> +++ b/src/profile.c
> @@ -393,6 +393,9 @@
> <attribute id=\"0x0314\"> \
> <uint8 value=\"0x01\"/> \
> </attribute> \
> + <attribute id=\"0x0317\"> \
> + <uint32 value=\"0x00000003\"/> \
> + </attribute> \
> </record>"
>
> #define MAS_RECORD \
> --
> 1.9.1

Applied, thanks.


--
Luiz Augusto von Dentz

2014-11-12 09:01:37

by Gowtham Anandha Babu

Subject: [PATCH 3/3] tools/sdptool: Add support for IrMC service record

IrMC Record output captured from sdptool:

Attribute Identifier : 0x0 - ServiceRecordHandle
Integer : 0x1000b
Attribute Identifier : 0x1 - ServiceClassIDList
Data Sequence
UUID16 : 0x1104 - IrMCSync
Attribute Identifier : 0x4 - ProtocolDescriptorList
Data Sequence
Data Sequence
UUID16 : 0x0100 - L2CAP
Data Sequence
UUID16 : 0x0003 - RFCOMM
Channel/Port (Integer) : 0xe
Data Sequence
UUID16 : 0x0008 - OBEX
Attribute Identifier : 0x5 - BrowseGroupList
Data Sequence
UUID16 : 0x1002 - PublicBrowseGroup
Attribute Identifier : 0x9 - BluetoothProfileDescriptorList
Data Sequence
Data Sequence
UUID16 : 0x1104 - IrMCSync
Version (Integer) : 0x100
Attribute Identifier : 0x100
Data : 53 79 6e 63 68 72 6f 6e 69 7a 61 74 69 6f 6e 00
Attribute Identifier : 0x301 - SupportedDataStoresList
Data Sequence
Integer : 0x1
---
tools/sdptool.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tools/sdptool.c b/tools/sdptool.c
index 9fd1b7f..f3aebd2 100644
--- a/tools/sdptool.c
+++ b/tools/sdptool.c
@@ -227,6 +227,11 @@ static struct attrib_def audio_attrib_names[] = {
{ 0x302, "Remote audio volume control", NULL, 0 },
};

+/* Name of the various IrMCSync attributes. See BT assigned numbers */
+static struct attrib_def irmc_attrib_names[] = {
+ { 0x0301, "SupportedDataStoresList", NULL, 0 },
+};
+
/* Name of the various GOEP attributes. See BT assigned numbers */
static struct attrib_def goep_attrib_names[] = {
{ 0x200, "GoepL2capPsm", NULL, 0 },
@@ -284,7 +289,8 @@ static struct uuid_def uuid16_names[] = {
{ 0x1101, "SerialPort", NULL, 0 },
{ 0x1102, "LANAccessUsingPPP", NULL, 0 },
{ 0x1103, "DialupNetworking (DUN)", NULL, 0 },
- { 0x1104, "IrMCSync", NULL, 0 },
+ { 0x1104, "IrMCSync",
+ irmc_attrib_names, N_ELEMENTS(irmc_attrib_names) },
{ 0x1105, "OBEXObjectPush",
goep_attrib_names, N_ELEMENTS(goep_attrib_names) },
{ 0x1106, "OBEXFileTransfer",
--
1.9.1

2014-11-12 09:01:36

by Gowtham Anandha Babu

Subject: [PATCH 2/3] tools/sdptool: Add support for PBAP service record

PBAP Record output captured from sdptool:

Attribute Identifier : 0x0 - ServiceRecordHandle
Integer : 0x1000a
Attribute Identifier : 0x1 - ServiceClassIDList
Data Sequence
UUID16 : 0x112f - Phonebook Access (PBAP) - PSE
Attribute Identifier : 0x4 - ProtocolDescriptorList
Data Sequence
Data Sequence
UUID16 : 0x0100 - L2CAP
Data Sequence
UUID16 : 0x0003 - RFCOMM
Channel/Port (Integer) : 0xf
Data Sequence
UUID16 : 0x0008 - OBEX
Attribute Identifier : 0x5 - BrowseGroupList
Data Sequence
UUID16 : 0x1002 - PublicBrowseGroup
Attribute Identifier : 0x9 - BluetoothProfileDescriptorList
Data Sequence
Data Sequence
UUID16 : 0x1130 - Phonebook Access (PBAP)
Version (Integer) : 0x101
Attribute Identifier : 0x100
Data : 50 68 6f 6e 65 20 42 6f 6f 6b 20 41 63 63 65 73 73 00
Attribute Identifier : 0x314 - SupportedRepositories
Integer : 0x1
Attribute Identifier : 0x317 - PbapSupportedFeatures
Integer : 0x3
---
tools/sdptool.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tools/sdptool.c b/tools/sdptool.c
index 88a52bb..9fd1b7f 100644
--- a/tools/sdptool.c
+++ b/tools/sdptool.c
@@ -232,6 +232,12 @@ static struct attrib_def goep_attrib_names[] = {
{ 0x200, "GoepL2capPsm", NULL, 0 },
};

+/* Name of the various PBAP attributes. See BT assigned numbers */
+static struct attrib_def pbap_attrib_names[] = {
+ { 0x0314, "SupportedRepositories", NULL, 0 },
+ { 0x0317, "PbapSupportedFeatures", NULL, 0 },
+};
+
/* Name of the various MAS attributes. See BT assigned numbers */
static struct attrib_def mas_attrib_names[] = {
{ 0x0315, "MASInstanceID", NULL, 0 },
@@ -327,7 +333,8 @@ static struct uuid_def uuid16_names[] = {
{ 0x112c, "Audio/Video", NULL, 0 },
{ 0x112d, "SIM Access (SAP)", NULL, 0 },
{ 0x112e, "Phonebook Access (PBAP) - PCE", NULL, 0 },
- { 0x112f, "Phonebook Access (PBAP) - PSE", NULL, 0 },
+ { 0x112f, "Phonebook Access (PBAP) - PSE",
+ pbap_attrib_names, N_ELEMENTS(pbap_attrib_names) },
{ 0x1130, "Phonebook Access (PBAP)", NULL, 0 },
{ 0x1131, "Headset (HSP)", NULL, 0 },
{ 0x1132, "Message Access (MAP) - MAS",
--
1.9.1