2014-12-02 11:01:09

by Lukasz Rymanowski

Subject: [PATCH] shared/hfp: Improve prefix comparing

---
src/shared/hfp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/shared/hfp.c b/src/shared/hfp.c
index 5a91d12..ead082e 100644
--- a/src/shared/hfp.c
+++ b/src/shared/hfp.c
@@ -936,7 +936,7 @@ static bool match_handler_event_prefix(const void *a, const void *b)
const struct event_handler *handler = a;
const char *prefix = b;

- if (memcmp(handler->prefix, prefix, strlen(prefix)))
+ if (strcmp(handler->prefix, prefix) != 0)
return false;

return true;
--
1.8.4

2014-12-03 10:06:40

by Szymon Janc

Subject: Re: [PATCH] shared/hfp: Improve prefix comparing

Hi Łukasz,

On Tuesday 02 of December 2014 12:01:09 Lukasz Rymanowski wrote:
> ---
> src/shared/hfp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/shared/hfp.c b/src/shared/hfp.c
> index 5a91d12..ead082e 100644
> --- a/src/shared/hfp.c
> +++ b/src/shared/hfp.c
> @@ -936,7 +936,7 @@ static bool match_handler_event_prefix(const void *a, const void *b)
> const struct event_handler *handler = a;
> const char *prefix = b;
>
> - if (memcmp(handler->prefix, prefix, strlen(prefix)))
> + if (strcmp(handler->prefix, prefix) != 0)
> return false;
>
> return true;

Applied, thanks.

--
Best regards,
Szymon Janc