2014-12-19 13:32:20

by Gowtham Anandha Babu

[permalink] [raw]
Subject: [PATCH] tools/bccmd: Remove dead code

warning: Value stored to 'handle' is never read
handle = array[0] | (array[1] << 8);
^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
---
tools/bccmd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/tools/bccmd.c b/tools/bccmd.c
index 4649ad5..2646660 100644
--- a/tools/bccmd.c
+++ b/tools/bccmd.c
@@ -279,7 +279,6 @@ static int cmd_keylen(int transport, int argc, char *argv[])
if (err < 0)
return -1;

- handle = array[0] | (array[1] << 8);
keylen = array[2] | (array[3] << 8);

printf("Crypt key length: %d bit\n", keylen * 8);
--
1.9.1



2015-01-08 09:51:06

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] tools/bccmd: Remove dead code

Hi Gowtham,

On Fri, Dec 19, 2014, Gowtham Anandha Babu wrote:
> warning: Value stored to 'handle' is never read
> handle = array[0] | (array[1] << 8);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
> ---
> tools/bccmd.c | 1 -
> 1 file changed, 1 deletion(-)

Applied. Thanks.

Johan

2015-01-07 09:54:34

by Gowtham Anandha Babu

[permalink] [raw]
Subject: RE: [PATCH] tools/bccmd: Remove dead code

Ping.

> -----Original Message-----
> From: [email protected] [mailto:linux-bluetooth-
> [email protected]] On Behalf Of Gowtham Anandha Babu
> Sent: Friday, December 19, 2014 7:02 PM
> To: [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; Gowtham Anandha Babu
> Subject: [PATCH] tools/bccmd: Remove dead code
>
> warning: Value stored to 'handle' is never read
> handle = array[0] | (array[1] << 8);
> ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~
> ---
> tools/bccmd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/bccmd.c b/tools/bccmd.c index 4649ad5..2646660 100644
> --- a/tools/bccmd.c
> +++ b/tools/bccmd.c
> @@ -279,7 +279,6 @@ static int cmd_keylen(int transport, int argc, char
> *argv[])
> if (err < 0)
> return -1;
>
> - handle = array[0] | (array[1] << 8);
> keylen = array[2] | (array[3] << 8);
>
> printf("Crypt key length: %d bit\n", keylen * 8);
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth"
in
> the body of a message to [email protected] More majordomo
> info at http://vger.kernel.org/majordomo-info.html