This patch set reverts the previous commits on GATT write test cases and
adds the below server test cases (tested against small and large DB):
1) Write Characteristic Value - to Server
2) Write Characteristic Value – Invalid Handle Response
3) Write Characteristic Value – Write Not Permitted Response
Bharat Panda (2):
unit/test-gatt: Add TP/GAW/SR/BI-02-C test
unit/test-gatt: Add TP/GAW/SR/BI-03-C test
Gowtham Anandha Babu (2):
unit/test-gatt: Revert GATT server write TC
unit/test-gatt: Add TP/GAW/SR/BV-03-C test
unit/test-gatt.c | 42 ++++++++++++++++++++++++++++++------------
1 file changed, 30 insertions(+), 12 deletions(-)
--
1.9.1
Hi Luiz,
> -----Original Message-----
> From: [email protected] [mailto:linux-bluetooth-
> [email protected]] On Behalf Of Luiz Augusto von Dentz
> Sent: Monday, March 02, 2015 2:02 PM
> To: Gowtham Anandha Babu
> Cc: [email protected]; Bharat Panda; [email protected]
> Subject: Re: [PATCH 1/4] unit/test-gatt: Revert GATT server write TC
>
> Hi Gowtham,
>
> On Mon, Mar 2, 2015 at 9:00 AM, Gowtham Anandha Babu
> <[email protected]> wrote:
> > This patch reverts the following commits:
> > fdca0c1dc9022b92bf7f621f00503fb161b337ee
> > 7b8f5250b71e36052e0adeb3a32aa9f51f26e928
> > d00d1fa59c87eeb7086cbdadfe7eb99c124b8816.
> >
> > The GATT server test cases are supposed to tested against ts_small_db
> > and ts_large_db_1.
> > ---
> > unit/test-gatt.c | 21 +--------------------
> > 1 file changed, 1 insertion(+), 20 deletions(-)
> >
> > diff --git a/unit/test-gatt.c b/unit/test-gatt.c index
> > 69654f1..df74122 100644
> > --- a/unit/test-gatt.c
> > +++ b/unit/test-gatt.c
> > @@ -1101,8 +1101,7 @@ static struct gatt_db
> *make_service_data_1_db(void)
> > "Device Name"),
> > PRIMARY_SERVICE(0x0005, HEART_RATE_UUID, 4),
> >
> CHARACTERISTIC_STR(GATT_CHARAC_MANUFACTURER_NAME_STRING,
> > - BT_ATT_PERM_READ |
> > - BT_ATT_PERM_WRITE,
> > + BT_ATT_PERM_READ,
> > BT_GATT_CHRC_PROP_READ |
> > BT_GATT_CHRC_PROP_WRITE, ""),
> > DESCRIPTOR_STR(GATT_CHARAC_USER_DESC_UUID,
> > BT_ATT_PERM_READ, @@ -3051,23 +3050,5 @@ int main(int argc, char
> *argv[])
> > raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
> > raw_pdu(0x01, 0x12, 0x07, 0x00, 0x0c));
> >
> > - define_test_server("/TP/GAW/SR/BV-03-C", test_server,
> > - service_db_1, NULL,
> > - raw_pdu(0x03, 0x00, 0x02),
> > - raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
> > - raw_pdu(0x13));
> > -
> > - define_test_server("/TP/GAW/SR/BI-02-C", test_server,
> > - service_db_1, NULL,
> > - raw_pdu(0x03, 0x00, 0x02),
> > - raw_pdu(0x12, 0x00, 0x00, 0x01, 0x02, 0x03),
> > - raw_pdu(0x01, 0x12, 0x00, 0x00, 0x01));
> > -
> > - define_test_server("/TP/GAW/SR/BI-03-C", test_server,
> > - service_db_1, NULL,
> > - raw_pdu(0x03, 0x00, 0x02),
> > - raw_pdu(0x12, 0x03, 0x00, 0x01, 0x02, 0x03),
> > - raw_pdu(0x01, 0x12, 0x03, 0x00, 0x03));
> > -
> > return tester_run();
> > }
> > --
> > 1.9.1
>
> I prefer that you fix the tests instead of reverting and adding them back.
>
Sent the patches, addressing your comments.
Regards,
Gowtham Anandha Babu
>
> --
> Luiz Augusto von Dentz
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected] More majordomo
> info at http://vger.kernel.org/majordomo-info.html
Hi Gowtham,
On Mon, Mar 2, 2015 at 9:00 AM, Gowtham Anandha Babu
<[email protected]> wrote:
> This patch reverts the following commits:
> fdca0c1dc9022b92bf7f621f00503fb161b337ee
> 7b8f5250b71e36052e0adeb3a32aa9f51f26e928
> d00d1fa59c87eeb7086cbdadfe7eb99c124b8816.
>
> The GATT server test cases are supposed to tested
> against ts_small_db and ts_large_db_1.
> ---
> unit/test-gatt.c | 21 +--------------------
> 1 file changed, 1 insertion(+), 20 deletions(-)
>
> diff --git a/unit/test-gatt.c b/unit/test-gatt.c
> index 69654f1..df74122 100644
> --- a/unit/test-gatt.c
> +++ b/unit/test-gatt.c
> @@ -1101,8 +1101,7 @@ static struct gatt_db *make_service_data_1_db(void)
> "Device Name"),
> PRIMARY_SERVICE(0x0005, HEART_RATE_UUID, 4),
> CHARACTERISTIC_STR(GATT_CHARAC_MANUFACTURER_NAME_STRING,
> - BT_ATT_PERM_READ |
> - BT_ATT_PERM_WRITE,
> + BT_ATT_PERM_READ,
> BT_GATT_CHRC_PROP_READ |
> BT_GATT_CHRC_PROP_WRITE, ""),
> DESCRIPTOR_STR(GATT_CHARAC_USER_DESC_UUID, BT_ATT_PERM_READ,
> @@ -3051,23 +3050,5 @@ int main(int argc, char *argv[])
> raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
> raw_pdu(0x01, 0x12, 0x07, 0x00, 0x0c));
>
> - define_test_server("/TP/GAW/SR/BV-03-C", test_server,
> - service_db_1, NULL,
> - raw_pdu(0x03, 0x00, 0x02),
> - raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
> - raw_pdu(0x13));
> -
> - define_test_server("/TP/GAW/SR/BI-02-C", test_server,
> - service_db_1, NULL,
> - raw_pdu(0x03, 0x00, 0x02),
> - raw_pdu(0x12, 0x00, 0x00, 0x01, 0x02, 0x03),
> - raw_pdu(0x01, 0x12, 0x00, 0x00, 0x01));
> -
> - define_test_server("/TP/GAW/SR/BI-03-C", test_server,
> - service_db_1, NULL,
> - raw_pdu(0x03, 0x00, 0x02),
> - raw_pdu(0x12, 0x03, 0x00, 0x01, 0x02, 0x03),
> - raw_pdu(0x01, 0x12, 0x03, 0x00, 0x03));
> -
> return tester_run();
> }
> --
> 1.9.1
I prefer that you fix the tests instead of reverting and adding them back.
--
Luiz Augusto von Dentz
From: Bharat Panda <[email protected]>
Verify that a Generic Attribute Profile server can detect and
reject a Write Characteristic Value Request to a non-writeable
Characteristic Value and issue a Write Not Permitted Response.
---
unit/test-gatt.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/unit/test-gatt.c b/unit/test-gatt.c
index cf1fae2..06f9193 100644
--- a/unit/test-gatt.c
+++ b/unit/test-gatt.c
@@ -3075,5 +3075,17 @@ int main(int argc, char *argv[])
raw_pdu(0x12, 0x0f, 0xf0, 0x01, 0x02, 0x03),
raw_pdu(0x01, 0x12, 0x0f, 0xf0, 0x01));
+ define_test_server("/TP/GAW/SR/BI-03-C/small", test_server,
+ ts_small_db, NULL,
+ raw_pdu(0x03, 0x00, 0x02),
+ raw_pdu(0x12, 0x13, 0xf0, 0x01, 0x02, 0x03),
+ raw_pdu(0x01, 0x12, 0x13, 0xf0, 0x03));
+
+ define_test_server("/TP/GAW/SR/BI-03-C/large-1", test_server,
+ ts_large_db_1, NULL,
+ raw_pdu(0x03, 0x00, 0x02),
+ raw_pdu(0x12, 0x04, 0x00, 0x01, 0x02, 0x03),
+ raw_pdu(0x01, 0x12, 0x04, 0x00, 0x03));
+
return tester_run();
}
--
1.9.1
From: Bharat Panda <[email protected]>
Verify that a Generic Attribute Profile server can detect a Write
Characteristic Value Request with an unsupported Characteristic
Value handle and issue an Invalid Handle Response.
---
unit/test-gatt.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/unit/test-gatt.c b/unit/test-gatt.c
index 104f415..cf1fae2 100644
--- a/unit/test-gatt.c
+++ b/unit/test-gatt.c
@@ -3063,5 +3063,17 @@ int main(int argc, char *argv[])
raw_pdu(0x12, 0x82, 0x00, 0x01, 0x02, 0x03),
raw_pdu(0x13));
+ define_test_server("/TP/GAW/SR/BI-02-C/small", test_server,
+ ts_small_db, NULL,
+ raw_pdu(0x03, 0x00, 0x02),
+ raw_pdu(0x12, 0x00, 0x00, 0x01, 0x02, 0x03),
+ raw_pdu(0x01, 0x12, 0x00, 0x00, 0x01));
+
+ define_test_server("/TP/GAW/SR/BI-02-C/large-1", test_server,
+ ts_large_db_1, NULL,
+ raw_pdu(0x03, 0x00, 0x02),
+ raw_pdu(0x12, 0x0f, 0xf0, 0x01, 0x02, 0x03),
+ raw_pdu(0x01, 0x12, 0x0f, 0xf0, 0x01));
+
return tester_run();
}
--
1.9.1
Verify that a Generic Attribute Profile server can support writing
a Characteristic Value selected by handle.
---
unit/test-gatt.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/unit/test-gatt.c b/unit/test-gatt.c
index df74122..104f415 100644
--- a/unit/test-gatt.c
+++ b/unit/test-gatt.c
@@ -1132,7 +1132,8 @@ static struct gatt_db *make_test_spec_small_db(void)
const struct att_handle_spec specs[] = {
SECONDARY_SERVICE(0x0001, DEVICE_INFORMATION_UUID, 16),
CHARACTERISTIC_STR(GATT_CHARAC_MANUFACTURER_NAME_STRING,
- BT_ATT_PERM_READ,
+ BT_ATT_PERM_READ |
+ BT_ATT_PERM_WRITE,
BT_GATT_CHRC_PROP_READ |
BT_GATT_CHRC_PROP_NOTIFY |
BT_GATT_CHRC_PROP_INDICATE,
@@ -3050,5 +3051,17 @@ int main(int argc, char *argv[])
raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
raw_pdu(0x01, 0x12, 0x07, 0x00, 0x0c));
+ define_test_server("/TP/GAW/SR/BV-03-C/small", test_server,
+ ts_small_db, NULL,
+ raw_pdu(0x03, 0x00, 0x02),
+ raw_pdu(0x12, 0x03, 0x00, 0x01, 0x02, 0x03),
+ raw_pdu(0x13));
+
+ define_test_server("/TP/GAW/SR/BV-03-C/large-1", test_server,
+ ts_large_db_1, NULL,
+ raw_pdu(0x03, 0x00, 0x02),
+ raw_pdu(0x12, 0x82, 0x00, 0x01, 0x02, 0x03),
+ raw_pdu(0x13));
+
return tester_run();
}
--
1.9.1
This patch reverts the following commits:
fdca0c1dc9022b92bf7f621f00503fb161b337ee
7b8f5250b71e36052e0adeb3a32aa9f51f26e928
d00d1fa59c87eeb7086cbdadfe7eb99c124b8816.
The GATT server test cases are supposed to tested
against ts_small_db and ts_large_db_1.
---
unit/test-gatt.c | 21 +--------------------
1 file changed, 1 insertion(+), 20 deletions(-)
diff --git a/unit/test-gatt.c b/unit/test-gatt.c
index 69654f1..df74122 100644
--- a/unit/test-gatt.c
+++ b/unit/test-gatt.c
@@ -1101,8 +1101,7 @@ static struct gatt_db *make_service_data_1_db(void)
"Device Name"),
PRIMARY_SERVICE(0x0005, HEART_RATE_UUID, 4),
CHARACTERISTIC_STR(GATT_CHARAC_MANUFACTURER_NAME_STRING,
- BT_ATT_PERM_READ |
- BT_ATT_PERM_WRITE,
+ BT_ATT_PERM_READ,
BT_GATT_CHRC_PROP_READ |
BT_GATT_CHRC_PROP_WRITE, ""),
DESCRIPTOR_STR(GATT_CHARAC_USER_DESC_UUID, BT_ATT_PERM_READ,
@@ -3051,23 +3050,5 @@ int main(int argc, char *argv[])
raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
raw_pdu(0x01, 0x12, 0x07, 0x00, 0x0c));
- define_test_server("/TP/GAW/SR/BV-03-C", test_server,
- service_db_1, NULL,
- raw_pdu(0x03, 0x00, 0x02),
- raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
- raw_pdu(0x13));
-
- define_test_server("/TP/GAW/SR/BI-02-C", test_server,
- service_db_1, NULL,
- raw_pdu(0x03, 0x00, 0x02),
- raw_pdu(0x12, 0x00, 0x00, 0x01, 0x02, 0x03),
- raw_pdu(0x01, 0x12, 0x00, 0x00, 0x01));
-
- define_test_server("/TP/GAW/SR/BI-03-C", test_server,
- service_db_1, NULL,
- raw_pdu(0x03, 0x00, 0x02),
- raw_pdu(0x12, 0x03, 0x00, 0x01, 0x02, 0x03),
- raw_pdu(0x01, 0x12, 0x03, 0x00, 0x03));
-
return tester_run();
}
--
1.9.1