2015-03-03 06:07:23

by Gowtham Anandha Babu

[permalink] [raw]
Subject: [PATCH v1 0/3] Add Write Characteristic Value server TC

Adds the below server test cases (tested against small and large DB):
1) Write Characteristic Value - to Server
2) Write Characteristic Value – Invalid Handle Response
3) Write Characteristic Value – Write Not Permitted Response

Bharat Panda (2):
unit/test-gatt: Add TP/GAW/SR/BI-02-C test
unit/test-gatt: Add TP/GAW/SR/BI-03-C test

Gowtham Anandha Babu (1):
unit/test-gatt: Add TP/GAW/SR/BV-03-C test

unit/test-gatt.c | 42 ++++++++++++++++++++++++++++++------------
1 file changed, 30 insertions(+), 12 deletions(-)

--
1.9.1



2015-03-03 09:20:49

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [PATCH v1 0/3] Add Write Characteristic Value server TC

Hi Gowtham,

On Tue, Mar 3, 2015 at 8:07 AM, Gowtham Anandha Babu
<[email protected]> wrote:
> Adds the below server test cases (tested against small and large DB):
> 1) Write Characteristic Value - to Server
> 2) Write Characteristic Value – Invalid Handle Response
> 3) Write Characteristic Value – Write Not Permitted Response
>
> Bharat Panda (2):
> unit/test-gatt: Add TP/GAW/SR/BI-02-C test
> unit/test-gatt: Add TP/GAW/SR/BI-03-C test
>
> Gowtham Anandha Babu (1):
> unit/test-gatt: Add TP/GAW/SR/BV-03-C test
>
> unit/test-gatt.c | 42 ++++++++++++++++++++++++++++++------------
> 1 file changed, 30 insertions(+), 12 deletions(-)
>
> --
> 1.9.1

Applied after rewording the commit message.


--
Luiz Augusto von Dentz

2015-03-03 06:07:25

by Gowtham Anandha Babu

[permalink] [raw]
Subject: [PATCH v1 2/3] unit/test-gatt: Add TP/GAW/SR/BI-02-C test

From: Bharat Panda <[email protected]>

Verify that a Generic Attribute Profile server can detect a Write
Characteristic Value Request with an unsupported Characteristic
Value handle and issue an Invalid Handle Response.

The GATT server test cases are supposed to be tested against
ts_small_db and ts_large_db_1. So, Fixed those changes too.
---
unit/test-gatt.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/unit/test-gatt.c b/unit/test-gatt.c
index 7458fdd..a1dff74 100644
--- a/unit/test-gatt.c
+++ b/unit/test-gatt.c
@@ -3064,12 +3064,18 @@ int main(int argc, char *argv[])
raw_pdu(0x12, 0x82, 0x00, 0x01, 0x02, 0x03),
raw_pdu(0x13));

- define_test_server("/TP/GAW/SR/BI-02-C", test_server,
- service_db_1, NULL,
+ define_test_server("/TP/GAW/SR/BI-02-C/small", test_server,
+ ts_small_db, NULL,
raw_pdu(0x03, 0x00, 0x02),
raw_pdu(0x12, 0x00, 0x00, 0x01, 0x02, 0x03),
raw_pdu(0x01, 0x12, 0x00, 0x00, 0x01));

+ define_test_server("/TP/GAW/SR/BI-02-C/large-1", test_server,
+ ts_large_db_1, NULL,
+ raw_pdu(0x03, 0x00, 0x02),
+ raw_pdu(0x12, 0x0f, 0xf0, 0x01, 0x02, 0x03),
+ raw_pdu(0x01, 0x12, 0x0f, 0xf0, 0x01));
+
define_test_server("/TP/GAW/SR/BI-03-C", test_server,
service_db_1, NULL,
raw_pdu(0x03, 0x00, 0x02),
--
1.9.1


2015-03-03 06:07:24

by Gowtham Anandha Babu

[permalink] [raw]
Subject: [PATCH v1 1/3] unit/test-gatt: Add TP/GAW/SR/BV-03-C test

Verify that a Generic Attribute Profile server can support
writing a Characteristic Value selected by handle.

The GATT server test cases are supposed to be tested against
ts_small_db and ts_large_db_1. So, Fixed those changes too.
---
unit/test-gatt.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/unit/test-gatt.c b/unit/test-gatt.c
index 69654f1..7458fdd 100644
--- a/unit/test-gatt.c
+++ b/unit/test-gatt.c
@@ -1133,7 +1133,8 @@ static struct gatt_db *make_test_spec_small_db(void)
const struct att_handle_spec specs[] = {
SECONDARY_SERVICE(0x0001, DEVICE_INFORMATION_UUID, 16),
CHARACTERISTIC_STR(GATT_CHARAC_MANUFACTURER_NAME_STRING,
- BT_ATT_PERM_READ,
+ BT_ATT_PERM_READ |
+ BT_ATT_PERM_WRITE,
BT_GATT_CHRC_PROP_READ |
BT_GATT_CHRC_PROP_NOTIFY |
BT_GATT_CHRC_PROP_INDICATE,
@@ -3051,10 +3052,16 @@ int main(int argc, char *argv[])
raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
raw_pdu(0x01, 0x12, 0x07, 0x00, 0x0c));

- define_test_server("/TP/GAW/SR/BV-03-C", test_server,
- service_db_1, NULL,
+ define_test_server("/TP/GAW/SR/BV-03-C/small", test_server,
+ ts_small_db, NULL,
raw_pdu(0x03, 0x00, 0x02),
- raw_pdu(0x12, 0x07, 0x00, 0x01, 0x02, 0x03),
+ raw_pdu(0x12, 0x03, 0x00, 0x01, 0x02, 0x03),
+ raw_pdu(0x13));
+
+ define_test_server("/TP/GAW/SR/BV-03-C/large-1", test_server,
+ ts_large_db_1, NULL,
+ raw_pdu(0x03, 0x00, 0x02),
+ raw_pdu(0x12, 0x82, 0x00, 0x01, 0x02, 0x03),
raw_pdu(0x13));

define_test_server("/TP/GAW/SR/BI-02-C", test_server,
--
1.9.1


2015-03-03 06:07:26

by Gowtham Anandha Babu

[permalink] [raw]
Subject: [PATCH v1 3/3] unit/test-gatt: Add TP/GAW/SR/BI-03-C test

From: Bharat Panda <[email protected]>

Verify that a Generic Attribute Profile server can detect and
reject a Write Characteristic Value Request to a non-writeable
Characteristic Value and issue a Write Not Permitted Response.

The GATT server test cases are supposed to be tested against
ts_small_db and ts_large_db_1. So, Fixed these changes too.
---
unit/test-gatt.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/unit/test-gatt.c b/unit/test-gatt.c
index a1dff74..06f9193 100644
--- a/unit/test-gatt.c
+++ b/unit/test-gatt.c
@@ -1101,8 +1101,7 @@ static struct gatt_db *make_service_data_1_db(void)
"Device Name"),
PRIMARY_SERVICE(0x0005, HEART_RATE_UUID, 4),
CHARACTERISTIC_STR(GATT_CHARAC_MANUFACTURER_NAME_STRING,
- BT_ATT_PERM_READ |
- BT_ATT_PERM_WRITE,
+ BT_ATT_PERM_READ,
BT_GATT_CHRC_PROP_READ |
BT_GATT_CHRC_PROP_WRITE, ""),
DESCRIPTOR_STR(GATT_CHARAC_USER_DESC_UUID, BT_ATT_PERM_READ,
@@ -3076,11 +3075,17 @@ int main(int argc, char *argv[])
raw_pdu(0x12, 0x0f, 0xf0, 0x01, 0x02, 0x03),
raw_pdu(0x01, 0x12, 0x0f, 0xf0, 0x01));

- define_test_server("/TP/GAW/SR/BI-03-C", test_server,
- service_db_1, NULL,
+ define_test_server("/TP/GAW/SR/BI-03-C/small", test_server,
+ ts_small_db, NULL,
+ raw_pdu(0x03, 0x00, 0x02),
+ raw_pdu(0x12, 0x13, 0xf0, 0x01, 0x02, 0x03),
+ raw_pdu(0x01, 0x12, 0x13, 0xf0, 0x03));
+
+ define_test_server("/TP/GAW/SR/BI-03-C/large-1", test_server,
+ ts_large_db_1, NULL,
raw_pdu(0x03, 0x00, 0x02),
- raw_pdu(0x12, 0x03, 0x00, 0x01, 0x02, 0x03),
- raw_pdu(0x01, 0x12, 0x03, 0x00, 0x03));
+ raw_pdu(0x12, 0x04, 0x00, 0x01, 0x02, 0x03),
+ raw_pdu(0x01, 0x12, 0x04, 0x00, 0x03));

return tester_run();
}
--
1.9.1