2015-04-10 13:13:05

by Frederic Danis

Subject: [PATCH] tty: Re-add external interface for tty_set_termios()

This is needed by Bluetooth hci_uart module to be able to change speed
of Bluetooth controller and local UART.

Signed-off-by: Frederic Danis <[email protected]>
---
Re-send this patch on Peter Hurley request

drivers/tty/tty_ioctl.c | 3 ++-
include/linux/tty.h | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/tty_ioctl.c b/drivers/tty/tty_ioctl.c
index 632fc81..8e53fe4 100644
--- a/drivers/tty/tty_ioctl.c
+++ b/drivers/tty/tty_ioctl.c
@@ -536,7 +536,7 @@ EXPORT_SYMBOL(tty_termios_hw_change);
* Locking: termios_rwsem
*/

-static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
+int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
{
struct ktermios old_termios;
struct tty_ldisc *ld;
@@ -569,6 +569,7 @@ static int tty_set_termios(struct tty_struct *tty, struct ktermios *new_termios)
up_write(&tty->termios_rwsem);
return 0;
}
+EXPORT_SYMBOL_GPL(tty_set_termios);

/**
* set_termios - set termios values for a tty
diff --git a/include/linux/tty.h b/include/linux/tty.h
index 358a337..fe5623c 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -491,6 +491,7 @@ static inline speed_t tty_get_baud_rate(struct tty_struct *tty)

extern void tty_termios_copy_hw(struct ktermios *new, struct ktermios *old);
extern int tty_termios_hw_change(struct ktermios *a, struct ktermios *b);
+extern int tty_set_termios(struct tty_struct *tty, struct ktermios *kt);

extern struct tty_ldisc *tty_ldisc_ref(struct tty_struct *);
extern void tty_ldisc_deref(struct tty_ldisc *);
--
1.9.1

2015-04-21 16:04:18

by Marcel Holtmann

Subject: Re: [PATCH] tty: Re-add external interface for tty_set_termios()

Hi Greg,

>>> This is needed by Bluetooth hci_uart module to be able to change speed
>>> of Bluetooth controller and local UART.
>>
>> Because this is the lesser evil right now,
>>
>> Reviewed-by: Peter Hurley <[email protected]>
>
> Does this need to be in 4.1-rc1? Or is this a 4.2 thing?

if you can queue this up for 4.1-rc1, that would be great. We are using it. It is just the driver using it did not make it to 4.0-rc1 yet.

Regards

Marcel

2015-04-21 09:06:40

by Greg Kroah-Hartman

Subject: Re: [PATCH] tty: Re-add external interface for tty_set_termios()

On Fri, Apr 10, 2015 at 09:24:11AM -0400, Peter Hurley wrote:
> On 04/10/2015 09:13 AM, Frederic Danis wrote:
> > This is needed by Bluetooth hci_uart module to be able to change speed
> > of Bluetooth controller and local UART.
>
> Because this is the lesser evil right now,
>
> Reviewed-by: Peter Hurley <[email protected]>

Does this need to be in 4.1-rc1? Or is this a 4.2 thing?

thanks,

greg k-h

2015-04-10 13:24:11

by Peter Hurley

Subject: Re: [PATCH] tty: Re-add external interface for tty_set_termios()

On 04/10/2015 09:13 AM, Frederic Danis wrote:
> This is needed by Bluetooth hci_uart module to be able to change speed
> of Bluetooth controller and local UART.

Because this is the lesser evil right now,

Reviewed-by: Peter Hurley <[email protected]>