2015-08-12 10:46:01

by Frederic Danis

[permalink] [raw]
Subject: [PATCH] Bluetooth: hci_bcm: Fix "implicit declaration"

The kbuild test robot reported implicit declaration of function
'acpi_dev_get_resources'.

Surround ACPI function by CONFIG_ACPI test.

Reported-by: kbuild test robot <[email protected]>
Signed-off-by: Frederic Danis <[email protected]>
---
drivers/bluetooth/hci_bcm.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c
index cb7fe83..2bb0940 100644
--- a/drivers/bluetooth/hci_bcm.c
+++ b/drivers/bluetooth/hci_bcm.c
@@ -388,6 +388,7 @@ static const struct acpi_gpio_mapping acpi_bcm_default_gpios[] = {
{ },
};

+#ifdef CONFIG_ACPI
static int bcm_resource(struct acpi_resource *ares, void *data)
{
struct bcm_device *dev = data;
@@ -459,6 +460,12 @@ static int bcm_acpi_probe(struct bcm_device *dev)

return 0;
}
+#else
+static int bcm_acpi_probe(struct bcm_device *dev)
+{
+ return -EINVAL;
+}
+#endif /* CONFIG_ACPI */

static int bcm_probe(struct platform_device *pdev)
{
--
1.9.1


2015-08-12 14:43:42

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: hci_bcm: Fix "implicit declaration"

Hi Fred,

> The kbuild test robot reported implicit declaration of function
> 'acpi_dev_get_resources'.
>
> Surround ACPI function by CONFIG_ACPI test.
>
> Reported-by: kbuild test robot <[email protected]>
> Signed-off-by: Frederic Danis <[email protected]>
> ---
> drivers/bluetooth/hci_bcm.c | 7 +++++++
> 1 file changed, 7 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel