2015-09-22 18:09:10

by Szymon Janc

Subject: [PATCH] shared/gatt-helpers: Fix reporting discovery failure

If sending ATT request failed discovery should be reported as failed.
Due to missing goto success was overwritten with true value.
This regression was introduced in db24bf09d66325a.
---
src/shared/gatt-helpers.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/shared/gatt-helpers.c b/src/shared/gatt-helpers.c
index c773df7..008b8bc 100644
--- a/src/shared/gatt-helpers.c
+++ b/src/shared/gatt-helpers.c
@@ -1490,6 +1490,7 @@ static void discover_descs_cb(uint8_t opcode, const void *pdu,
return;

success = false;
+ goto done;
}

success = true;
--
2.5.0

2015-09-23 07:55:55

by Luiz Augusto von Dentz

Subject: Re: [PATCH] shared/gatt-helpers: Fix reporting discovery failure

Hi Szymon,

On Tue, Sep 22, 2015 at 9:09 PM, Szymon Janc <[email protected]> wrote:
> If sending ATT request failed discovery should be reported as failed.
> Due to missing goto success was overwritten with true value.
> This regression was introduced in db24bf09d66325a.
> ---
> src/shared/gatt-helpers.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/shared/gatt-helpers.c b/src/shared/gatt-helpers.c
> index c773df7..008b8bc 100644
> --- a/src/shared/gatt-helpers.c
> +++ b/src/shared/gatt-helpers.c
> @@ -1490,6 +1490,7 @@ static void discover_descs_cb(uint8_t opcode, const void *pdu,
> return;
>
> success = false;
> + goto done;
> }
>
> success = true;
> --
> 2.5.0

Applied, thanks.


--
Luiz Augusto von Dentz