2016-08-11 21:00:30

by Wolfram Sang

Subject: [PATCH] bluetooth: don't print error when allocating urb fails

This per-subsystem series is part of a tree wide cleanup. usb_alloc_urb() uses
kmalloc which already prints enough information on failure. So, let's simply
remove those "allocation failed" messages from drivers like we did already for
other -ENOMEM cases. gkh acked this approach when we talked about it at LCJ in
Tokyo a few weeks ago.


Wolfram Sang (1):
bluetooth: bcm203x: don't print error when allocating urb fails

drivers/bluetooth/bcm203x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

--
2.8.1

2016-08-24 14:57:04

by Marcel Holtmann

Subject: Re: [PATCH] bluetooth: bcm203x: don't print error when allocating urb fails

Hi Wolfram,

> kmalloc will print enough information in case of failure.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
> drivers/bluetooth/bcm203x.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel

2016-08-11 21:00:31

by Wolfram Sang

Subject: [PATCH] bluetooth: bcm203x: don't print error when allocating urb fails

kmalloc will print enough information in case of failure.

Signed-off-by: Wolfram Sang <[email protected]>
---
drivers/bluetooth/bcm203x.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/bluetooth/bcm203x.c b/drivers/bluetooth/bcm203x.c
index 5b0ef7bbe8ac87..5ce6d4176dc302 100644
--- a/drivers/bluetooth/bcm203x.c
+++ b/drivers/bluetooth/bcm203x.c
@@ -185,10 +185,8 @@ static int bcm203x_probe(struct usb_interface *intf, const struct usb_device_id
data->state = BCM203X_LOAD_MINIDRV;

data->urb = usb_alloc_urb(0, GFP_KERNEL);
- if (!data->urb) {
- BT_ERR("Can't allocate URB");
+ if (!data->urb)
return -ENOMEM;
- }

if (request_firmware(&firmware, "BCM2033-MD.hex", &udev->dev) < 0) {
BT_ERR("Mini driver request failed");
--
2.8.1