From: Tedd Ho-Jeong An <[email protected]>
This adds common debug print functions that print the debug messages
to stderr and it can be toggled with'-d' option in the parameter.
It provides two functions: one for message and the other for data contents.
---
tools/hciattach.8 | 4 ++++
tools/hciattach.c | 36 ++++++++++++++++++++++++++++++++++--
tools/hciattach.h | 3 +++
3 files changed, 41 insertions(+), 2 deletions(-)
diff --git a/tools/hciattach.8 b/tools/hciattach.8
index cc97cad..eccbc61 100644
--- a/tools/hciattach.8
+++ b/tools/hciattach.8
@@ -6,6 +6,7 @@ hciattach \- attach serial devices via UART HCI to BlueZ stack
.RB [\| \-b \|]
.RB [\| \-n \|]
.RB [\| \-p \|]
+.RB [\| \-d \|]
.RB [\| \-t
.IR timeout \|]
.RB [\| \-s
@@ -32,6 +33,9 @@ Don't detach from controlling terminal.
.B \-p
Print the PID when detaching.
.TP
+.B \-d
+Print debug messages to stderr.
+.TP
.BI \-t " timeout"
Specify an initialization timeout. (Default is 5 seconds.)
.TP
diff --git a/tools/hciattach.c b/tools/hciattach.c
index 3e73956..06ae9d6 100644
--- a/tools/hciattach.c
+++ b/tools/hciattach.c
@@ -42,6 +42,7 @@
#include <sys/poll.h>
#include <sys/param.h>
#include <sys/ioctl.h>
+#include <stdarg.h>
#include <bluetooth/bluetooth.h>
#include <bluetooth/hci.h>
@@ -73,6 +74,8 @@ struct uart_t {
static volatile sig_atomic_t __io_canceled = 0;
+static int g_debug;
+
static void sig_hup(int sig)
{
}
@@ -144,6 +147,30 @@ static int uart_speed(int s)
}
}
+void dbg_print(const char *fmt, ...)
+{
+ va_list args;
+ if(g_debug) {
+ fprintf(stderr, "dbg: ");
+ va_start(args, fmt);
+ vfprintf(stderr, fmt, args);
+ va_end(args);
+ fprintf(stderr, "\n");
+ }
+}
+
+void dbg_print_pkt(const char *str, unsigned char *data, int len)
+{
+ int i;
+ if(g_debug) {
+ fprintf(stderr, "dbg: %s", str);
+ for (i = 0; i < len; i++) {
+ fprintf(stderr, "%02x ", data[i]);
+ }
+ fprintf(stderr, "\n");
+ }
+}
+
int set_speed(int fd, struct termios *ti, int speed)
{
if (cfsetospeed(ti, uart_speed(speed)) < 0)
@@ -1260,7 +1287,7 @@ static void usage(void)
{
printf("hciattach - HCI UART driver initialization utility\n");
printf("Usage:\n");
- printf("\thciattach [-n] [-p] [-b] [-r] [-t timeout] [-s initial_speed] <tty> <type | id> [speed] [flow|noflow] [bdaddr]\n");
+ printf("\thciattach [-n] [-p] [-b] [-r] [-d] [-t timeout] [-s initial_speed] <tty> <type | id> [speed] [flow|noflow] [bdaddr]\n");
printf("\thciattach -l\n");
}
@@ -1280,8 +1307,9 @@ int main(int argc, char *argv[])
detach = 1;
printpid = 0;
raw = 0;
+ g_debug = 0;
- while ((opt=getopt(argc, argv, "bnpt:s:lr")) != EOF) {
+ while ((opt=getopt(argc, argv, "bnpdt:s:lr")) != EOF) {
switch(opt) {
case 'b':
send_break = 1;
@@ -1314,6 +1342,10 @@ int main(int argc, char *argv[])
raw = 1;
break;
+ case 'd':
+ g_debug = 1;
+ break;
+
default:
usage();
exit(1);
diff --git a/tools/hciattach.h b/tools/hciattach.h
index a24dbc4..c528f2b 100644
--- a/tools/hciattach.h
+++ b/tools/hciattach.h
@@ -44,6 +44,9 @@
#define HCI_UART_RESET_ON_INIT 1
#define HCI_UART_CREATE_AMP 2
+void dbg_print(const char *fmt, ...);
+void dbg_print_pkt(const char * str, unsigned char * data, int len);
+
int read_hci_event(int fd, unsigned char* buf, int size);
int set_speed(int fd, struct termios *ti, int speed);
--
1.7.9.5
TWFyY2VsLg0KDQpUaGFua3MgZm9yIHRoZSBjb21tZW50cy4gSSBqdXN0IGZpeGVkIHVwIGFuZCBz
ZW50IHRoZSBwYXRjaGVzLg0KQlRXLCBkbyB5b3Ugd2FudCBtZSB0byBydW4gdGhlICJjaGVja3Bh
dGNoIiB3aXRoIGhjaWF0dGFjaC5jIGFuZCBoY2lhdHRhY2guaCB0byBmaXggdGhlIGNvZGluZyBz
dHlsZT8NCkV2ZW4gd2l0aCBteSAicm9va2llIiBleWVzLCBJIGNhbiBzZWUgc29tZSBjb2Rpbmcg
c3R5bGUgaXNzdWUuDQoNCkxldCBtZSBrbm93Lg0KDQpSZWdhcmRzLg0KDQpUZWRkDQoNCj4gLS0t
LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogTWFyY2VsIEhvbHRtYW5uIFttYWlsdG86
bWFyY2VsQGhvbHRtYW5uLm9yZ10NCj4gU2VudDogVHVlc2RheSwgTWF5IDIyLCAyMDEyIDg6MTYg
UE0NCj4gVG86IEFuLCBUZWRkDQo+IENjOiBsaW51eC1ibHVldG9vdGgNCj4gU3ViamVjdDogUmU6
IFtQQVRDSCAxLzNdIGhjaWF0dGFjaDogYWRkIGNvbW1vbiBkZWJ1ZyBwcmludCBmdW5jdGlvbnMg
YW5kDQo+IHRvZ2dsZSBvcHRpb24NCj4gDQo+IEhpIFRlZGQsDQo+IA0KPiA+IFRoaXMgYWRkcyBj
b21tb24gZGVidWcgcHJpbnQgZnVuY3Rpb25zIHRoYXQgcHJpbnQgdGhlIGRlYnVnIG1lc3NhZ2Vz
DQo+ID4gdG8gc3RkZXJyIGFuZCBpdCBjYW4gYmUgdG9nZ2xlZCB3aXRoJy1kJyBvcHRpb24gaW4g
dGhlIHBhcmFtZXRlci4NCj4gPg0KPiA+IEl0IHByb3ZpZGVzIHR3byBmdW5jdGlvbnM6IG9uZSBm
b3IgbWVzc2FnZSBhbmQgdGhlIG90aGVyIGZvciBkYXRhIGNvbnRlbnRzLg0KPiA+DQo+ID4gLS0t
DQo+ID4gIHRvb2xzL2hjaWF0dGFjaC44IHwgICAgNCArKysrDQo+ID4gIHRvb2xzL2hjaWF0dGFj
aC5jIHwgICAzNiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0NCj4gPiAgdG9v
bHMvaGNpYXR0YWNoLmggfCAgICAzICsrKw0KPiA+ICAzIGZpbGVzIGNoYW5nZWQsIDQxIGluc2Vy
dGlvbnMoKyksIDIgZGVsZXRpb25zKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvdG9vbHMvaGNp
YXR0YWNoLjggYi90b29scy9oY2lhdHRhY2guOCBpbmRleA0KPiA+IGNjOTdjYWQuLmVjY2JjNjEg
MTAwNjQ0DQo+ID4gLS0tIGEvdG9vbHMvaGNpYXR0YWNoLjgNCj4gPiArKysgYi90b29scy9oY2lh
dHRhY2guOA0KPiA+IEBAIC02LDYgKzYsNyBAQCBoY2lhdHRhY2ggXC0gYXR0YWNoIHNlcmlhbCBk
ZXZpY2VzIHZpYSBVQVJUIEhDSSB0bw0KPiA+IEJsdWVaIHN0YWNrICAuUkIgW1x8IFwtYiBcfF0g
IC5SQiBbXHwgXC1uIFx8XSAgLlJCIFtcfCBcLXAgXHxdDQo+ID4gKy5SQiBbXHwgXC1kIFx8XQ0K
PiA+ICAuUkIgW1x8IFwtdA0KPiA+ICAuSVIgdGltZW91dCBcfF0NCj4gPiAgLlJCIFtcfCBcLXMN
Cj4gPiBAQCAtMzIsNiArMzMsOSBAQCBEb24ndCBkZXRhY2ggZnJvbSBjb250cm9sbGluZyB0ZXJt
aW5hbC4NCj4gPiAgLkIgXC1wDQo+ID4gIFByaW50IHRoZSBQSUQgd2hlbiBkZXRhY2hpbmcuDQo+
ID4gIC5UUA0KPiA+ICsuQiBcLWQNCj4gPiArUHJpbnQgZGVidWcgbWVzc2FnZXMgdG8gc3RkZXJy
Lg0KPiA+ICsuVFANCj4gPiAgLkJJIFwtdCAiIHRpbWVvdXQiDQo+ID4gIFNwZWNpZnkgYW4gaW5p
dGlhbGl6YXRpb24gdGltZW91dC4gIChEZWZhdWx0IGlzIDUgc2Vjb25kcy4pICAuVFAgZGlmZg0K
PiA+IC0tZ2l0IGEvdG9vbHMvaGNpYXR0YWNoLmMgYi90b29scy9oY2lhdHRhY2guYyBpbmRleCAz
ZTczOTU2Li4wNmFlOWQ2DQo+ID4gMTAwNjQ0DQo+ID4gLS0tIGEvdG9vbHMvaGNpYXR0YWNoLmMN
Cj4gPiArKysgYi90b29scy9oY2lhdHRhY2guYw0KPiA+IEBAIC00Miw2ICs0Miw3IEBADQo+ID4g
ICNpbmNsdWRlIDxzeXMvcG9sbC5oPg0KPiA+ICAjaW5jbHVkZSA8c3lzL3BhcmFtLmg+DQo+ID4g
ICNpbmNsdWRlIDxzeXMvaW9jdGwuaD4NCj4gPiArI2luY2x1ZGUgPHN0ZGFyZy5oPg0KPiA+DQo+
ID4gICNpbmNsdWRlIDxibHVldG9vdGgvYmx1ZXRvb3RoLmg+DQo+ID4gICNpbmNsdWRlIDxibHVl
dG9vdGgvaGNpLmg+DQo+ID4gQEAgLTczLDYgKzc0LDggQEAgc3RydWN0IHVhcnRfdCB7DQo+ID4N
Cj4gPiAgc3RhdGljIHZvbGF0aWxlIHNpZ19hdG9taWNfdCBfX2lvX2NhbmNlbGVkID0gMDsNCj4g
Pg0KPiA+ICtzdGF0aWMgaW50IGdfZGVidWc7DQo+ID4gKw0KPiA+ICBzdGF0aWMgdm9pZCBzaWdf
aHVwKGludCBzaWcpDQo+ID4gIHsNCj4gPiAgfQ0KPiA+IEBAIC0xNDQsNiArMTQ3LDMwIEBAIHN0
YXRpYyBpbnQgdWFydF9zcGVlZChpbnQgcykNCj4gPiAgCX0NCj4gPiAgfQ0KPiA+DQo+ID4gK3Zv
aWQgZGJnX3ByaW50KGNvbnN0IGNoYXIgKmZtdCwgLi4uKQ0KPiA+ICt7DQo+ID4gKwl2YV9saXN0
IGFyZ3M7DQo+IA0KPiBleHRyYSBlbXB0eSBsaW5lIGJldHdlZW4gdmFyaWFibGVzIGFuZCBjb2Rl
IHBsZWFzZS4NCj4gDQo+ID4gKwlpZihnX2RlYnVnKSB7DQo+IA0KPiBFeHRyYSBzcGFjZSBhZnRl
ciBpZiBhbmQgYmVmb3JlICguDQo+IA0KPiA+ICsJCWZwcmludGYoc3RkZXJyLCAiZGJnOiAiKTsN
Cj4gPiArCQl2YV9zdGFydChhcmdzLCBmbXQpOw0KPiA+ICsJCXZmcHJpbnRmKHN0ZGVyciwgZm10
LCBhcmdzKTsNCj4gPiArCQl2YV9lbmQoYXJncyk7DQo+ID4gKwkJZnByaW50ZihzdGRlcnIsICJc
biIpOw0KPiA+ICsJfQ0KPiA+ICt9DQo+ID4gKw0KPiA+ICt2b2lkIGRiZ19wcmludF9wa3QoY29u
c3QgY2hhciAqc3RyLCB1bnNpZ25lZCBjaGFyICpkYXRhLCBpbnQgbGVuKSB7DQo+ID4gKwlpbnQg
aTsNCj4gDQo+IFNhbWUgaGVyZS4NCj4gDQo+ID4gKwlpZihnX2RlYnVnKSB7DQo+IA0KPiBBbmQg
aGVyZS4NCj4gDQo+ID4gKwkJZnByaW50ZihzdGRlcnIsICJkYmc6ICVzIiwgc3RyKTsNCj4gPiAr
CQlmb3IgKGkgPSAwOyBpIDwgbGVuOyBpKyspIHsNCj4gPiArCQkJZnByaW50ZihzdGRlcnIsICIl
MDJ4ICIsIGRhdGFbaV0pOw0KPiA+ICsJCX0NCj4gDQo+IE5vIHsgfSBuZWVkZWQgZm9yIHNpbmds
ZSBzdGF0ZW1lbnRzLg0KPiANCj4gPiArCQlmcHJpbnRmKHN0ZGVyciwgIlxuIik7DQo+ID4gKwl9
DQo+ID4gK30NCj4gPiArDQo+ID4gIGludCBzZXRfc3BlZWQoaW50IGZkLCBzdHJ1Y3QgdGVybWlv
cyAqdGksIGludCBzcGVlZCkgIHsNCj4gPiAgCWlmIChjZnNldG9zcGVlZCh0aSwgdWFydF9zcGVl
ZChzcGVlZCkpIDwgMCkgQEAgLTEyNjAsNyArMTI4Nyw3IEBADQo+ID4gc3RhdGljIHZvaWQgdXNh
Z2Uodm9pZCkgIHsNCj4gPiAgCXByaW50ZigiaGNpYXR0YWNoIC0gSENJIFVBUlQgZHJpdmVyIGlu
aXRpYWxpemF0aW9uIHV0aWxpdHlcbiIpOw0KPiA+ICAJcHJpbnRmKCJVc2FnZTpcbiIpOw0KPiA+
IC0JcHJpbnRmKCJcdGhjaWF0dGFjaCBbLW5dIFstcF0gWy1iXSBbLXJdIFstdCB0aW1lb3V0XSBb
LXMgaW5pdGlhbF9zcGVlZF0NCj4gPHR0eT4gPHR5cGUgfCBpZD4gW3NwZWVkXSBbZmxvd3xub2Zs
b3ddIFtiZGFkZHJdXG4iKTsNCj4gPiArCXByaW50ZigiXHRoY2lhdHRhY2ggWy1uXSBbLXBdIFst
Yl0gWy1yXSBbLWRdIFstdCB0aW1lb3V0XSBbLXMNCj4gPiAraW5pdGlhbF9zcGVlZF0gPHR0eT4g
PHR5cGUgfCBpZD4gW3NwZWVkXSBbZmxvd3xub2Zsb3ddIFtiZGFkZHJdXG4iKTsNCj4gPiAgCXBy
aW50ZigiXHRoY2lhdHRhY2ggLWxcbiIpOw0KPiA+ICB9DQo+ID4NCj4gPiBAQCAtMTI4MCw4ICsx
MzA3LDkgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkNCj4gPiAgCWRldGFjaCA9
IDE7DQo+ID4gIAlwcmludHBpZCA9IDA7DQo+ID4gIAlyYXcgPSAwOw0KPiA+ICsJZ19kZWJ1ZyA9
IDA7DQo+IA0KPiBJIHJhdGhlciBoYXZlIHlvdSBub3Qgc3RhcnQgd2l0aCBnXyBmb3IgZ2xvYmFs
IHNlbWFudGljLiBXZSBoYXZlIG5vdCBiZWVuDQo+IHVzaW5nIGl0LCBzbyBzdGFydGluZyBpdCBu
b3cgaXMgbWFraW5nIGl0IGNvbmZ1c2luZy4NCj4gDQo+ID4NCj4gPiAtCXdoaWxlICgob3B0PWdl
dG9wdChhcmdjLCBhcmd2LCAiYm5wdDpzOmxyIikpICE9IEVPRikgew0KPiA+ICsJd2hpbGUgKChv
cHQ9Z2V0b3B0KGFyZ2MsIGFyZ3YsICJibnBkdDpzOmxyIikpICE9IEVPRikgew0KPiA+ICAJCXN3
aXRjaChvcHQpIHsNCj4gPiAgCQljYXNlICdiJzoNCj4gPiAgCQkJc2VuZF9icmVhayA9IDE7DQo+
ID4gQEAgLTEzMTQsNiArMTM0MiwxMCBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltd
KQ0KPiA+ICAJCQlyYXcgPSAxOw0KPiA+ICAJCQlicmVhazsNCj4gPg0KPiA+ICsJCWNhc2UgJ2Qn
Og0KPiA+ICsJCQlnX2RlYnVnID0gMTsNCj4gPiArCQkJYnJlYWs7DQo+ID4gKw0KPiA+ICAJCWRl
ZmF1bHQ6DQo+ID4gIAkJCXVzYWdlKCk7DQo+ID4gIAkJCWV4aXQoMSk7DQo+ID4gZGlmZiAtLWdp
dCBhL3Rvb2xzL2hjaWF0dGFjaC5oIGIvdG9vbHMvaGNpYXR0YWNoLmggaW5kZXgNCj4gPiBhMjRk
YmM0Li5jNTI4ZjJiIDEwMDY0NA0KPiA+IC0tLSBhL3Rvb2xzL2hjaWF0dGFjaC5oDQo+ID4gKysr
IGIvdG9vbHMvaGNpYXR0YWNoLmgNCj4gPiBAQCAtNDQsNiArNDQsOSBAQA0KPiA+ICAjZGVmaW5l
IEhDSV9VQVJUX1JFU0VUX09OX0lOSVQJMQ0KPiA+ICAjZGVmaW5lIEhDSV9VQVJUX0NSRUFURV9B
TVAJMg0KPiA+DQo+ID4gK3ZvaWQgZGJnX3ByaW50KGNvbnN0IGNoYXIgKmZtdCwgLi4uKTsgdm9p
ZCBkYmdfcHJpbnRfcGt0KGNvbnN0IGNoYXIgKg0KPiA+ICtzdHIsIHVuc2lnbmVkIGNoYXIgKiBk
YXRhLCBpbnQgbGVuKTsNCj4gDQo+IGl0IGlzIGNoYXIgKnN0ciBoZXJlLiBObyBleHRyYSBzcGFj
ZS4NCj4gDQo+ID4gKw0KPiA+ICBpbnQgcmVhZF9oY2lfZXZlbnQoaW50IGZkLCB1bnNpZ25lZCBj
aGFyKiBidWYsIGludCBzaXplKTsNCj4gDQo+IEFuZCBjbGVhcmx5IG5vdCB5b3VyIGZhdWx0LCB0
aGlzIG9uZSBpcyB3cm9uZyBhcyB3ZWxsLiBUaGUgaGNpYXR0YWNoIGlzIGEgcG9zdGVyDQo+IGNo
aWxkIG9mIGJhZCBjb2Rpbmcgc3R5bGUuIFRpbWUgdG8gY2xlYW4gdGhhdCB1cCBhIGxpdHRsZSBi
aXQgOykNCj4gDQo+ID4gIGludCBzZXRfc3BlZWQoaW50IGZkLCBzdHJ1Y3QgdGVybWlvcyAqdGks
IGludCBzcGVlZCk7DQo+ID4NCj4gDQo+IFJlZ2FyZHMNCj4gDQo+IE1hcmNlbA0KPiANCg0K
Hi Tedd,
> This adds common debug print functions that print the debug messages
> to stderr and it can be toggled with'-d' option in the parameter.
>
> It provides two functions: one for message and the other for data contents.
>
> ---
> tools/hciattach.8 | 4 ++++
> tools/hciattach.c | 36 ++++++++++++++++++++++++++++++++++--
> tools/hciattach.h | 3 +++
> 3 files changed, 41 insertions(+), 2 deletions(-)
>
> diff --git a/tools/hciattach.8 b/tools/hciattach.8
> index cc97cad..eccbc61 100644
> --- a/tools/hciattach.8
> +++ b/tools/hciattach.8
> @@ -6,6 +6,7 @@ hciattach \- attach serial devices via UART HCI to BlueZ stack
> .RB [\| \-b \|]
> .RB [\| \-n \|]
> .RB [\| \-p \|]
> +.RB [\| \-d \|]
> .RB [\| \-t
> .IR timeout \|]
> .RB [\| \-s
> @@ -32,6 +33,9 @@ Don't detach from controlling terminal.
> .B \-p
> Print the PID when detaching.
> .TP
> +.B \-d
> +Print debug messages to stderr.
> +.TP
> .BI \-t " timeout"
> Specify an initialization timeout. (Default is 5 seconds.)
> .TP
> diff --git a/tools/hciattach.c b/tools/hciattach.c
> index 3e73956..06ae9d6 100644
> --- a/tools/hciattach.c
> +++ b/tools/hciattach.c
> @@ -42,6 +42,7 @@
> #include <sys/poll.h>
> #include <sys/param.h>
> #include <sys/ioctl.h>
> +#include <stdarg.h>
>
> #include <bluetooth/bluetooth.h>
> #include <bluetooth/hci.h>
> @@ -73,6 +74,8 @@ struct uart_t {
>
> static volatile sig_atomic_t __io_canceled = 0;
>
> +static int g_debug;
> +
> static void sig_hup(int sig)
> {
> }
> @@ -144,6 +147,30 @@ static int uart_speed(int s)
> }
> }
>
> +void dbg_print(const char *fmt, ...)
> +{
> + va_list args;
extra empty line between variables and code please.
> + if(g_debug) {
Extra space after if and before (.
> + fprintf(stderr, "dbg: ");
> + va_start(args, fmt);
> + vfprintf(stderr, fmt, args);
> + va_end(args);
> + fprintf(stderr, "\n");
> + }
> +}
> +
> +void dbg_print_pkt(const char *str, unsigned char *data, int len)
> +{
> + int i;
Same here.
> + if(g_debug) {
And here.
> + fprintf(stderr, "dbg: %s", str);
> + for (i = 0; i < len; i++) {
> + fprintf(stderr, "%02x ", data[i]);
> + }
No { } needed for single statements.
> + fprintf(stderr, "\n");
> + }
> +}
> +
> int set_speed(int fd, struct termios *ti, int speed)
> {
> if (cfsetospeed(ti, uart_speed(speed)) < 0)
> @@ -1260,7 +1287,7 @@ static void usage(void)
> {
> printf("hciattach - HCI UART driver initialization utility\n");
> printf("Usage:\n");
> - printf("\thciattach [-n] [-p] [-b] [-r] [-t timeout] [-s initial_speed] <tty> <type | id> [speed] [flow|noflow] [bdaddr]\n");
> + printf("\thciattach [-n] [-p] [-b] [-r] [-d] [-t timeout] [-s initial_speed] <tty> <type | id> [speed] [flow|noflow] [bdaddr]\n");
> printf("\thciattach -l\n");
> }
>
> @@ -1280,8 +1307,9 @@ int main(int argc, char *argv[])
> detach = 1;
> printpid = 0;
> raw = 0;
> + g_debug = 0;
I rather have you not start with g_ for global semantic. We have not
been using it, so starting it now is making it confusing.
>
> - while ((opt=getopt(argc, argv, "bnpt:s:lr")) != EOF) {
> + while ((opt=getopt(argc, argv, "bnpdt:s:lr")) != EOF) {
> switch(opt) {
> case 'b':
> send_break = 1;
> @@ -1314,6 +1342,10 @@ int main(int argc, char *argv[])
> raw = 1;
> break;
>
> + case 'd':
> + g_debug = 1;
> + break;
> +
> default:
> usage();
> exit(1);
> diff --git a/tools/hciattach.h b/tools/hciattach.h
> index a24dbc4..c528f2b 100644
> --- a/tools/hciattach.h
> +++ b/tools/hciattach.h
> @@ -44,6 +44,9 @@
> #define HCI_UART_RESET_ON_INIT 1
> #define HCI_UART_CREATE_AMP 2
>
> +void dbg_print(const char *fmt, ...);
> +void dbg_print_pkt(const char * str, unsigned char * data, int len);
it is char *str here. No extra space.
> +
> int read_hci_event(int fd, unsigned char* buf, int size);
And clearly not your fault, this one is wrong as well. The hciattach is
a poster child of bad coding style. Time to clean that up a little
bit ;)
> int set_speed(int fd, struct termios *ti, int speed);
>
Regards
Marcel