2017-04-28 11:26:11

by Frédéric Danis

[permalink] [raw]
Subject: [PATCH] Bluetooth: Add module license for HCI UART Nokia H4+

Fix the following error preventing to load Nokia H4+ module:
kernel: [ 826.461619] hci_nokia: module license 'unspecified' taints kernel.
kernel: [ 826.461629] Disabling lock debugging due to kernel taint
kernel: [ 826.461836] hci_nokia: Unknown symbol gpiod_get_value_cansleep (err 0)
kernel: [ 826.461876] hci_nokia: Unknown symbol devm_kmalloc (err 0)
kernel: [ 826.461908] hci_nokia: Unknown symbol gpiod_set_value (err 0)
kernel: [ 826.461937] hci_nokia: Unknown symbol serdev_device_set_baudrate (err 0)
kernel: [ 826.461994] hci_nokia: Unknown symbol gpiod_set_value_cansleep (err 0)
kernel: [ 826.462021] hci_nokia: Unknown symbol hci_uart_tx_wakeup (err 0)
kernel: [ 826.462043] hci_nokia: Unknown symbol serdev_device_set_flow_control (err 0)
kernel: [ 826.462064] hci_nokia: Unknown symbol gpiod_to_irq (err 0)
kernel: [ 826.462085] hci_nokia: Unknown symbol serdev_device_open (err 0)
kernel: [ 826.462106] hci_nokia: Unknown symbol gpiod_get_value (err 0)
kernel: [ 826.462150] hci_nokia: Unknown symbol clk_prepare (err 0)
kernel: [ 826.462182] hci_nokia: Unknown symbol pm_runtime_enable (err 0)
kernel: [ 826.462204] hci_nokia: Unknown symbol h4_recv_buf (err 0)
kernel: [ 826.462246] hci_nokia: Unknown symbol serdev_device_write_flush (err 0)
kernel: [ 826.462268] hci_nokia: Unknown symbol serdev_device_get_tiocm (err 0)
kernel: [ 826.462298] hci_nokia: Unknown symbol driver_unregister (err 0)
kernel: [ 826.462318] hci_nokia: Unknown symbol serdev_device_wait_until_sent (err 0)
kernel: [ 826.462347] hci_nokia: Unknown symbol __serdev_device_driver_register (err 0)
kernel: [ 826.462384] hci_nokia: Unknown symbol serdev_device_set_tiocm (err 0)
kernel: [ 826.462417] hci_nokia: Unknown symbol clk_get_rate (err 0)
kernel: [ 826.462454] hci_nokia: Unknown symbol __pm_runtime_resume (err 0)
kernel: [ 826.462486] hci_nokia: Unknown symbol serdev_device_close (err 0)
kernel: [ 826.462524] hci_nokia: Unknown symbol cancel_work_sync (err 0)
kernel: [ 826.462546] hci_nokia: Unknown symbol btbcm_set_bdaddr (err 0)
kernel: [ 826.462567] hci_nokia: Unknown symbol clk_disable (err 0)
kernel: [ 826.462610] hci_nokia: Unknown symbol __pm_runtime_disable (err 0)
kernel: [ 826.462632] hci_nokia: Unknown symbol hci_uart_register_device (err 0)
kernel: [ 826.462653] hci_nokia: Unknown symbol clk_enable (err 0)
kernel: [ 826.462675] hci_nokia: Unknown symbol __pm_runtime_idle (err 0)
kernel: [ 826.462700] hci_nokia: Unknown symbol clk_unprepare (err 0)

Signed-off-by: Frédéric Danis <[email protected]>
---
drivers/bluetooth/hci_nokia.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c
index 4038daf..c563f3c 100644
--- a/drivers/bluetooth/hci_nokia.c
+++ b/drivers/bluetooth/hci_nokia.c
@@ -36,6 +36,8 @@
#include "hci_uart.h"
#include "btbcm.h"

+#define VERSION "0.1"
+
#define NOKIA_ID_BCM2048 0x04
#define NOKIA_ID_TI1271 0x31

@@ -818,3 +820,8 @@ static struct serdev_device_driver nokia_bluetooth_serdev_driver = {
};

module_serdev_device_driver(nokia_bluetooth_serdev_driver);
+
+MODULE_AUTHOR("Sebastian Reichel <[email protected]>-");
+MODULE_DESCRIPTION("Bluetooth HCI UART Nokia H4+ driver ver " VERSION);
+MODULE_VERSION(VERSION);
+MODULE_LICENSE("GPL");
--
2.7.4



2017-04-28 16:06:36

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Add module license for HCI UART Nokia H4+

Hi Fred,

> Fix the following error preventing to load Nokia H4+ module:
> kernel: [ 826.461619] hci_nokia: module license 'unspecified' taints kernel.
> kernel: [ 826.461629] Disabling lock debugging due to kernel taint
> kernel: [ 826.461836] hci_nokia: Unknown symbol gpiod_get_value_cansleep (err 0)
> kernel: [ 826.461876] hci_nokia: Unknown symbol devm_kmalloc (err 0)
> kernel: [ 826.461908] hci_nokia: Unknown symbol gpiod_set_value (err 0)
> kernel: [ 826.461937] hci_nokia: Unknown symbol serdev_device_set_baudrate (err 0)
> kernel: [ 826.461994] hci_nokia: Unknown symbol gpiod_set_value_cansleep (err 0)
> kernel: [ 826.462021] hci_nokia: Unknown symbol hci_uart_tx_wakeup (err 0)
> kernel: [ 826.462043] hci_nokia: Unknown symbol serdev_device_set_flow_control (err 0)
> kernel: [ 826.462064] hci_nokia: Unknown symbol gpiod_to_irq (err 0)
> kernel: [ 826.462085] hci_nokia: Unknown symbol serdev_device_open (err 0)
> kernel: [ 826.462106] hci_nokia: Unknown symbol gpiod_get_value (err 0)
> kernel: [ 826.462150] hci_nokia: Unknown symbol clk_prepare (err 0)
> kernel: [ 826.462182] hci_nokia: Unknown symbol pm_runtime_enable (err 0)
> kernel: [ 826.462204] hci_nokia: Unknown symbol h4_recv_buf (err 0)
> kernel: [ 826.462246] hci_nokia: Unknown symbol serdev_device_write_flush (err 0)
> kernel: [ 826.462268] hci_nokia: Unknown symbol serdev_device_get_tiocm (err 0)
> kernel: [ 826.462298] hci_nokia: Unknown symbol driver_unregister (err 0)
> kernel: [ 826.462318] hci_nokia: Unknown symbol serdev_device_wait_until_sent (err 0)
> kernel: [ 826.462347] hci_nokia: Unknown symbol __serdev_device_driver_register (err 0)
> kernel: [ 826.462384] hci_nokia: Unknown symbol serdev_device_set_tiocm (err 0)
> kernel: [ 826.462417] hci_nokia: Unknown symbol clk_get_rate (err 0)
> kernel: [ 826.462454] hci_nokia: Unknown symbol __pm_runtime_resume (err 0)
> kernel: [ 826.462486] hci_nokia: Unknown symbol serdev_device_close (err 0)
> kernel: [ 826.462524] hci_nokia: Unknown symbol cancel_work_sync (err 0)
> kernel: [ 826.462546] hci_nokia: Unknown symbol btbcm_set_bdaddr (err 0)
> kernel: [ 826.462567] hci_nokia: Unknown symbol clk_disable (err 0)
> kernel: [ 826.462610] hci_nokia: Unknown symbol __pm_runtime_disable (err 0)
> kernel: [ 826.462632] hci_nokia: Unknown symbol hci_uart_register_device (err 0)
> kernel: [ 826.462653] hci_nokia: Unknown symbol clk_enable (err 0)
> kernel: [ 826.462675] hci_nokia: Unknown symbol __pm_runtime_idle (err 0)
> kernel: [ 826.462700] hci_nokia: Unknown symbol clk_unprepare (err 0)
>
> Signed-off-by: Frédéric Danis <[email protected]>
> ---
> drivers/bluetooth/hci_nokia.c | 7 +++++++
> 1 file changed, 7 insertions(+)

patch has been applied to bluetooth-next tree.

Regards

Marcel


2017-04-28 11:44:49

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Add module license for HCI UART Nokia H4+

Hi,

On Fri, Apr 28, 2017 at 01:26:11PM +0200, Fr?d?ric Danis wrote:
> Fix the following error preventing to load Nokia H4+ module:
> kernel: [ 826.461619] hci_nokia: module license 'unspecified' taints kernel.
> kernel: [ 826.461629] Disabling lock debugging due to kernel taint
> kernel: [ 826.461836] hci_nokia: Unknown symbol gpiod_get_value_cansleep (err 0)
> kernel: [ 826.461876] hci_nokia: Unknown symbol devm_kmalloc (err 0)
> kernel: [ 826.461908] hci_nokia: Unknown symbol gpiod_set_value (err 0)
> kernel: [ 826.461937] hci_nokia: Unknown symbol serdev_device_set_baudrate (err 0)
> kernel: [ 826.461994] hci_nokia: Unknown symbol gpiod_set_value_cansleep (err 0)
> kernel: [ 826.462021] hci_nokia: Unknown symbol hci_uart_tx_wakeup (err 0)
> kernel: [ 826.462043] hci_nokia: Unknown symbol serdev_device_set_flow_control (err 0)
> kernel: [ 826.462064] hci_nokia: Unknown symbol gpiod_to_irq (err 0)
> kernel: [ 826.462085] hci_nokia: Unknown symbol serdev_device_open (err 0)
> kernel: [ 826.462106] hci_nokia: Unknown symbol gpiod_get_value (err 0)
> kernel: [ 826.462150] hci_nokia: Unknown symbol clk_prepare (err 0)
> kernel: [ 826.462182] hci_nokia: Unknown symbol pm_runtime_enable (err 0)
> kernel: [ 826.462204] hci_nokia: Unknown symbol h4_recv_buf (err 0)
> kernel: [ 826.462246] hci_nokia: Unknown symbol serdev_device_write_flush (err 0)
> kernel: [ 826.462268] hci_nokia: Unknown symbol serdev_device_get_tiocm (err 0)
> kernel: [ 826.462298] hci_nokia: Unknown symbol driver_unregister (err 0)
> kernel: [ 826.462318] hci_nokia: Unknown symbol serdev_device_wait_until_sent (err 0)
> kernel: [ 826.462347] hci_nokia: Unknown symbol __serdev_device_driver_register (err 0)
> kernel: [ 826.462384] hci_nokia: Unknown symbol serdev_device_set_tiocm (err 0)
> kernel: [ 826.462417] hci_nokia: Unknown symbol clk_get_rate (err 0)
> kernel: [ 826.462454] hci_nokia: Unknown symbol __pm_runtime_resume (err 0)
> kernel: [ 826.462486] hci_nokia: Unknown symbol serdev_device_close (err 0)
> kernel: [ 826.462524] hci_nokia: Unknown symbol cancel_work_sync (err 0)
> kernel: [ 826.462546] hci_nokia: Unknown symbol btbcm_set_bdaddr (err 0)
> kernel: [ 826.462567] hci_nokia: Unknown symbol clk_disable (err 0)
> kernel: [ 826.462610] hci_nokia: Unknown symbol __pm_runtime_disable (err 0)
> kernel: [ 826.462632] hci_nokia: Unknown symbol hci_uart_register_device (err 0)
> kernel: [ 826.462653] hci_nokia: Unknown symbol clk_enable (err 0)
> kernel: [ 826.462675] hci_nokia: Unknown symbol __pm_runtime_idle (err 0)
> kernel: [ 826.462700] hci_nokia: Unknown symbol clk_unprepare (err 0)
>
> Signed-off-by: Fr?d?ric Danis <[email protected]>
> ---
> drivers/bluetooth/hci_nokia.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/bluetooth/hci_nokia.c b/drivers/bluetooth/hci_nokia.c
> index 4038daf..c563f3c 100644
> --- a/drivers/bluetooth/hci_nokia.c
> +++ b/drivers/bluetooth/hci_nokia.c
> @@ -36,6 +36,8 @@
> #include "hci_uart.h"
> #include "btbcm.h"
>
> +#define VERSION "0.1"
> +
> #define NOKIA_ID_BCM2048 0x04
> #define NOKIA_ID_TI1271 0x31
>
> @@ -818,3 +820,8 @@ static struct serdev_device_driver nokia_bluetooth_serdev_driver = {
> };
>
> module_serdev_device_driver(nokia_bluetooth_serdev_driver);
> +
> +MODULE_AUTHOR("Sebastian Reichel <[email protected]>-");

There is a superfluous - at end of string.

> +MODULE_DESCRIPTION("Bluetooth HCI UART Nokia H4+ driver ver " VERSION);
> +MODULE_VERSION(VERSION);
> +MODULE_LICENSE("GPL");

Otherwise:

Acked-by: Sebastian Reichel <[email protected]>

-- Sebastian

Attachments:
(No filename) (3.60 kB)
 signature.asc (833.00 B)
 Download all attachments