2017-05-23 09:51:00

by Loic Poulain

Subject: [PATCH] Bluetooth: btwilink: Fix unexpected skb free

The caller (hci_core) still owns the skb in case of error, releasing
it inside the send function can lead to use-after-free errors.

Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Loic Poulain <[email protected]>
---
drivers/bluetooth/btwilink.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/bluetooth/btwilink.c b/drivers/bluetooth/btwilink.c
index b6bb58c..85a3978 100644
--- a/drivers/bluetooth/btwilink.c
+++ b/drivers/bluetooth/btwilink.c
@@ -262,7 +262,6 @@ static int ti_st_send_frame(struct hci_dev *hdev, struct sk_buff *skb)
pkt_type = hci_skb_pkt_type(skb);
len = hst->st_write(skb);
if (len < 0) {
- kfree_skb(skb);
BT_ERR("ST write failed (%ld)", len);
/* Try Again, would only fail if UART has gone bad */
return -EAGAIN;
--
1.9.1

2017-05-23 14:21:42

by Marcel Holtmann

Subject: Re: [PATCH] Bluetooth: btwilink: Fix unexpected skb free

Hi Loic,

> The caller (hci_core) still owns the skb in case of error, releasing
> it inside the send function can lead to use-after-free errors.
>
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Loic Poulain <[email protected]>
> ---
> drivers/bluetooth/btwilink.c | 1 -
> 1 file changed, 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel