Converted Qualcomm Bluetooth binidings to DT schema.
Signed-off-by: Venkata Lakshmi Narayana Gubba <[email protected]>
---
.../devicetree/bindings/net/qualcomm-bluetooth.txt | 69 -------------
.../bindings/net/qualcomm-bluetooth.yaml | 111 +++++++++++++++++++++
2 files changed, 111 insertions(+), 69 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
create mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
deleted file mode 100644
index 709ca6d..0000000
--- a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
+++ /dev/null
@@ -1,69 +0,0 @@
-Qualcomm Bluetooth Chips
----------------------
-
-This documents the binding structure and common properties for serial
-attached Qualcomm devices.
-
-Serial attached Qualcomm devices shall be a child node of the host UART
-device the slave device is attached to.
-
-Required properties:
- - compatible: should contain one of the following:
- * "qcom,qca6174-bt"
- * "qcom,qca9377-bt"
- * "qcom,wcn3990-bt"
- * "qcom,wcn3991-bt"
- * "qcom,wcn3998-bt"
- * "qcom,qca6390-bt"
-
-Optional properties for compatible string qcom,qca6174-bt:
-
- - enable-gpios: gpio specifier used to enable chip
- - clocks: clock provided to the controller (SUSCLK_32KHZ)
- - firmware-name: specify the name of nvm firmware to load
-
-Optional properties for compatible string qcom,qca9377-bt:
-
- - max-speed: see Documentation/devicetree/bindings/serial/serial.yaml
-
-Required properties for compatible string qcom,wcn399x-bt:
-
- - vddio-supply: VDD_IO supply regulator handle.
- - vddxo-supply: VDD_XO supply regulator handle.
- - vddrf-supply: VDD_RF supply regulator handle.
- - vddch0-supply: VDD_CH0 supply regulator handle.
-
-Optional properties for compatible string qcom,wcn399x-bt:
-
- - max-speed: see Documentation/devicetree/bindings/serial/serial.yaml
- - firmware-name: specify the name of nvm firmware to load
- - clocks: clock provided to the controller
-
-Examples:
-
-serial@7570000 {
- label = "BT-UART";
- status = "okay";
-
- bluetooth {
- compatible = "qcom,qca6174-bt";
-
- enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
- clocks = <&divclk4>;
- firmware-name = "nvm_00440302.bin";
- };
-};
-
-serial@898000 {
- bluetooth {
- compatible = "qcom,wcn3990-bt";
-
- vddio-supply = <&vreg_s4a_1p8>;
- vddxo-supply = <&vreg_l7a_1p8>;
- vddrf-supply = <&vreg_l17a_1p3>;
- vddch0-supply = <&vreg_l25a_3p3>;
- max-speed = <3200000>;
- firmware-name = "crnv21.bin";
- clocks = <&rpmhcc RPMH_RF_CLK2>;
- };
-};
diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
new file mode 100644
index 0000000..3f3ec4d
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
@@ -0,0 +1,111 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/qualcomm-bluetooth.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Bluetooth Chips
+
+maintainers:
+ - Marcel Holtmann <[email protected]>
+
+description:
+ This binding describes Qualcomm UART-attached bluetooth chips.
+
+properties:
+ compatible:
+ enum:
+ - qcom,qca6174-bt
+ - qcom,qca9377-bt
+ - qcom,wcn3990-bt
+ - qcom,wcn3991-bt
+ - qcom,wcn3998-bt
+ - qcom,qca6390-bt
+
+ enable-gpios:
+ maxItems: 1
+ description: gpio specifier used to enable chip
+
+ clocks:
+ maxItems: 1
+ description: clock provided to the controller (SUSCLK_32KHZ)
+
+ vddio-supply:
+ description: VDD_IO supply regulator handle
+
+ vddxo-supply:
+ description: VDD_XO supply regulator handle
+
+ vddrf-supply:
+ description: VDD_RF supply regulator handle
+
+ vddch0-supply:
+ description: VDD_CH0 supply regulator handle
+
+ max-speed:
+ description: see Documentation/devicetree/bindings/serial/serial.yaml
+
+ firmware-name:
+ description: specify the name of nvm firmware to load
+
+ local-bd-address:
+ description: see Documentation/devicetree/bindings/net/bluetooth.txt
+
+
+required:
+ - compatible
+
+additionalProperties: false
+
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,qca6174-bt
+ then:
+ required:
+ - enable-gpios
+ - clocks
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,wcn3990-bt
+ - qcom,wcn3991-bt
+ - qcom,wcn3998-bt
+ then:
+ required:
+ - vddio-supply
+ - vddxo-supply
+ - vddrf-supply
+ - vddch0-supply
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+ serial {
+
+ bluetooth {
+ compatible = "qcom,qca6174-bt";
+ enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
+ clocks = <&divclk4>;
+ firmware-name = "nvm_00440302.bin";
+ };
+ };
+ - |
+ serial {
+
+ bluetooth {
+ compatible = "qcom,wcn3990-bt";
+ vddio-supply = <&vreg_s4a_1p8>;
+ vddxo-supply = <&vreg_l7a_1p8>;
+ vddrf-supply = <&vreg_l17a_1p3>;
+ vddch0-supply = <&vreg_l25a_3p3>;
+ max-speed = <3200000>;
+ firmware-name = "crnv21.bin";
+ };
+ };
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
On Thu, May 06, 2021 at 11:03:11PM +0530, Venkata Lakshmi Narayana Gubba wrote:
> Converted Qualcomm Bluetooth binidings to DT schema.
>
> Signed-off-by: Venkata Lakshmi Narayana Gubba <[email protected]>
> ---
> .../devicetree/bindings/net/qualcomm-bluetooth.txt | 69 -------------
> .../bindings/net/qualcomm-bluetooth.yaml | 111 +++++++++++++++++++++
> 2 files changed, 111 insertions(+), 69 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
> create mode 100644 Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> diff --git a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> new file mode 100644
> index 0000000..3f3ec4d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
> @@ -0,0 +1,111 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/qualcomm-bluetooth.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Bluetooth Chips
> +
> +maintainers:
> + - Marcel Holtmann <[email protected]>
This should be someone who cares about Qcom BT.
Otherwise,
Reviewed-by: Rob Herring <[email protected]>
> +
> +description:
> + This binding describes Qualcomm UART-attached bluetooth chips.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,qca6174-bt
> + - qcom,qca9377-bt
> + - qcom,wcn3990-bt
> + - qcom,wcn3991-bt
> + - qcom,wcn3998-bt
> + - qcom,qca6390-bt
> +
> + enable-gpios:
> + maxItems: 1
> + description: gpio specifier used to enable chip
> +
> + clocks:
> + maxItems: 1
> + description: clock provided to the controller (SUSCLK_32KHZ)
> +
> + vddio-supply:
> + description: VDD_IO supply regulator handle
> +
> + vddxo-supply:
> + description: VDD_XO supply regulator handle
> +
> + vddrf-supply:
> + description: VDD_RF supply regulator handle
> +
> + vddch0-supply:
> + description: VDD_CH0 supply regulator handle
> +
> + max-speed:
> + description: see Documentation/devicetree/bindings/serial/serial.yaml
> +
> + firmware-name:
> + description: specify the name of nvm firmware to load
> +
> + local-bd-address:
> + description: see Documentation/devicetree/bindings/net/bluetooth.txt
> +
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,qca6174-bt
> + then:
> + required:
> + - enable-gpios
> + - clocks
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,wcn3990-bt
> + - qcom,wcn3991-bt
> + - qcom,wcn3998-bt
> + then:
> + required:
> + - vddio-supply
> + - vddxo-supply
> + - vddrf-supply
> + - vddch0-supply
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> + serial {
> +
> + bluetooth {
> + compatible = "qcom,qca6174-bt";
> + enable-gpios = <&pm8994_gpios 19 GPIO_ACTIVE_HIGH>;
> + clocks = <&divclk4>;
> + firmware-name = "nvm_00440302.bin";
> + };
> + };
> + - |
> + serial {
> +
> + bluetooth {
> + compatible = "qcom,wcn3990-bt";
> + vddio-supply = <&vreg_s4a_1p8>;
> + vddxo-supply = <&vreg_l7a_1p8>;
> + vddrf-supply = <&vreg_l17a_1p3>;
> + vddch0-supply = <&vreg_l25a_3p3>;
> + max-speed = <3200000>;
> + firmware-name = "crnv21.bin";
> + };
> + };
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>
Hi Marcel and Rob,
On 2021-05-13 20:51, Marcel Holtmann wrote:
> Hi Rob,
>
>>>>> Converted Qualcomm Bluetooth binidings to DT schema.
>>>>>
>>>>> Signed-off-by: Venkata Lakshmi Narayana Gubba
>>>>> <[email protected]>
>>>>> ---
>>>>> .../devicetree/bindings/net/qualcomm-bluetooth.txt | 69
>>>>> -------------
>>>>> .../bindings/net/qualcomm-bluetooth.yaml | 111
>>>>> +++++++++++++++++++++
>>>>> 2 files changed, 111 insertions(+), 69 deletions(-)
>>>>> delete mode 100644
>>>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.txt
>>>>> create mode 100644
>>>>> Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
>>>>
>>>>
>>>>> diff --git
>>>>> a/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
>>>>> b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
>>>>> new file mode 100644
>>>>> index 0000000..3f3ec4d
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/net/qualcomm-bluetooth.yaml
>>>>> @@ -0,0 +1,111 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>>> +%YAML 1.2
>>>>> +---
>>>>> +$id: http://devicetree.org/schemas/net/qualcomm-bluetooth.yaml#
>>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>>>> +
>>>>> +title: Qualcomm Bluetooth Chips
>>>>> +
>>>>> +maintainers:
>>>>> + - Marcel Holtmann <[email protected]>
>>>>
>>>> This should be someone who cares about Qcom BT.
>>>
>>> yes, please, assign this to someone that knows the hardware.
>>>
>>> Rob, can we leave this out for now if there is no dedicated person?
>>
>> No, it's required. It can be me if it comes to that. However, if no
>> one can be bothered to step up, then we should just remove it perhaps.
>> QCom is a big company, I'm sure they can find some name.
>
> I hope so as well since my name is clearly the wrong one there. I have
> too little knowledge about that hardware and the platforms it is used
> in.
>
[Venkata]:
I will update maintainers names in next patchset.
> Regards
>
> Marcel
Regards,
Venkata.