2022-03-24 23:39:30

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ] a2dp: Always invalidate the cache if its configuration fails

From: Luiz Augusto von Dentz <[email protected]>

When a configuration had been restored from last_used cache but it
fails invalidate it so another sep can be used.

Fixes: https://github.com/bluez/bluez/issues/313
---
profiles/audio/a2dp.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
index d66c22b2b..c3ac432a7 100644
--- a/profiles/audio/a2dp.c
+++ b/profiles/audio/a2dp.c
@@ -872,12 +872,10 @@ static void store_remote_seps(struct a2dp_channel *chan)
static void invalidate_remote_cache(struct a2dp_setup *setup,
struct avdtp_error *err)
{
- if (err->category == AVDTP_ERRNO ||
- err->err.error_code != AVDTP_UNSUPPORTED_CONFIGURATION)
+ if (err->category == AVDTP_ERRNO)
return;

- /* Attempt to unregister Remote SEP if configuration
- * fails with Unsupported Configuration and it was
+ /* Attempt to unregister Remote SEP if configuration fails and it was
* loaded from cache.
*/
if (setup->rsep && setup->rsep->from_cache) {
--
2.35.1


2022-03-25 19:15:44

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ] a2dp: Always invalidate the cache if its configuration fails

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=626173

---Test result---

Test Summary:
CheckPatch PASS 0.71 seconds
GitLint PASS 0.51 seconds
Prep - Setup ELL PASS 54.69 seconds
Build - Prep PASS 0.72 seconds
Build - Configure PASS 10.80 seconds
Build - Make PASS 1880.84 seconds
Make Check PASS 12.88 seconds
Make Check w/Valgrind PASS 571.74 seconds
Make Distcheck PASS 301.33 seconds
Build w/ext ELL - Configure PASS 10.99 seconds
Build w/ext ELL - Make PASS 1833.37 seconds
Incremental Build with patchesPASS 0.00 seconds



---
Regards,
Linux Bluetooth

2022-03-28 22:28:20

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH BlueZ] a2dp: Always invalidate the cache if its configuration fails

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 24 Mar 2022 15:18:18 -0700 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> When a configuration had been restored from last_used cache but it
> fails invalidate it so another sep can be used.
>
> Fixes: https://github.com/bluez/bluez/issues/313
>
> [...]

Here is the summary with links:
- [BlueZ] a2dp: Always invalidate the cache if its configuration fails
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=62e591578e3f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html